[Awaiting checklist] [$250] Edit comment - Remaining text in the composer is highlighted after deleting text

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-16
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Account has a lot of chats (so that LHN is not empty).

1. Go to staging.new.expensify.com
2. Go to chat.
3. Send a message.
4. Right click on the message > Edit comment.
5. Highlight the first portion of the message by dragging from right all the way to LHN.
6. Delete the highlighted text.

Expected Result:

The remaining text will not be highlighted after deleting the text.

Actual Result:

The remaining text is highlighted after deleting the text.
This issue only happens when dragging the text until the cursor reaches LHN.
This issue is not reproducible when the LHN is empty (where the cursor reaches when dragging).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6506203_1717851623011.20240608_205136.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f82bb45e00f7a15
• Upwork Job ID: 1799816413393580513
• Last Price Increase: 2024-06-09
• Automatic offers:
• ShridharGoel | Contributor | 102678292

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f82bb45e00f7a15

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting text, reamining text is highlighted in the composer as shown in the video.

What is the root cause of that problem?

Upgrading react-native-live-markdown to 0.1.82 caused this issue in PR: https://github.com/Expensify/App/pull/43255/files

What changes do you think we should make in order to solve the problem?

contentSelection ref is updated after parse text here (https://github.com/Expensify/react-native-live-markdown/pull/370/files#diff-ec487e4a4ccb9c4ffd7ead6ff0a585595aa8d9e9b7d5167d0a2444d70d2001e1R367)

Revert this code in react-native-live-markdown: #41137. PR :Expensify/react-native-live-markdown#370

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump live-markdown to 0.1.83 #43340

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @ShridharGoel requires payment automatic offer (Contributor)
• @jainilparikh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump live-markdown to 0.1.83 #43340

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @ShridharGoel requires payment automatic offer (Contributor)
• @jainilparikh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jainilparikh]

@allroundexperts , can we please process the payment for this ?, It's 18th June as mentioned in this message: #43332 (comment)

[twisterdotcom]

Hey! I'm the one responsible for payment - apologies but I'm going off the last date here which is the 20th. Do we know why there are two?

[Tony-MK]

@twisterdotcom, From the slack conversation with @mountiny, we decided to split the payment.

@jainilparikh and I don't have a problem with this.

Thanks.

[jainilparikh]

Thanks twisterdotcom, I don't mind waiting till 20th it's just one more day. Also to add on Tony's comment, yes, the amount will be split between shridhar, Tony and me.

[mountiny]

Ok I think @ShridharGoel did most work with the revert so suggesting this division:

so:

• @ShridharGoel $150
• @jainilparikh $50
• @Tony-MK $50
• @allroundexperts $250 for review and testing

We should probably add penalty to C+ on this issue for missing these regressions #43255

[twisterdotcom]

Huge thanks to @mountiny here. Okay, 🎉 Here we are, it's the 20th. Payment Summary:

• @jainilparikh paid $50 here (Contributor)
• @Tony-MK paid $50 here (Contributor)
• @ShridharGoel paid $150 here (Contributor)
• @allroundexperts paid $250 via newDot requests (C+)

@allroundexperts have we handled regression steps already?

[jainilparikh]

Accepted the offer, please approve payment on upwork. Thanks everyone.

[mallenexpensify]

We should probably add penalty to C+ on this issue for missing these regressions

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

Looks like it was @ishpaul777 , that PR was a monster (most linked fixed issues I've ever seen in a PR). I'm unsure which of those issues would be the one for payment. Any thoughts here @ishpaul777 ?

[ishpaul777]

This one is the issue #43255 (which was a deploy blocker), i'll be getting paid through, I apologize for missing these bugs a lottt of stuf was there to test, my main focus was to whether the issues linked was fixed or not since i was not involved in their react-native-live-markdown PRs i dont have much context on exact changes what effect they will have.

[allroundexperts]

@allroundexperts have we handled regression steps already?

I don't think so. The steps given in the OP look good enough to me!

[JmillsExpensify]

$250 approved for @allroundexperts