[$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Expense with tag in Parent: Child formay shows Parent\: Child in the list

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace has enabled Tags.
• Workspace has a tag in Parent: Child format.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with tag in Parent: Child format.
4. Go to Search.
5. Look for the expense created in Step 4.

Expected Result:

The expense will show tag in Parent: Child format.

Actual Result:

The expense shows tag in Parent: Child format.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6507946_1718021760174.tag.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0149bba73f155a9d6c
• Upwork Job ID: 1801702973512124343
• Last Price Increase: 2024-06-14

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tag name has \ before the colon on the search page.

What is the root cause of that problem?

The tag name colon is escaped when we save it, so there is a \ before the colon and we don't unescaped the tag before displaying it on the search page.

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Lines 181 to 192 in 350b7ab

	return isLargeScreenWidth ? (
	<TextWithTooltip
	shouldShowTooltip={showTooltip}
	text={transactionItem?.tag}
	style={[styles.optionDisplayName, styles.label, styles.pre, styles.justifyContentCenter]}
	/>
	) : (
	<TextWithIconCell
	icon={Expensicons.Tag}
	showTooltip={showTooltip}
	text={transactionItem?.tag}
	/>

What changes do you think we should make in order to solve the problem?

To unescape/clean the tag name, we can use getTagForDisplay to get the tag and then clean it with getCleanedTagName.

App/src/libs/TransactionUtils.ts

Lines 458 to 460 in 66cd707

	function getTagForDisplay(transaction: OnyxEntry<Transaction>, tagIndex?: number): string {
	return getCleanedTagName(getTag(transaction, tagIndex));
	}

text={TransactionUtils.getTagForDisplay(transactionItem)}

[luacmartins]

I can take this one since it's related to Search.

[luacmartins]

@bernhardoj are you available to work on the PR now?

[bernhardoj]

@luacmartins yes, I'm available.

[luacmartins]

Nice! It's yours

[joekaufmanexpensify]

@luacmartins / @bernhardoj do we need to complete BZ checklist for this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0149bba73f155a9d6c

[joekaufmanexpensify]

Only payment here is $250 to @bernhardoj for PR via Upwork. Offer sent!

[joekaufmanexpensify]

I'm about to go OOO until 2024-06-24, so adding an additional BZ assignee here to watch this while I'm gone. If this is still open, I'll take it back once I return!

[bernhardoj]

I can help with the checklist

The PR that introduced the bug has been identified. Link to the PR: #41102

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41102/files#r1640596740

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

Determine if we should create a regression test for this bug. Since the QA caught it, there is probably already a regression test. If not, then we can use the OP test.

[melvin-bot]

@puneetlath, @luacmartins, @bernhardoj, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[joekaufmanexpensify]

Back from OOO. Going to work through next steps today!

[joekaufmanexpensify]

Checklist is all set

[joekaufmanexpensify]

@bernhardoj $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!