Deploy Checklist: New Expensify 2024-06-10

[github-actions]

Release Version: 1.4.81-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

• feature: Add validation flow to bank account set up #38726
• Fix - Distance request thumbnail is different in reports preview when created offline  #39243
• feat: surfacing potential duplicates #40153
• [Search v1] Implement Bottom Tab Bar Changes #40293
• fix illustration is sitting too far down #40822
• move message "admins only can post" from welcome message to footer #41199
• [No QA][TS Migration] Add comments for remaining properties in Onyx types #41956
• [Invoice Rooms] Write capability fix #42179
• feat: hold expense in one transaction view #42374
• fix: Can't view receipt from Split Expense details view #42399
• fix: Distance unit isn't updated immediately #42409
• [No QA] Use double negation instead of Boolean() #42492
• Fix endless loading thread report header #42504
• Allow selecting an existing invoice room as the receiver in the Send Invoice flow from FAB #42714
• Immediately show file size message for large attachments #42739
• feat: implement card section for subscription #42787
• #2 - Fix user can submit 10-digit amount and gives an unexpected error #42815
• Fix removed user in offline is not crossed #42817
• fix Login error isn't appearing when you tap away #42830
• Implement unvalidated signups for newDot #42887
• chore: remove all selection ranges during navigation #42961
• handle focus after edit report item #42965
• Fix the cursor moves one space backward when inserting text after an emoji #42985
• feat: Subscription settings UI #42990
• DOCS: Create Set-default-report-title.md #43000
• DOCS: Create Add-custom-report-fields.md #43002
• Make renaming of tags works #43005
• fix: add paddingRight for blockquote #43017
• Fix chat doesn't scroll to bottom #43021
• [NoQA] e2e: exclude warmup results from final measurements #43023
• enable new focus management for waypoint and report field page #43041
• fix: add redirect when policy connection is enabled #43043
• fix: stale personal details while creating task with new user #43059
• Create Member.ts utils file #43066
• Create transaction thread if needed #43070
• Fix console error in ReportFooter #43083
• prevent autoscroll to bottom on android when last track expense whisper is unresolved #43085
• [NO QA] Ignore vim temp files #43088
• fix: call net info refresh on each reachability check #43090
• fix Keyboard opens and closes when tapping on split input #43091
• Fix action button width, disable sorting by Taxes #43140
• [No QA] Fix verifyPodfile script #43154
• Fix crash if report doesnt have transactions #43192
• [NoQA] Add environment as an identifying property for Fullstory #43194
• Update node version for qsp #43204
• Always show categories, tags and taxes columns #43206
• [NoQA] Update en.ts #43228
• Replace Boolean by !! #43232
• [No QA] Revert "[No QA] Temporarily disable queries that are not implemented yet" #43234
• Do not add the guide calendar link optimistically #43236
• Fix workspace avatar for invoice chat is missing background #43244
• fix: apply border radius styling to video thumbnail #43245
• remove conflicting dupe prop #43269
• [HybridApp] Change switchToOldDot to return a promise #43275
• Delete docs/articles/new-expensify/travel/Coming-Soon.md #43295
• [HelpDot] Add instructions to hide an article #43299
• Return early and prevent calling API if value didn't change #43308
• [NoQA] Add missing js doc to fix lint #43337
• [CP Staging][Search v1] Fix random sorting on mobile #43380
• [CP staging] Prevent navigating to Search when user is anonymous #43390
• [CP Staging] Show cleaned tag name in search page result #43392
• [CP Staging] Fix topbar text overflow #43429
• Revert "chore: remove all selection ranges during navigation" #43431
• [CP-stag] Removing check for shouldShowHoldMessage #43446
• Revert "Immediately show file size message for large attachments" #43447
• Prevent crash when connecting to QuickBooks Online #43451
• [CP Staging] Fix composer is hidden behind keyboard when composer in transaction thread is focused #43483
• [CP Staging] [Search v1] Fix for workspace switcher and back to search tab on Android #43500

Deploy Blockers:

• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Composer focus is lost if a new message is received while typing #43351
• [HOLD for payment 2024-06-20] [$125] [Search v1] Android - Search - Workspace switcher and Search show different selected workspace #43356
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Search v1] Android - Search - Not here page shows up when returning to Search from Account settings #43358
• [HOLD for payment 2024-09-25] [$250] Contact Method - Magic code doesn't arrive unless user requests again #43359
• [HOLD for payment 2024-06-20] [$125] [Search v1] - Search opens and loads infinitely when opening as logged out user #43360
• [HOLD for payment 2024-06-20] Send invoice - Invoice chat still appears in member list when workspace is deleted #43361
• [HOLD for payment 2024-06-28] [$250] [Search v1] - Selected expense at the bottom of the list is not revealed when selected via keyboard #43362
• [$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Expense with tag in Parent: Child formay shows Parent\: Child in the list #43364
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Composer - Composer is not in focused when switching chat #43369
• [$250] Task – Broken image appears when assign task to non-existing user #43373
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mWeb - chat - device keyboard closed after entering emoji #43375
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Sorting on mobile is random #43376
• [Search v1] - Unable to sort expenses by "Type", and "Receipt" #43388
• [Search v1] Search - "Nothing to show" label is missing if you create an empty report in OD #43389
• [PAID] [$250] [Search v1] - Sometimes blank space appears instead of skeleton loader when scrolling #43396
• [HOLD for payment 2024-07-23] [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted #43407
• [Search v1] - Deleted expense is not removed from Search #43415
• [HOLD for payment 2024-07-10] [$250] Distance - Map pending not scaled and not fully visible when creating > 1 expenses #43420
• [$500] Workspace - Keyboard is flickering when entering magic code at bank account flow #43425
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Breadcrumbs text overflows for Search page #43426
• Chats are showing wrong current time of the user chatting with  #43438
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Hold expense - "Hold" label appears twice on the expense preview #43440
• OS - Chat - Images taken in HEIC with the device are not displayed on chat #43441
• Account - Welcome message not displayed when Sign Up with Expensifail domain #43468
• Subscription - Checkboxes under "Subscription details" are always in dark mode #43471
• [HOLD for payment 2024-07-10] [Search v1] - Scanning expense displays 0.00 in Total column and the Merchant column is blank #43474
• [HOLD for payment 2024-06-20] [Search v1] - Skeleton appears under expenses when sorting expenses when there is no more expenses #43476
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] iOS - Search - Composer is hidden behind keyboard when composer in transaction thread is focused #43477
• [HOLD for payment 2024-06-28] [$250] [Search v1] iOS - Search - Background behind the transaction thread is blank when swiping to right #43478
• Duplicates - Edited duplicate show "Review required" when there is no error or violation #43487
• Contact Method - User is logged out after adding a secondary contact method #43501

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.81-1 🚀

[Julesssss]

Checked off #43356, as it is a minor style issue on a new feature

[tgolen]

Demoting #43373 because I couldn't reproduce it

[carlosmiceli]

#43362 doesn't seem to be a blocker because it's a style issue on the new Search.

[luacmartins]

Demoted #43389. Fix is in Auth

[luacmartins]

Demoting #43359. Couldn't reproduce in staging.

[rlinoz]

Demoting #43361

[luacmartins]

Demoted #43396

[luacmartins]

Demoted #43407

[luacmartins]

Demoted #43420

[kbecciv]

TR is 50% left!

#40153 is pending verification on Desktop
#42179 is pending verification on IOS
#42399 is pending verification on IOS
#42714 is pending verification on IOS
#42739 is pending verification on mWeb, Android and IOS
#42815 is pending verification on IOS
#42817 is pending verification on IOS
#42830 is pending verification on IOS
#42887 is pending verification
#42961 is pending verification on IOS
#42965 is pending verification on IOS
#42985 is pending verification on IOS
#42990 is pending verification
#43005 is pending verification on Android and IOS app
#43017 is pending verification on IOS
#43021 is pending verification
#43041 is pending verification on mWeb and Android
#43043 is pending verification on IOS
#43059 is pending verification on IOS
#43083 is pending verification
#43085 s pending verification on IOS
#43090 is failing on Web with #43398, repro in Prod, checking off
#43206 is pending verification on IOS
#43236 is pending verification on IOS
#43244 is pending verification on Web
#43245 is pending verification on IOS
#43429 is pending verification

[roryabraham]

Demoting #43425

[chiragsalian]

Checking off deploy blocker #43440. Resolved and tested on staging (post).

Edit from @Beamanator : Also checking off the PR that resolved this issue - #43446

[kbecciv]

TR is 25% left

#40153 is failing with #43428, repro in Prod - checking off
#42739 is failing with #38478 on Android app, left comment #42739 (comment)
#42887 is pending verification on mWeb and Desktop
#42990 is pending verification on Desktop
#43005 is pending verification on Android and IOS app
#43021 is pending verification on Desktop
#43083 - Can this be verified internally - #43083 (comment)?
#43244 is pending verification on Web
#43275 is pending verification

[NikkiWines]

Demoting #43438 since it's be reproducible on production for a while now

[Beamanator]

#43441 seems to have been fixed by reverting #43447, which tested well on staging - checking off both

[roryabraham]

Checking off #43083 per https://expensify.slack.com/archives/C02NK2DQWUX/p1718084643005429?thread_ts=1718066579.857979&cid=C02NK2DQWUX

[kbecciv]

TR is 1% left!

#42739 is failing with #38478 on Android app, left comment #42739 (comment)
#42990 is failing with #43466 on Web, mWeb and Desktop, repro in Prod, checking off

Deploy Blockers:
#43358
#43468
#43471

[kbecciv]

TR is completed!

#42739 is failing with #38478 on Android app, left comment #42739 (comment)
#42990 is failing with #43466 on Web, mWeb and Desktop, repro in Prod, checking off

Deploy Blockers:
#43358
#43468
#43477

[luacmartins]

Checking off #42739. It was reverted

[luacmartins]

Demoted #43487

[luacmartins]

Fixed by CP #43477

[francoisl]

#43500 confirmed working, checking it off

[luacmartins]

Demoted #43501

[luacmartins]