Fix chat doesn't scroll to bottom #43021

nkdengineer · 2024-06-04T06:08:23Z

Details

Fix chat doesn't scroll to bottom

Fixed Issues

$ #40724
PROPOSAL: #40724 (comment)

Tests

For attachments, text messages, For whispers.

Open a DM chat or WS chat that has long history chat
Send an attachments
Verify that the chat scrolls to the bottom
Scroll to the top and send a message
Verify that the chat scrolls to the bottom
Create a split expense
Verify that the chat scrolls to the bottom

For IOU reports, For IOU previews.

Open a IOU report
Send a message
Verify that the chat scrolls to the bottom
Submit an expense
Verify that the chat scrolls to the bottom

For thread replies

Open a thread with long history chat
Scroll to the top and send a message
Verify that the chat scrolls to the bottom

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

For attachments, text messages, For whispers.

Open a DM chat or WS chat that has long history chat
Send an attachments
Verify that the chat scrolls to the bottom
Scroll to the top and send a message
Verify that the chat scrolls to the bottom
Create a split expense
Verify that the chat scrolls to the bottom

For IOU reports, For IOU previews.

Open a IOU report
Send a message
Verify that the chat scrolls to the bottom
Submit an expense
Verify that the chat scrolls to the bottom

For thread replies

Open a thread with long history chat
Scroll to the top and send a message
Verify that the chat scrolls to the bottom

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

For attachments, text messages, For whispers.

Screen.Recording.2024-06-04.at.12.46.52.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-04.at.12.50.19.mov

For thread replies

Screen.Recording.2024-06-04.at.12.50.56.mov

Android: mWeb Chrome

For attachments, text messages, For whispers.

Screen.Recording.2024-06-04.at.12.44.33.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-04.at.12.45.37.mov

For thread replies

Screen.Recording.2024-06-04.at.12.46.13.mov

iOS: Native

For attachments, text messages, For whispers.

ios-1-1.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-03.at.13.11.07.mov

For thread replies

Screen.Recording.2024-06-03.at.13.11.52.mov

iOS: mWeb Safari

For attachments, text messages, For whispers.

safari-1.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-04.at.12.37.45.mov

For thread replies

Screen.Recording.2024-06-04.at.12.40.19.mov

MacOS: Chrome / Safari

For attachments, text messages, For whispers.

case1-1.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-03.at.10.59.00.mov

For thread replies

Screen.Recording.2024-06-03.at.10.59.16.mov

MacOS: Desktop

For attachments, text messages, For whispers.

desktop-1.mov

For IOU reports, For IOU previews.

Screen.Recording.2024-06-04.at.12.55.12.mov

For thread replies

Screen.Recording.2024-06-04.at.12.55.30.mov

melvin-bot · 2024-06-04T06:10:33Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-06-04T14:24:31Z

Testing...

mountiny · 2024-06-04T15:43:21Z

Running a build

parasharrajat · 2024-06-04T15:59:45Z

Looks like we will reintroduce #41188

github-actions · 2024-06-04T16:13:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43021/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43021/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43021/NewExpensify.dmg	https://43021.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-06-04T16:52:41Z

@parasharrajat what is your ETA on this one? I think this on eis one of the most important PRs to get out now in App

parasharrajat · 2024-06-04T16:54:02Z

I posted one issue above. I am testing other parts too.

src/libs/actions/IOU.ts

nkdengineer · 2024-06-05T08:08:48Z

src/pages/home/report/ReportActionsList.tsx

@@ -210,12 +210,9 @@ function ReportActionsList({
        [sortedReportActions, isOffline],
    );

-    // whisper action doesn't affect lastVisibleActionCreated, so we should not take it into account while checking if there is the newest report action
-    const newestVisibleReportAction = useMemo(() => sortedVisibleReportActions.find((item) => !ReportActionsUtils.isWhisperAction(item)) ?? null, [sortedVisibleReportActions]);


Looks like we will reintroduce #41188

@parasharrajat

I believe it's a back-end bug. After we start s split bill, BE doesn't return the updated lastVisibleActionCreated of the report but when OpenReport API is called, we can see the lastVisibleActionCreated is returned as the created of split whisper action above.

So I removed this change from this PR. If not when we reload this report and send any action like message, expense, ... the chat will not scroll to the bottom

@mountiny Do you know why it is different on backend? The comment says that whisper does not affect the lastVisibleActionCreated time.

Is this for the same account that created the split bill request? If so, we should use the whisper created, no?

Commented in Slack

Following along because I'm the BZ team member on #41188. Do you all feel that a regression was introduced in that issue? It's due to be paid out, but I will hold on that if there's a regression.

There was no regression as such.

Awesome. Thanks, @parasharrajat!

parasharrajat · 2024-06-05T10:18:06Z

Continue testing...

Yesterday, I was looking into the various functions that create actions for reports but I saw a few of them does not update lastVisibleActionCreated for parent report. Reason is not very clear to me. I am going to test each type of action one by one and observe the results.

parasharrajat · 2024-06-05T10:36:34Z

@nkdengineer

Let's dicsuss one case for getSendInvoiceInformation

How the time will match for both the report and last action? Both functions are using same DateUtils.getDBTime function like the one in addActions.

And if this is working fine, why doesn't it work for addActions too?

App/src/libs/actions/IOU.ts

Line 1735 in a67be2f

    
           const optimisticInvoiceReport = ReportUtils.buildOptimisticInvoiceReport(chatReport.reportID, senderWorkspaceID, receiverAccountID, receiver.displayName ?? '', amount, currency);

App/src/libs/actions/IOU.ts

Line 1783 in a67be2f

ReportUtils.buildOptimisticMoneyRequestEntities(

nkdengineer · 2024-06-05T14:36:26Z

Let's dicsuss one case for getSendInvoiceInformation

@parasharrajat

Currently, we still have the different at two place we call DateUtils.getDBTime() let see this image below for more detail.
But the different time is too small or usually no different so when we convert this to iso string, it's equal.

Checked again with addActions and I saw the current RCA. We call DateUtils.getDBTimeWithSkew which doesn't work as expected

App/src/libs/actions/Report.ts

Line 476 in 66b4072

const currentTime = DateUtils.getDBTimeWithSkew();

Let see here, when we call getDBTimeWithSkew() without any param, the timestamp now is empty that make new Date(timestamp).valueOf() is NaN and then getDBTime(NaN) will return the current time without networkTimeSkew

App/src/libs/DateUtils.ts

Line 383 in 66b4072

return getDBTime(new Date(timestamp).valueOf() + networkTimeSkew);

Meanwhile here we call getDBTimeWithSkew with the timestamp is the current time (createdOffset is 0 in this case) and then it will return the time with additional networkTimeSkew

App/src/libs/ReportUtils.ts

Line 3574 in 66b4072

created: DateUtils.getDBTimeWithSkew(Date.now() + createdOffset),

That is the reason why for addActions case, lastVisibleActionCreated is always less than created of last action.

The solution here is we should update getDBTimeWithSkew to make it work as expected like this

function getDBTimeWithSkew(timestamp: string | number = ''): string {
    if (networkTimeSkew > 0) {
        const datetime = timestamp ? new Date(timestamp) : new Date();
        return getDBTime(datetime.valueOf() + networkTimeSkew);
    }
    return getDBTime(timestamp);
}

parasharrajat · 2024-06-05T16:00:25Z

So why's aren't we changing this instead of current solution on the PR?

nkdengineer · 2024-06-05T16:24:40Z

So why's aren't we changing this instead of current solution on the PR?

@parasharrajat

I didn't check about getDBTimeWithSkew before. Updated it now.
The current solution can make sure that lastVisibleActionCreate and created are always the same. We can't make sure that call DateUtils.getDBTime at two place can return the same result because if the first place has complex logic, it can have some delay when we call DateUtils.getDBTime. For example, for the case when we create request money, if we get DateUtils.getDBTime in buildOnyxDataForMoneyRequest the time will be different from iouAction.created

src/libs/actions/IOU.ts

nkdengineer · 2024-06-06T04:50:45Z

@parasharrajat I updated to fix two cases above.

ios/Podfile.lock

parasharrajat · 2024-06-06T21:05:42Z

Screenshots

🔲 iOS / native

08.06.2024_00.43.31_REC.mp4

🔲 iOS / Safari

08.06.2024_02.23.05_REC.mp4

🔲 MacOS / Desktop

08.06.2024_01.49.32_REC.mp4

🔲 MacOS / Chrome

hm.mp4

07.06.2024_02.26.16_REC.mp4

🔲 Android / Chrome

08.06.2024_02.12.16_REC.mp4

🔲 Android / native

07.06.2024_23.29.46_REC.mp4

07.06.2024_23.32.28_REC.mp4

07.06.2024_23.39.39_REC.mp4

parasharrajat · 2024-06-06T21:09:56Z

So currently, I am facing chat loading issues. I am still trying to test other cases as much as possible.

Pending tests:

New line indicator tests.
LHN chat order.

parasharrajat · 2024-06-07T18:08:30Z

@mountiny @luacmartins I noticed that the chat scrolls to bottom first and then the new message is created/shown to the user. Do you think it is correct behaviour? Or is it supposed to happen together? Or when chat is scrolled to bottom the message should already be there.

can we move forward this behaviour on this PR?

07.06.2024_23.32.28_REC.mp4

luacmartins · 2024-06-07T18:53:51Z

Hmm I'd say that ideally it scrolls at the same time we create the action, but I'm not sure this should be a blocker here since the current behavior (not scrolling) is worse

parasharrajat · 2024-06-07T19:19:40Z

Testing new line indicator...

parasharrajat · 2024-06-07T20:13:30Z

BUG: Android:IOS: New line marker hides immediately when opening a unread chat.

Steps:

Open the app.
Got to LHN.
Send a message from USER A to USER B.
Open the chat with User B on device 2.
Observe that the new marker hides immediately.

parasharrajat · 2024-06-07T20:15:38Z

BUG: Android: ioS: The new message button does not show until chat is scrolled.

Steps:

Open a chat between user a and user B.
Scroll in the chat history.
Send msg from B to A.
Observe that new message button does not show until we scroll the chat a bit.

parasharrajat · 2024-06-07T21:00:09Z

Sometimes, the chat does not scroll to the bottom. It only happens once and then for all messages chat scrolls fine. I noticed this on multiple platforms.

Here is the vid. Check the message at 0:12 sec. I believe this might have a different root cause.

Untitled.mp4

parasharrajat · 2024-06-07T21:16:49Z

OK, so both of these bugs are present on main #43021 (comment) & #43021 (comment).

Which means new line marker is broken ATM. cc @luacmartins

parasharrajat · 2024-06-07T21:18:31Z

The rest looks pretty good. Can we proceed with the above issues? @luacmartins

mountiny · 2024-06-08T00:20:43Z

@parasharrajat so you were not able to find any issues that are not repro in main as well?

mountiny

Changes look good to me and if all the bugs you were able to find also exist in main, I think we can proceed and hope there wont be anything bad

parasharrajat · 2024-06-08T09:27:37Z

@nkdengineer What do you think about #43021 (comment) & #43021 (comment) & #43021 (comment)

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2024-06-09T09:28:52Z

I think we can move forward with the PR. It solves the main issue.

nkdengineer · 2024-06-10T04:01:08Z

@nkdengineer What do you think about #43021 (comment) & #43021 (comment) & #43021 (comment)

I think we can move forward with this PR since these bugs also happen on main.

mountiny

deploy checklist is not locked yet, I will merge this so we can get it to staging now

OSBotify · 2024-06-10T08:36:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.81-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins

Thanks for working on this!

OSBotify · 2024-06-11T23:34:25Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkdengineer added 3 commits June 3, 2024 12:19

fix chat doesn't scroll to bottom

0c7c71d

Merge branch 'main' into fix/40724

276b5fd

fix lint

d4e7d5d

nkdengineer marked this pull request as ready for review June 4, 2024 06:10

nkdengineer requested a review from a team as a code owner June 4, 2024 06:10

melvin-bot bot requested review from parasharrajat and removed request for a team June 4, 2024 06:10

nkdengineer mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] CRITICAL: [UX Reliability] [$1000] Chat - Chat does not scroll down when sending messages #40724

Closed

6 tasks

luacmartins self-requested a review June 4, 2024 14:10

mountiny assigned nkdengineer Jun 4, 2024

mountiny added the Ready To Build label Jun 4, 2024

mountiny self-requested a review June 4, 2024 15:43

parasharrajat suggested changes Jun 4, 2024

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

Merge branch 'main' into fix/40724

5975d53

nkdengineer commented Jun 5, 2024

View reviewed changes

move update to buildOnyxDataForMoneyRequest

9a3491b

merge main

7fcaeca

parasharrajat reviewed Jun 5, 2024

View reviewed changes

src/libs/actions/IOU.ts Show resolved Hide resolved

parasharrajat suggested changes Jun 6, 2024

View reviewed changes

ios/Podfile.lock Outdated Show resolved Hide resolved

nkdengineer added 2 commits June 7, 2024 11:32

Merge branch 'main' into fix/40724

2abf605

revert unrelated change

9a8a96b

johncschuster mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-06] CRITICAL: [$250] Clicking New messages when there are no new messages inexplicably calls OpenReport, and doesn't clear #41188

Closed

6 tasks

mountiny approved these changes Jun 8, 2024

View reviewed changes

parasharrajat approved these changes Jun 9, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny June 9, 2024 09:18

Merge branch 'main' into fix/40724

9f7ea10

mountiny approved these changes Jun 10, 2024

View reviewed changes

mountiny merged commit feba10e into Expensify:main Jun 10, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

luacmartins reviewed Jun 10, 2024

View reviewed changes

nkdengineer mentioned this pull request Jun 11, 2024

[$250] Chat - New message button is not responsive when marking expense as unread #42144

Closed

6 tasks

Fix chat doesn't scroll to bottom #43021

Fix chat doesn't scroll to bottom #43021

Conversation

nkdengineer commented Jun 4, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 4, 2024

parasharrajat commented Jun 4, 2024

mountiny commented Jun 4, 2024

parasharrajat commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

mountiny commented Jun 4, 2024

parasharrajat commented Jun 4, 2024 • edited Loading

nkdengineer Jun 5, 2024

Choose a reason for hiding this comment

parasharrajat Jun 5, 2024

Choose a reason for hiding this comment

luacmartins Jun 5, 2024

Choose a reason for hiding this comment

mountiny Jun 6, 2024

Choose a reason for hiding this comment

johncschuster Jun 7, 2024

Choose a reason for hiding this comment

parasharrajat Jun 7, 2024

Choose a reason for hiding this comment

johncschuster Jun 7, 2024

Choose a reason for hiding this comment

parasharrajat commented Jun 5, 2024 • edited Loading

parasharrajat commented Jun 5, 2024 • edited Loading

nkdengineer commented Jun 5, 2024

parasharrajat commented Jun 5, 2024

nkdengineer commented Jun 5, 2024

nkdengineer commented Jun 6, 2024

parasharrajat commented Jun 6, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Jun 6, 2024

parasharrajat commented Jun 7, 2024

luacmartins commented Jun 7, 2024

parasharrajat commented Jun 7, 2024

parasharrajat commented Jun 7, 2024

parasharrajat commented Jun 7, 2024

parasharrajat commented Jun 7, 2024 • edited Loading

parasharrajat commented Jun 7, 2024

parasharrajat commented Jun 7, 2024

mountiny commented Jun 8, 2024

mountiny left a comment

Choose a reason for hiding this comment

parasharrajat commented Jun 8, 2024

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Jun 9, 2024

nkdengineer commented Jun 10, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 10, 2024

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 11, 2024

parasharrajat commented Jun 4, 2024 •

edited

Loading

parasharrajat commented Jun 5, 2024 •

edited

Loading

parasharrajat commented Jun 5, 2024 •

edited

Loading

parasharrajat commented Jun 6, 2024 •

edited

Loading

parasharrajat commented Jun 7, 2024 •

edited

Loading