[HOLD for payment 2024-06-28] [$250] [Search v1] - Selected expense at the bottom of the list is not revealed when selected via keyboard

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Account has many expenses.

1. Go to staging.new.expensify.com
2. Go to Search.
3. Go to Shared.
4. Navigate to the expense at the bottom of the list via keyboard.

Expected Result:

The list will scroll to reveal the selected expense when the list reaches the bottom.

Actual Result:

The selected expense at the bottom of the list is not revealed when selected via keyboard.
The list scrolls up and down when selecting the expenses at the bottom.
NOTE : To easily reproduce the bug have lots of multiple expenses reports

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6507947_1718021760621.search_scroll.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ce2d74723ba0e19
• Upwork Job ID: 1800170202120056394
• Last Price Increase: 2024-06-10
• Automatic offers:
• fedirjh | Reviewer | 102699946

Issue Owner

Current Issue Owner: @fedirjh / @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ce2d74723ba0e19

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[carlosmiceli]

I don't think this is a blocker because I'm not seeing anything in the checklist that could be impacting this, considering also the novel status of Search.

[Christinadobrzyn]

I'm not able to reproduce this - testing this some more

This is reproducible based on the steps in the OP - waiting for proposals

[Christinadobrzyn]

I think that sounds good @Kicu I'll assign you... I probably should have asked the team, does that sound good @carlosmiceli @luacmartins @fedirjh?

[luacmartins]

Yea, all good

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix wrong scrolling in Search list when navigating by keyboard #43490

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @fedirjh requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Payouts due:

• Contributor+: $250 @fedirjh (Paid through NewDot)

@fedirjh do we need a regression test?

[Christinadobrzyn]

Nudge @fedirjh about these questions - #43362 (comment)

[fedirjh]

BugZero Checklist:

• Link to the PR: It's not a regression, SelectionList was not compatible with the new Search.
• Link to comment: N/A
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Open App
2. Go to Search
3. Use keyboard to navigate over search list items : use Tab key, and also up and down keyboard keys
4. Verify the focus and scroll is working correctly

• Do we agree 👍 or 👎

[fedirjh]

I see an offer in Upwork but not sure if you're paid in NewExpensify now?)

@Christinadobrzyn I will request a payment on new Dot.

[Christinadobrzyn]

Thanks @fedirjh!

regression test here - https://github.com/Expensify/Expensify/issues/409709

Payment summary for payment through NewDot here - #43362 (comment)

Closing!

[JmillsExpensify]

$250 approved for @fedirjh