[$250] mWeb -Error page when open #exfy-roadmap while #new-expensify-feedback is open

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4622123&group_by=cases:section_id&group_id=229066&group_order=asc
Email or phone of affected tester (no customers): gocemate+a233@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Logout of New Expensify if logged in
2. Navigate to the following link - https://staging.new.expensify.com/r/6776919265133947
   (#new-expensify-feedback)
3. While #new-expensify-feedback is open navigate to the following link - https://staging.new.expensify.com/r/868417741568295
   (#exfy-roadmap)

Expected Result:

#exfy-roadmap room should open and chat history should be visible

Actual Result:

Error page appears when navigate to #exfy-roadmap link while #new-expensify-feedback is open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510717_1718191721627.Recording__3174.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e4f9542b1cde2bc
• Upwork Job ID: 1800937045717141030
• Last Price Increase: 2024-07-17

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@youssef-lr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[youssef-lr]

This is reproducible on production too, removing blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e4f9542b1cde2bc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tsa321]

@rushatgabhane I think the simple solution is to change the comparison in here:

App/src/libs/actions/OnyxUpdates.ts

Lines 85 to 86 in 75c104b

	if (lastUpdateID && lastUpdateIDAppliedToClient && Number(lastUpdateID) <= lastUpdateIDAppliedToClient) {
	Log.info('[OnyxUpdateManager] Update received was older than or the same as current state, returning without applying the updates other than successData and failureData');

from <= lastUpdateIDAppliedToClient to < lastUpdateIDAppliedToClient

[melvin-bot]

@johncschuster, @youssef-lr, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

@tsa321 in the existing code, do you know why an onyx update is applied even if updateID is same? Because I'm concered about any regression that might arise

[tsa321]

@rushatgabhane Since the Onyx update for HTTPS occurs within applyHTTPSOnyxUpdates and considering the WRITE API operates sequentially, I believe changing the comparison from <= to < will not cause any regression.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@johncschuster @youssef-lr @rushatgabhane this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@johncschuster, @youssef-lr, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

@rushatgabhane / @youssef-lr do you believe this is still an issue? I noticed @mvtglobally was unable to reproduce the behavior here. How about we retest this one more time, and if it doesn't persist, we close it?

[johncschuster]

Waiting on a retest. I'll ping the QA room for that.

Asked here

[mvtglobally]

Error page appears when navigate to #exfy-roadmap link while #new-expensify-feedback is open

1721032969224.Screen_Recording_20240715_114222_Chrome.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

Getting a sense check on the priority of this issue here

[melvin-bot]

@johncschuster, @youssef-lr, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

We're going to close this for now.