[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - First menu item in the composer is highlighted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Tap +.

Expected Result:

The menu item will not be highlighted by default.

Actual Result:

The first menu item is highlighted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6511959_1718284380063.composer.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[luacmartins]

Seems like a regression from focus trap #39520

[amyevans]

Pinged in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1718285290170059

[jnowakow]

I'm from Software Mansion and I'll work on this issue.

[ishpaul777]

Proposal

Problem

First menu item in the composer option is highlighted by default

Root Cause

By default, when a focus trap is activated the first element in the focus trap's tab order will receive focus. i.e when popover becomes visible it focuses the first element.

Solution

we can pass initialFocus: false, in FocusTrap here:

App/src/components/FocusTrap/FocusTrapForModal/index.web.tsx

Lines 11 to 13 in 06cde0a

	trapStack: sharedTrapStack,
	allowOutsideClick: true,
	fallbackFocus: document.body,

or create a prop for FocusTrapForModal and pass initialFocus=false if there's any case where we want the first option to highlighted

[luacmartins]

I'm gonna demote this since it doesn't break any functionality.

[jnowakow]

PR is ready

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[amyevans]

Looks like the PR with a fix was cherry-picked and @mountiny requested a retest here

[amyevans]

Confirmed this is fixed on staging, closing!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disable initial focus in modals #43743

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @jnowakow does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans] The PR that introduced the bug has been identified. Link to the PR:
• [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jnowakow] Determine if we should create a regression test for this bug.
• [@jnowakow] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

C+ payment is pending for the PR review #43743. @amyevans Could you please assign me and post the summary?

[luacmartins]

@muttmuure all yours to handle payment

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disable initial focus in modals #43743

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39520/files#r1659882525
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Open modal (click green plus button in LHP)
2. Verify that first element is not highlighted initially

---

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories
3. Select all the categories via checkbox
4. Click Select
5. Unselect all the categories
6. Select all the categories
7. Click Select
8. The Categories header will not jump when clicking Select

Do you agree 👍 or 👎 ?

[parasharrajat]

@muttmuure Could you please post the payment summary? Thank you.

[parasharrajat]

Payment requested

[mallenexpensify]

Contributor+: @parasharrajat due $250 via NewDot

TestRail

• https://github.com/Expensify/Expensify/issues/413146

[JmillsExpensify]

$250 approved for @parasharrajat