Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chat - cursor isn't moved to the end of the pasted text while context menu is open #43717

Closed
2 of 6 tasks
lanitochka17 opened this issue Jun 13, 2024 · 22 comments
Closed
2 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Right click on any message
  4. Click Copy to clipboard
  5. Right click on any message to open context menu
  6. Paste the content via CMD+V while the context menu is open

Expected Result:

Cursor is moved to the end of the pasted text.

Actual Result:
Cursor isn't moved to the end of the pasted text.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512205_1718297719132.20240614_005446.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010f78034d91b41a47
  • Upwork Job ID: 1801618050114782266
  • Last Price Increase: 2024-06-21
Issue OwnerCurrent Issue Owner: @ishpaul777
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@carlosmiceli carlosmiceli removed the DeployBlocker Indicates it should block deploying the API label Jun 13, 2024
@carlosmiceli
Copy link
Contributor

I think this is the PR that we need to fix/revert: https://github.com/Expensify/App/pull/39520/files cc @jnowakow @adamgrzybowski @fedirjh @roryabraham anyone knows what the issue may be and can fix it? There's a lot of code in that PR so ideally someone with more context can take this.

@carlosmiceli
Copy link
Contributor

Ok, will jump in.

@carlosmiceli
Copy link
Contributor

Haven't been able to figure this one out yet (very unfamiliar with these components and logic) and I have to leave. @jnowakow @adamgrzybowski @fedirjh @roryabraham please jump in if you see this and it's still blocking, thank you! 🙏

@jnowakow
Copy link
Contributor

jnowakow commented Jun 14, 2024

@lanitochka17 it seems that this PR partially solves the problem. There's a problem that the cursor doesn't move to the end of the copied text but it may be problem with Composer.

opened-menu.mov
copy-and-paste.mov

I don't know if this is a big problem. I checked all messengers that I had access to and none of them is allowing to paste text while context menu is open. Here is example from slack:

slack-example.mov

@carlosmiceli
Copy link
Contributor

@jnowakow Thank you! The thing is that in production it is possible to paste while context menu is open, so there should be something else that must be changed... Did you test it in main prior to your PR?

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010f78034d91b41a47

@melvin-bot melvin-bot bot changed the title Chat - Unable to paste content via CMD+V while context menu is open [$250] Chat - Unable to paste content via CMD+V while context menu is open Jun 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@ishpaul777
Copy link
Contributor

it doesn't look like this is solved by #43743 even partially 🤔

@jnowakow Can you please confirm again ?

@carlosmiceli
Copy link
Contributor

@mountiny @ishpaul777 @jnowakow Removing deploy blocker because it's such an edge case, but will keep it as a daily bug until it's solved. Sounds good?

@carlosmiceli carlosmiceli removed the Hourly KSv2 label Jun 14, 2024
@jnowakow
Copy link
Contributor

@ishpaul777 when you open context menu and doesn't click anything in it you can paste:

pasting.mov

But the cursor isn't moved to the end of the line so it doesn't look good.

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@ishpaul777
Copy link
Contributor

Thanks for confirming @jnowakow.


@carlosmiceli Can you please help change the the issue title, expected result and actual result in issue OP.

Title:
Chat - cursor isn't moved to the end of the pasted text while context menu is open

Expected Result:
cursor is moved to the end of the pasted text.

Actual Result:
cursor isn't moved to the end of the pasted text.

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@BartoszGrajdek
Copy link
Contributor

I believe the cursor positioning could be related to the same root cause as this one: #42216

@carlosmiceli carlosmiceli changed the title [$250] Chat - Unable to paste content via CMD+V while context menu is open [$250] Chat - cursor isn't moved to the end of the pasted text while context menu is open Jun 19, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

@carlosmiceli, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jun 20, 2024
@ishpaul777
Copy link
Contributor

Waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ishpaul777
Copy link
Contributor

Issue is no longer producable.

Screen.Recording.2024-06-25.at.11.46.12.PM.mov

@carlosmiceli
Copy link
Contributor

@ishpaul777 Gotcha, is it ok to go ahead and close it then or is there something else that should be done in terms of contributor compensation?

@ishpaul777
Copy link
Contributor

Its ok to close, no contributor was hired and there was not much work as c+ for me. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants