[HOLD] [Help Wanted for completing] [$250] LHN - System message remains on LHN when create new room via announce room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a256@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Create Workspace
2. Go to #announce room
3. Send a message "#room-1"
4. Verify that system message "Heads up, room-1 doesn't exist yet. Do you want to create it ?" appears
5. Click "Yes"
6. Verify that system message disappears from chat history
7. Take a look at #announce room in LHN

Expected Result:

System message should be dismissed

Actual Result:

System message "Heads up, room-1 doesn't exist yet. Do you want to create it ?" remains on LHN when create new room via announce room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512441_1718312003111.Recording__3211.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150a19511c968b1de
• Upwork Job ID: 1803219974130567450
• Last Price Increase: 2024-06-26
• Automatic offers:
• ishpaul777 | Contributor | 102911885
• dominictb | Contributor | 102941077

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - System message remains on LHN when create new room via announce room

What is the root cause of that problem?

The root cause of the problem is that the report lastMessageText is not cleared once the actionable whisper is acted upon.

App/src/libs/SidebarUtils.ts

Line 341 in 2e85794

const lastMessageTextFromReport = OptionsListUtils.getLastMessageTextForReport(report, lastActorDetails, policy);

Therefore, the result.alternateText will be the lastMessageText based on the following last else statement line in the SidebarUtils file.

App/src/libs/SidebarUtils.ts

Lines 387 to 392 in 2e85794

	} else {
	result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : ReportActionsUtils.getLastVisibleMessage(report.reportID, {}, lastAction)?.lastMessageText;
	if (!result.alternateText) {
	result.alternateText = Localize.translate(preferredLocale, 'report.noActivityYet');
	}
	}

What changes do you think we should make in order to solve the problem?

We need the clear the lastMessageText for the report from the onyx's optimisticData in the resolveActionableReportMentionWhisper function.

....
{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${reportId}`,
    value: {lastMessageText: ''},
},
...

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Confirmed reproducible. Doesn't update on a refresh either.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150a19511c968b1de

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message "Heads up, room-1 doesn't exist yet. Do you want to create it ?" remains on LHN when create new room via announce room

What is the root cause of that problem?

When resolving the report mention whisper in

App/src/libs/actions/Report.ts

Line 3629 in 6b2817b

function resolveActionableReportMentionWhisper(

, the report mention whisper will disappear.

But we didn't restore the last message text of the report back to what it was before the whisper, like we did for when we delete the report comment (whispering disappearing so it's same as being deleted) https://github.com/Expensify/App/blob/main/src/libs/actions/Report.ts#L1339-L1357

What changes do you think we should make in order to solve the problem?

When resolving the report mention whisper, optimistically restore the last message text of the report back to the last message text to that of the latest visible message, like we did when deleting report comment

For testing, in

App/src/libs/actions/Report.ts

Line 3636 in 6b2817b

}

, add

let optimisticReport: Partial<Report> = {
      lastMessageTranslationKey: '',
      lastMessageText: '',
      lastVisibleActionCreated: '',
  };
  const optimisticReportActions: OnyxCollection<OptimisticAddCommentReportAction> = {};
  optimisticReportActions[reportAction.reportActionID] = {
      originalMessage: {
          resolution,
      },
  };
  const {lastMessageText = '', lastMessageTranslationKey = ''} = ReportUtils.getLastVisibleMessage(reportId, optimisticReportActions as ReportActions);
  
  if (lastMessageText || lastMessageTranslationKey) {
      const lastVisibleAction = ReportActionsUtils.getLastVisibleAction(reportId, optimisticReportActions as ReportActions);
      const lastVisibleActionCreated = lastVisibleAction?.created;
      const lastActorAccountID = lastVisibleAction?.actorAccountID;
      optimisticReport = {
          lastMessageTranslationKey,
          lastMessageText,
          lastVisibleActionCreated,
          lastActorAccountID,
      };
  }

And in here, add

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${reportId}`,
    value: optimisticReport,
},

In PR phase we can polish this.

We need to do the same fix in the back-end because when the user logs in and logs out, it will still show the Whisper as the last message. The data is returned from the back-end (lastMessageText, lastMessageTranslationKey, ...).

What alternative solutions did you explore? (Optional)

Seems that when clicking Yes in the Whisper in offline mode, we don't create the room optimistically. If optimistic creation of rooms is needed, a new ticket can be created to handle it

[getusha]

@ishpaul777 will be taking over

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[ishpaul777]

@strepanier03 Can you please assign me here, i missed it since this doesn't show up on my K2, i'll review proposals today

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[ishpaul777]

@dominictb your proposal sounds good just one question, if we logout and login again Does the last message still shows whisper message?

[Tony-MK]

@ishpaul777, Sorry to disturb you.

I mentioned this slack thread some proposals are not much different from the rest.

According, to the contributing guide, when posting a proposal, the difference has to meaningful to avoid changing the words of the previous proposal which most of the points has been stated.

Therefore, can you consider this?

Nonetheless, I respect your decision.

Thanks.

[dominictb]

@dominictb your proposal sounds good just one question, if we logout and login again Does the last message still shows whisper message?

@ishpaul777 It will still show the whisper message, so we need the same fix in the back-end, I've updated my proposal to mention the back-end fix.

@Tony-MK I don't think our solutions have any similarity, the suggested fixes are different, the outcomes are different.

But @ishpaul777 will decide.

[melvin-bot]

@strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ishpaul777]

Hello @Tony-MK, In this case @dominictb solution was most complete and correct, we can not simply set lastMessageText to be empty string we'd have to change it to lastMessageText that is visible to user. The difference was a major one not minor.

[ishpaul777]

Not overdue on me, Unassigning for now, feel free to assign if this needs C+ service at any point of time

[dominictb]

@strepanier03 Can you add HOLD to the title to indicate we're holding BE work?

[mvtglobally]

issue is still repro

1728834244550.system_message_in_lhn.mp4

[strepanier03]

This is set internal and I tied it to quality.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Julesssss]

Not overdue, awaiting further retesting