[Payment due now][$250] Send Invoice - Workspace Display Name Not Shown in Invoice Preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in with a new Gmail account
2. Create a workspace:

• Navigate to Account Settings > Workspace > Create Workspace

3. Click on the Floating Action Button (FAB) and select "Send Invoice."
4. Add an amount
5. Select a user

Expected Result:

The First workspace display name should be shown in the invoice preview

Actual Result:

The workspace display name is not shown in the invoice preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512926_1718355206052.Screen_Recording_2024-06-14_at_1.37.15_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01097ae7f88895b39c
• Upwork Job ID: 1813230329996618139
• Last Price Increase: 2024-08-08
• Automatic offers:
• brunovjk | Reviewer | 103164810

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[carlosmiceli]

I'm not able to reproduce this in either staging or production. Asking someone else to try as well.

[Julesssss]

Also can't reproduce

[lanitochka17]

Issue still reproducible on the latest build 9.0.7-4
Only step 5 you need to enter an unknown user

Recording.2135.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01097ae7f88895b39c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace display name is not shown in the invoice preview

What is the root cause of that problem?

At

App/src/libs/actions/Policy/Policy.ts

Line 188 in 303c398

const primaryPolicy: Policy | null | undefined = allPolicies?.[activePolicyID ?? '-1'];

, it's retrieving the policy incorrectly, missing policy_ prefix, so it's unable to find the policy, so the placeholder "Workspace" text and icon is shown.

What changes do you think we should make in order to solve the problem?

Change

App/src/libs/actions/Policy/Policy.ts

Line 188 in 303c398

const primaryPolicy: Policy | null | undefined = allPolicies?.[activePolicyID ?? '-1'];

to

const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];

What alternative solutions did you explore? (Optional)

[brunovjk]

I also couldn't reproduce it (2024-07-16 / v9.0.7-4), did I do something wrong @lanitochka17?

Screen.Recording.2024-07-16.at.16.59.15.mov

@daledah did you do anything different to reproduce?

Thank you.

[daledah]

@brunovjk I can reproduce it.

Screen.Recording.2024-07-17.at.15.04.35.mov

[brunovjk]

Strange, I still can't reproduce it consistently, but it's missing policy_ prefix anyway. We can go with @daledah's proposal

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @carlosmiceli is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@brunovjk this PR is ready for review.

[brunovjk]

PR has been in production for 6 days, I thought about filling out the BZ Checklist, but automation is not triggered here. @carlosmiceli, could you help us out? Thank you.

[carlosmiceli]

@brunovjk sure! do you mean to add the BZ label?

[brunovjk]

@brunovjk sure! do you mean to add the BZ label?

Yes, I guess hehehe its missing a Bz member here, right?

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[brunovjk]

The PR has been in production for over a week, and I don't see any regressions. What are the next steps to process payment and close this issue? Thank you. @carlosmiceli @VictoriaExpensify

[carlosmiceli]

I'll bring in @mallenexpensify to the conversation, my go-to pro for these kind of issues...

[mallenexpensify]

Apologies @brunovjk, automation didn't work, updated labels, owner and title, @VictoriaExpensify please pay. Thx

[VictoriaExpensify]

Payment Summary:

Contributor: @brunovjk paid $250 via Upwork
Upwork Job

@daledah - Please apply to the Upwork job and let me know once you have so that I can pay you

So sorry for the delay @brunovjk

[brunovjk]

No problem at all, I thank you all :D

[VictoriaExpensify]

Hey @daledah - just a friendly bump

@daledah - Please apply to the Upwork job and let me know once you have so that I can pay you

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[VictoriaExpensify]

Hey @daledah can you please accept the offer in Upwork? https://www.upwork.com/nx/wm/offer/103486400

[daledah]

Hey @VictoriaExpensify I accepted the offer, sorry for getting here late.

[VictoriaExpensify]

Payment Summary:

Contributor: @brunovjk paid $250 via Upwork
Contributor+: @daledah paid $250 via Upwork
Upwork Job