[hold for payment 2024-07-30] [$250] Chat - Incorrect format is copied to clipboard after copying an edited header with bold markdown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Inside the compose box paste a header with bold markdown and post it: (e.g. # header)
3. Edit the posted comment and append some letters after a space. (e.g # header aa)
4. Triple click on the edited comment on step 2
5. Paste it inside the compose box

Expected Result:

The correct format gets pasted

Actual Result:

The header markdown is pasted on the first line and the rest of the text is pasted on a new line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6517371_1718723531842.bandicam_2024-06-18_16-23-17-279.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c865bc9dffbb5438
• Upwork Job ID: 1806067556929314722
• Last Price Increase: 2024-07-03

Issue Owner

Current Issue Owner: @hayata-suenaga

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[garrettmknight]

Adding to live markdown per this

[melvin-bot]

@garrettmknight Huh... This is 4 days overdue. Who can take care of this?

[garrettmknight]

Waiting for SWM to work on this one.

[BartoszGrajdek]

Hi, I’m Bartosz from SWM react-native-live-markdown team. 😄

I believe this issue is something that could be handled by external contributors, especially considering that it's probably going to require changes just in E/App. WDYT @garrettmknight ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c865bc9dffbb5438

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[Amoralchik]

Hi there, I can't reproduce it on my latest version. (050641a: Update version to 9.0.2-3)

Still Reproduced

I tried to fix this issue and found that the problem lies in how we are converting the text entered by the user into the input. When the user copies our text, it includes HTML markup unlike what you can copy here. As a result, when this markup gets into htmlString.split (here) it adds \n to the end of the line.

I don't know where we should try to fix this, on the input or rendering sides.

That is not last update, I am still working on it

# *Header* s

[Amoralchik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are adding \n after # in the input when header includes additional tags like _Text_ or *Text* is present in the text.

What is the root cause of that problem?

We add \n at the end of the line in replaceBlockElementWithNewLine: here

What changes do you think we should make in order to solve the problem?

I got stable and successful results changed the first "if" statement conditions to:

if (text.match(/[\n|>][>]?[\s]?$/) || index === splitText.length - 1 || text === "# ") {
  joinedText += text;
} 

This works because if a \n follows the #, we will add it regardless. Therefore, I added a check to prevent adding \n after the #.

2024-06-28.13-15-20.mp4

Testing string:

# _Text_ # *Real Header*
# 
*Text*
*Header* s *another* _emphasis_ **AAAA** __AAAA__
_emphasis_ **AAAA** __AAAA__ [example link](https://example.com/)

[garrettmknight]

@rushatgabhane can you give this one a look when you get a chance?

[rushatgabhane]

@Amoralchik's proposal looks good #43931 (comment)

we have unit tests on the library so it should be good 👍

🎀👀🎀

[Amoralchik]

I Created Pull Request to update expensify-common to version 2.0.42. This version includes the following fix: Expensify/expensify-common#744

[Amoralchik]

Hi there, The changes made here are now available on staging and ready for testing, by this bump expensify-common

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

@joekaufmanexpensify just need you to watch this one while I'm out - I'll pick back up when I'm back if it's still going. Thanks!

[joekaufmanexpensify]

Sounds good! Moving back to weekly as I see PR is in review.

[rushatgabhane]

Hi, the changes are in production #45556 (comment)

[Amoralchik]

Hi, @joekaufmanexpensify The PR in the App has been closed as the expensify-common update has been completed here: #45556 (comment). We can either proceed to testing or close it with full payment per the example here: #44835 (comment).

As mentioned in #44835 (comment) :

#45556 updated the version without following a proper process for issues tracking, and this wasn't the only issue affected. See, for example: #37357 (comment) and #44032 (comment.

Original PR to Expensify-common: Expensify/expensify-common#744

[joekaufmanexpensify]

Got it. Just to make sure my understanding is correct:

• fix: correct newline insertion logic in text processing expensify-common#744 was the PR that fixed the actual bug here.
• Because of the nature of the bug, the fix was brought to production via Bump expensify-common and react-native-live-markdown #45556 (comment) , which bumped the expensify-common version (alongside some other fixes).

Is that right? If so, payment would be due 7 days after the fix went to production, which would be 2024-07-30.

[joekaufmanexpensify]

Awesome. TY! So payment is due tomorrow in that case. We need to pay:

• @Amoralchik - $250 for PR via Upwork.
• @rushatgabhane - $250 for C+ via NewDot.

[joekaufmanexpensify]

@Amoralchik offer sent for $250!

[Amoralchik]

@joekaufmanexpensify accepted

[JmillsExpensify]

$250 approved for @rushatgabhane

[joekaufmanexpensify]

@Amoralchik $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed

[joekaufmanexpensify]

All set, thanks everyone!