[HOLD for payment 2024-08-14] [$250] Feature Request: When uploading, automatically reduce the size of receipt image if greater than 24mb

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718830152208309

Problem:

Unable to upload an image taken from the camera because it’s larger than 24MB

Solution:

Option to reduce the size on device before uploading

When uploading, automatically reduce the size of receipt image if greater than 24mb
This would mean there would be no change in the UI. The user likely wouldn't even know we did it—but their receipt image would be uploaded smoothly with no issues.

Note

I think this would only apply to receipt image uploads—NOT images uploaded as attachments in chats

Context/Examples/Screenshots/Notes:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b098d2eb27081851
• Upwork Job ID: 1805353003843890323
• Last Price Increase: 2024-07-15
• Automatic offers:
• shubham1206agra | Reviewer | 103127270
• nkdengineer | Contributor | 103127271

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[dannymcclain]

Is this a suggestion to implement a feature where our app reduces the file size of a local image before uploading? 🤔

Either way, I don't think we should do this. File size limits are SUPER common amongst all the apps I use daily, and I've never once seen any of them try to reduce a file's size for me (also, 24mb is a pretty generous size limit). I think we should leave this responsibility on the user personally. cc @Expensify/design for thoughts.

[AndrewGable]

Just for reference- This is step backwards from what OldApp does. I can upload a picture from my camera no problem on OldApp, I have to resize it myself on NewDot.

I thought as a user this is a UX oddity.

[dannymcclain]

@AndrewGable are the normal photos your phone takes more than 24mb? I only ask because that seems reaaaaally big. Most of the photos on my phone (that I've taken) are around 1–3mb.

[AndrewGable]

Yes, new iPhones take really big pictures 😄 Looks like this receipt was ~30MB

[shawnborton]

How does OldDot handle this? Does it automatically resize the photo?

[AndrewGable]

Yes, it will allow the user to upload this receipt and OldApp will resize it for the user to allow upload.

[dannymcclain]

Yes, new iPhones take really big pictures 😄 Looks like this receipt was ~30MB

Oh I see, it's because you're shooting in Raw. But anyhoo! That's neither here nor there I suppose.

How does OldDot handle this? Does it automatically resize the photo?

Yes, it will allow the user to upload this receipt and OldApp will resize it for the user to allow upload.

Thinking about it more, Figma does do something similar if you try to drop in a super mega image: it resizes it in the background, adds the resized image, and gives you a little message that tells you Figma resized the image.

I think I'd be open to an approach like that where we just do it behind the scenes automatically (and maybe provide some indication that we've done it?) but I'd like to avoid this becoming like a whole user-flow centered around resizing an image before upload. That's what I though was originally being proposed, which is why I was not into it at first.

[AndrewGable]

I'd like to avoid this becoming like a whole user-flow centered around resizing an image before upload

Agree!

I just think we should support cases that we did in the past, uploading a receipt from my phone's camera is one of those cases.

[dannymcclain]

Nice, that sounds good to me. Thanks for talking it out!

[dubielzyk-expensify]

Yeah. I actually think resizing the image automatically would be super neat cause just a warning is a blocking action. This isn't one of those scenarios where they'd want fine controls on image quality etc, they just wanna upload a receipt.

I also don't like the idea of having the user having to resize or do it themselves through a UI, so I'm all for automatically doing this.

[dannymcclain]

100% agree Jon!

[dannymcclain]

So based on this conversation, @Expensify/design @AndrewGable would you all be comfortable updating this feature request to:

Feature Request: when uploading, automatically reduce the size of receipt image if greater than 24mb

This would mean there would be no change in the UI. The user likely wouldn't even know we did it—but their receipt image would be uploaded smoothly with no issues.

Note

I think this would only apply to receipt image uploads—NOT images uploaded as attachments in chats

[AndrewGable]

Yes - That sounds great!

[OfstadC]

Thanks team! 😃 - Added to Wave Collect and posted in Slack

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b098d2eb27081851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

@dannymcclain, @OfstadC, @luacmartins, @shubham1206agra, @nkdengineer Still overdue 6 days?! Let's take care of this!

[nkdengineer]

I'm investigating the PR.

[shubham1206agra]

@nkdengineer Did something blocking you?

[nkdengineer]

@shubham1206agra we have a open PR here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• When uploading, automatically reduce the size of receipt image #45448

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[OfstadC]

Hey team! I had to send you new offers in Upwork. Please accept your relevant offer below so I can issue payment. Thank you 😃

@shubham1206agra Offer
@nkdengineer Offer

[OfstadC]

Payment Summary

@shubham1206agra paid $250 via Upwork
@nkdengineer paid $250 via Upwork

[OfstadC]

Still pending - @nkdengineer please add a note here once the new offer is accepted so I don't miss it 😃

[nkdengineer]

@OfstadC Thanks 🙇 I have accepted the offer

[OfstadC]

Updated payment summary.

This is just waiting on [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

@shubham1206agra can we get an update by EOD? Thanks!

[shubham1206agra]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

1. Click on FAB > Submit Expense.
2. Try to upload an image of more than 24MB, and it uploads successfully.
3. Complete the flow and verify that no error occurs.

• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.- https://github.com/Expensify/Expensify/issues/421519