-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU - Uploading a receipt with >24MB freezes the app for a while #46882
Comments
Triggered auto assignment to @dangrous ( |
Triggered auto assignment to @twisterdotcom ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I agree this is an issue, but does it need to block the deploy or be hourly? @dangrous what do you think? This isn't a common flow, so I think we could make it just a I know @kidroca recently worked on uploading attachments, but not receipts. Not sure what else could have caused this if it was working well before. |
I thiiiink I agree that this is not a blocker - I believe before the latest deploy you just couldn't upload images greater than 24mb, so this is better than that. However, we should probably have @luacmartins @nkdengineer @shubham1206agra take a look since it's the new functionality they introduced. I'm going to demote this, but keep as daily. |
@nkdengineer @shubham1206agra could you please take a look? |
@luacmartins The reason is the resize function takes a long time with the large image. Then I don't think it's a bug. If we want to improve this case, we can display a loading while the image is uploading. What do you think? |
Agreed! Let's add a loading indicator while things are processing. |
@shubham1206agra The PR is here. cc @luacmartins Please help look at the screenshot and let me know your thoughts. |
I think this went to prod 8/12 but the automation didn't fire. If everything looks good, we can work to close out on 8/19. Will we need payment for this? or is it regression/followup from #44084 |
@dangrous No payment required here |
Yes, no payment is required here. It's an improvement from #44084 |
Awesome! closing out then. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating #45448
Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): nathanmulugetatesting+881@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
The app quickly closes the RHP and shows navigates to the expense details page (which is the behavior seen for smaller file sizes), or the app should show a loading spinner
Actual Result:
The app freezes for a while when reducing the file size and clicking on anything is not functional
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6563182_1722936352565.bandicam_2024-08-06_12-21-16-010.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: