[HOLD for payment 2024-07-24] [$250] Accounting - Workspace admins aren't lised as a "Preferred exporter"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4653117&group_by=cases:section_id&group_id=309134&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with an expensifail account
3. Create a workspace
4. Enable Accounting
5. Connect to Xero
6. Add an expensifail member as an admin
7. Navigate to Workspace settings - Accounting - Export - Preferred exporter
   repro only if i add admin after i connect to Xero. Not repro when i manually sync it

Expected Result:

Workspace admins should be listed

Actual Result:

Workspace admins aren't lised as a "Preferred exporter"
Reproducible only if add admin after connected to Xero. Not repro when manually sync it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519648_1718905209575.bandicam_2024-06-20_19-34-39-083.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b398eb305ddcbb3e
• Upwork Job ID: 1805402957868224386
• Last Price Increase: 2024-07-02

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b398eb305ddcbb3e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[greg-schroeder]

Sending through for proposals

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace admins aren't lised as a "Preferred exporter"
Reproducible only if add admin after connected to Xero. Not repro when manually sync it

What is the root cause of that problem?

When a user is updated role to Admin, the entry for that user in the policy employeeList doesn't contain the email

App/src/libs/actions/Policy/Member.ts

Line 386 in d7d7739

member[current.email] = {role: current?.role, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE};

In Xero exporter check

App/src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx

Line 45 in d7d7739

if (!exporter.email) {

, we filter out employee without emails

-> The issue happens

What changes do you think we should make in order to solve the problem?

Add email in employeeList entry when changing member role, adding member, ...

Or update getAdminEmployees such that it will use the key of the employeeList as email (because employeeList was keyed by emails), if email doesn't exist in the entry.

We could need to add logic to 'add @expensify.sms` to email if it's phone number, in those places.

The same solution could apply to other integrations, if the issue exists there.

What alternative solutions did you explore? (Optional)

None

[greg-schroeder]

Bump @alitoshmatov for proposal review!

[melvin-bot]

@greg-schroeder, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[allroundexperts]

Taking over. I'll review the proposals today.

[shubham1206agra]

@allroundexperts Please fix the same for other integrations too.

[daledah]

@allroundexperts this PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: workspace admin aren't listed in 'Preferred exporter' #45059

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jasperhuangg] The PR that introduced the bug has been identified. Link to the PR: Much of this is new functionality so there aren't really PRs that introduced a particular regression here.
• [@jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@daledah] Determine if we should create a regression test for this bug.
• [@daledah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Payment summary:

Contributor: @daledah - $250 - Offer sent via Upwork
C+: @allroundexperts - $250 - You can make a manual request via ND

[greg-schroeder]

@daledah can you apply to the upwork job or link your upwork profile here so I can send you an offer/pay you?

https://www.upwork.com/jobs/~01b398eb305ddcbb3e

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805402957868224386/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

@daledah it says your Upwork profile is no longer available. so you're going to create a valid upwork account and apply to this job in order for me to pay you.

[greg-schroeder]

bump @daledah

[daledah]

@daledah it says your Upwork profile is no longer available

@greg-schroeder All good now! Please help send an offer to my profile https://www.upwork.com/freelancers/~0138d999529f34d33f

[greg-schroeder]

Sent @daledah

[daledah]

@greg-schroeder I accepted the offer, thx!

[JmillsExpensify]

$250 approved for @allroundexperts based on this comment.