[HOLD for payment 2024-07-17] [$250] Troubleshoot - Troubleshoot modal opened from shortcut is missing Testing preferences

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.0.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause -Internal Team

Issue found when executing PR #43543

Action Performed:

1. Go to staging.new.expensify.com
2. Press CMD + D

Expected Result:

Troubleshoot modal opened from shortcut will be complete

Actual Result:

Troubleshoot modal opened from shortcut is missing Testing preferences

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6520668_1718987164941.20240622_002210.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a41f20c0677b7543
• Upwork Job ID: 1805670065479684749
• Last Price Increase: 2024-06-25
• Automatic offers:
• allgandalf | Reviewer | 102915241
• aeioual | Contributor | 102915244

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot modal opened from shortcut is missing Testing preferences

What is the root cause of that problem?

The Testing preference on troubleshoot modal is only displayed if the environment is Development

App/src/components/TestToolsModal.tsx

Line 47 in b021195

{isDevelopment && <TestToolMenu />}

What changes do you think we should make in order to solve the problem?

Make the Testing preference on troubleshoot displayed if the environment is not Production, so it will be displayed on Development and Staging environment

What alternative solutions did you explore? (Optional)

Create a reusable component to display a list of troubleshooting configurations. This component will ensure that both the Troubleshoot modal and the Troubleshoot page consistently display the same configurations. It will also simplify the process of adding or modifying configurations in the future if needed.

Result:
https://github.com/Expensify/App/assets/73281575/e07b738a-ac78-4f09-98d1-e8e85bc28e2a

[aeioual]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot modal opened from shortcut is missing Testing preferences

What is the root cause of that problem?

We do not allow the testtoolMenu on staging, hence we do not see the options.

App/src/components/TestToolsModal.tsx

Line 47 in b021195

{isDevelopment && <TestToolMenu />}

I also found one more bug, the order of options is not right, we should first display the Logs options and then the TestToolMenu (We do the same with the troubleshoot page too):

As you can see the first option is of client side logging then the testing preference, we should maintain this order in shortcut too.

What changes do you think we should make in order to solve the problem?

• Change the check to !isProduction from the following hook>
  

  App/src/hooks/useEnvironment.ts

  Line 16 in 425804a

  isProduction: environment === CONST.ENVIRONMENT.PRODUCTION,

• Then we should move the code block after the following line to match the UI with the troubleshoot page:

App/src/components/TestToolsModal.tsx

Lines 66 to 67 in b021195

	</TestToolRow>
	)}

</TestToolRow>
                )}
                {!isProduction && <TestToolMenu />}

What alternative solutions did you explore? (Optional)

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a41f20c0677b7543

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[anmurali]

Trying to figure out where this issue goes and I don't think any of the roadmap projects make sense. It is about testing, and so quality perhaps?

[nyomanjyotisa]

Updating proposal , adding alternative solution

[allgandalf]

thanks for your proposals everyone!

Both contributors have correct RCA.

Lets go with @aeioual's proposal here, that bug that they found out is important here considering the consistency between options.

🎀👀🎀 C+ reviewed

Also want to confirm the @Expensify/design opinion once, the troubleshoot shortcut modal options should be consistent with the troubleshoot page options right?

• Currently on troubleshoot page, we first show:

1. Client side logging
2. Testing preferences

After this PR, we should follow the same order in the troubleshoot shortcut modal right?

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shawnborton]

That sounds correct to me? I'm not too sure but it does seem to make sense that the page and the modal would be consistent.

[muttmuure]

The idea behind the modal was to mirror the "four finger tap" options that you have on mobile - adding more options to the modal would be a new feature, not a bug. #43256

[melvin-bot]

Current assignee @anmurali is eligible for the NewFeature assigner, not assigning anyone new.

[allgandalf]

Automation Failed ⚠️ , this was deployed to production 2 days ago!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixes: Troubleshoot modal opened from shortcut is missing Testing preferences #44666

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment automatic offer (Reviewer)
• @aeioual requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixes: Troubleshoot modal opened from shortcut is missing Testing preferences #44666

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment automatic offer (Reviewer)
• @aeioual requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allgandalf]

Regression Test Proposal

Note: Can only test on Desktop/MacOS Web:

1. Open App
2. Press CMD + D

Verify that the Troubleshoot modal opens up

Do we agree 👍 or 👎

[allgandalf]

Note

@anmurali , this is already ready for payment, melvin really is acting weird, the actual date for payment was 15th

[allgandalf]

Waiting for payment!

[melvin-bot]

@bondydaa, @anmurali, @allgandalf, @aeioual Whoops! This issue is 2 days overdue. Let's get this updated quick!

[allgandalf]

This issue can be closed, payment has been completed