Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] [External] Disable card reconciliation when auto-sync not enabled #44318

Closed
mountiny opened this issue Jun 24, 2024 · 10 comments
Assignees
Labels
Monthly KSv2 Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

Copy link

melvin-bot bot commented Jun 28, 2024

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

Later phase of implementation

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jun 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

It looks like implementing of this issue should be much easier when Card Reconciliation page PR is merged, so I'll continue to work on it after that.

@mountiny
Copy link
Contributor Author

@VickyStash this should be off hold now

@VickyStash
Copy link
Contributor

Updates:
I have added the Continuous Reconciliation toggle and its logic. There are just a couple of minor updates and PR preparations left.
I'll open it for review tomorrow.

@VickyStash
Copy link
Contributor

The PR has been opened for the review 👀

@DylanDylann
Copy link
Contributor

Reviewing PR

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

This issue has not been updated in over 15 days. @MariaHCD, @VickyStash, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 8, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Aug 8, 2024

we can close this one now I thinks

@mountiny mountiny closed this as completed Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

4 participants