[No QA] Disable card reconciliation when auto-sync not enabled #45452

VickyStash · 2024-07-16T07:03:02Z

Details

Disable card reconciliation when auto-sync not enabled.

Fixed Issues

$ #44318
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open any workspace and enable accounting feature there.
Go to the accounting section.
Update URL to end with accounting/xero/card-reconciliation. For example: https://dev.new.expensify.com:8082/settings/workspaces/YOUR_POLICY_ID/accounting/xero/card-reconciliation
Make sure the Card reconciliation screen looks as expected:

The toggle should be disabled if auto-sync is off.
The should be correct text.
The deep link to the Advanced settings (on auto-sync word) should work correctly.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-16T10:15:08Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2024-07-16T10:17:14Z

@DylanDylann @allgandalf I guess one of you should be a reviewer here

allgandalf · 2024-07-16T10:19:05Z

@DylanDylann , mind reviewing this? it's related to reconciliation which i think you already have context as you reviewed related PR

DylanDylann · 2024-07-16T13:53:34Z

yeah, I will take over this PR. @rayane-djouah Please ignore this PR

src/ONYXKEYS.ts

trjExpensify · 2024-07-16T20:17:21Z

How you getting on with the review? 👀

DylanDylann · 2024-07-17T04:30:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-17.at.11.36.38.mov

Android: mWeb Chrome

Screen.Recording.2024-07-17.at.11.34.42.mov

iOS: Native

Screen.Recording.2024-07-17.at.11.35.55.mov

iOS: mWeb Safari

Screen.Recording.2024-07-17.at.11.34.12.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-17.at.11.31.39.mov

MacOS: Desktop

Screen.Recording.2024-07-17.at.11.35.10.mov

DylanDylann

The change looks good

DylanDylann · 2024-07-17T04:41:22Z

@mountiny I see a bug while testing this PR. The auto-sync automatically enables after we disable the toggle

Screen.Recording.2024-07-17.at.11.39.30.mov

DylanDylann · 2024-07-18T05:06:27Z

cc @MariaHCD Also tag you here because this PR belongs to Expensify card Project

VickyStash · 2024-07-18T07:53:22Z

@mountiny kind bump 🙂

MariaHCD · 2024-07-18T12:43:43Z

The auto-sync automatically enables after we disable the toggle

Not super familiar with that API command but from our backend logs, it looks like we successfully set autoSync as false.

But it seems the Onyx update contains autoSync as true?

trjExpensify · 2024-07-18T18:08:38Z

@mountiny good here to merge?

mountiny

Thanks for the review @DylanDylann and for a quick work @VickyStash

@DylanDylann Can you please raise this bug in #expensify-bugs and ask to add it to wave-collect? it seems to be related to QBO, feel free to tag me and I can tag the revelant people to have a look

AS such its not a blocker for this PR

OSBotify · 2024-07-19T20:13:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-22T13:36:07Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-23T08:03:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-25T03:15:06Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

getusha · 2024-11-20T14:38:58Z

src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

+                            style={styles.mt5}
+                            title={reconciliationConnection?.title}
+                            description={translate('workspace.accounting.reconciliationAccount')}
+                            shouldShowRightIcon


Hey! we missed to add onPress with navigation function for this one. was fixed here #50498

VickyStash added 3 commits July 16, 2024 08:59

Add Card Reconciliation toggle

de102f3

Add navigation to Advanced settings

23add1a

Fix connection name display

2b30f19

VickyStash changed the title ~~[WIP] [No QA] Disable card reconciliation when auto-sync not enabled~~ [No QA] Disable card reconciliation when auto-sync not enabled Jul 16, 2024

VickyStash marked this pull request as ready for review July 16, 2024 10:15

VickyStash requested a review from a team as a code owner July 16, 2024 10:15

melvin-bot bot requested review from rayane-djouah and removed request for a team July 16, 2024 10:15

VickyStash mentioned this pull request Jul 16, 2024

[Workspace Feeds] [External] Disable card reconciliation when auto-sync not enabled #44318

Closed

DylanDylann reviewed Jul 16, 2024

View reviewed changes

src/ONYXKEYS.ts Show resolved Hide resolved

trjExpensify removed the request for review from rayane-djouah July 16, 2024 20:17

trjExpensify mentioned this pull request Jul 16, 2024

[No QA] Create new Edit Card Limit page #45397

Merged

50 tasks

DylanDylann approved these changes Jul 17, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 17, 2024 04:40

VickyStash mentioned this pull request Jul 17, 2024

[No QA] Card reconciliation page #45606

Closed

61 tasks

koko57 mentioned this pull request Jul 17, 2024

[NO-QA]: Add Card reconciliation account setting #44968

Merged

50 tasks

MariaHCD approved these changes Jul 18, 2024

View reviewed changes

mountiny assigned VickyStash Jul 18, 2024

mountiny approved these changes Jul 18, 2024

View reviewed changes

mountiny merged commit f0bd2df into Expensify:main Jul 18, 2024
17 of 21 checks passed

github-actions bot mentioned this pull request Jul 19, 2024

Deploy Checklist: New Expensify 2024-07-19 #45794

Closed

This was referenced Jul 29, 2024

Cannot read property 'enabled' of undefined #46432

Closed

[No QA] Fixes autoSync crash #46433

Merged

[HOLD for payment 2024-08-09] [$125] QBO - App crashes when clicking on Card reconciliation immediately after QBO is connected #46362

Closed

getusha reviewed Nov 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Disable card reconciliation when auto-sync not enabled #45452

[No QA] Disable card reconciliation when auto-sync not enabled #45452

VickyStash commented Jul 16, 2024 •

edited

Loading

melvin-bot bot commented Jul 16, 2024

VickyStash commented Jul 16, 2024

allgandalf commented Jul 16, 2024

DylanDylann commented Jul 16, 2024

trjExpensify commented Jul 16, 2024

DylanDylann commented Jul 17, 2024 •

edited

Loading

DylanDylann left a comment

DylanDylann commented Jul 17, 2024 •

edited

Loading

DylanDylann commented Jul 18, 2024

VickyStash commented Jul 18, 2024

MariaHCD commented Jul 18, 2024

trjExpensify commented Jul 18, 2024

mountiny left a comment

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

getusha Nov 20, 2024

[No QA] Disable card reconciliation when auto-sync not enabled #45452

[No QA] Disable card reconciliation when auto-sync not enabled #45452

Conversation

VickyStash commented Jul 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 16, 2024

VickyStash commented Jul 16, 2024

allgandalf commented Jul 16, 2024

DylanDylann commented Jul 16, 2024

trjExpensify commented Jul 16, 2024

DylanDylann commented Jul 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann left a comment

Choose a reason for hiding this comment

DylanDylann commented Jul 17, 2024 • edited Loading

DylanDylann commented Jul 18, 2024

VickyStash commented Jul 18, 2024

MariaHCD commented Jul 18, 2024

trjExpensify commented Jul 18, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

getusha Nov 20, 2024

Choose a reason for hiding this comment

VickyStash commented Jul 16, 2024 •

edited

Loading

DylanDylann commented Jul 17, 2024 •

edited

Loading

DylanDylann commented Jul 17, 2024 •

edited

Loading