[HOLD for payment 2024-08-09] [$250] Distance - Error is not dismissed after entering valid waypoints

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4671219
Issue reported by: Applause - Internal Team

Action Performed:

1. Disable internet connection
2. Go to FAB > Submit expense
3. Select the Distance option
4. Enter an invalid start location
5. Enter an invalid finish location
6. Submit the expense to a workspace
7. Enable the internet connection
8. Wait for the error on the request to appear
9. Click on the request
10. Click on the address input field and type valid waypoints on the start and finish locations respectively.
11. Save the new addresses

Expected Result:

The error is removed and the map updates to the new addresses and displays correctly in the map thumbnail

Actual Result:

The error persists, the map thumbnail is empty and the new addresses are displayed only when the thumbnail is clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525202_1719405397967.2024-06-26_15_16_58.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138e762430a2e3f57
• Upwork Job ID: 1810948702952984302
• Last Price Increase: 2024-07-24
• Automatic offers:
• dominictb | Contributor | 103283503

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@lanitochka17 cannot reproduce, can you confirm this is still occurring?

[lanitochka17]

Issue is still reproducible

2024-07-05.21.19.57.mp4

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138e762430a2e3f57

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[dylanexpensify]

Moving external!

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error persists, the map thumbnail is empty and the new addresses are displayed only when the thumbnail is clicked

What is the root cause of that problem?

When the distance is invalid, the request failed to be created. In this case we're still allowing users to edit the money request, which will never work because there's no money request in the back-end to edit.

What changes do you think we should make in order to solve the problem?

Update canEditFieldOfMoneyRequest here to early return if the transaction has pendingAction: "add" and there's errors (or errorFields). It means the transaction failed to be created in the back-end so we should disable users from editing. The user can dismiss the transaction error and try again. The transaction is here, we can move on top of the method and use it. Using getLinkedTransaction can also be ok.

canEditMoneyRequest here should also be fixed like that.

If there're fields that are not restricted by canEditFieldOfMoneyRequest or canEditMoneyRequest, we can create an util isRequestCreationFailed with the described logic and use it to make the menu item not interactive, not show right icon, ... Also deeplinks should be checked too, to make sure to show correct not found page/other UX if the field is not editable. We can handle this in PR phase.

There could be small variations in the fix for other types of Expenses (Track, Invoice, ...) we will check and make sure it works for all of them

What alternative solutions did you explore? (Optional)

Out of scope but it looks like the x button to clear the error and the transaction is not working entirely as expected. It's not navigating the user back to the correct chat after clearing the error.

Root cause is in deleteTransaction we're not doing the navigation. To fix we need to update this to something like

const routeToNavigateAfterDeletion = IOU.deleteMoneyRequest(iouTransactionID, parentReportAction, true);
ReportUtils.navigateBackAfterDeleteTransaction(routeToNavigateAfterDeletion);

And this to check !isEmptyObject(transaction?.errors)
It also should be decided in case the distance request is created in an optimistic chat report, whether we need to clear that optimistic chat report. If so, clearAllRelatedReportActionErrors needs to be updated to clear the optimistic chat report too.

[dominictb]

Proposal updated

[melvin-bot]

@Ollyws @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Ollyws]

Will get to this one today.

[dylanexpensify]

Thank you, Olly!

…

On Mon, Jul 15, 2024 at 12:39 PM Olly ***@***.***> wrote: Will get to this one today. — Reply to this email directly, view it on GitHub <#44459 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKVCAAFYLSNL4NCKKU22VDZMOYIVAVCNFSM6AAAAABJ56CZ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGI4TOMJSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Ollyws]

On the latest main I'm getting a loop of GetRoute when coming back online and trying to edit the waypoints, rendering them uneditable. @dominictb Is this occuring for you too?

Screen.Recording.2024-07-15.at.17.47.25.mov

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[neil-marcellini]

Yeah I suppose it is congruent with the other behaviour in the app. Ok let's go with @dominictb's proposal. 🎀👀🎀 C+ reviewed

I agree, great plan! Hiring. For context, we recently fixed cleaning up errored distance expenses on the frontend. Maybe there were some mistakes in there that we could smooth out here too.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent editing money request in case create failure #46376

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment coming up!

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

I don't think we can pin this on any (front-end) PR, it was just never updated on the front-end after the backend error was implemented.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Disable internet connection
2. Go to FAB > Submit expense
3. Select the Distance option
4. Enter an invalid start location
5. Enter an invalid finish location
6. Submit the expense to a workspace
7. Enable the internet connection
8. Wait for the error on the request to appear
9. Click on X icon to clear the error

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[JmillsExpensify]

@dylanexpensify i need a payment summary

[dylanexpensify]

Payment summary:

• Contributor: @dominictb $250
• Contributor+: @Ollyws $250

Please apply/request!

[dylanexpensify]

Done!

[JmillsExpensify]

$250 approved for @Ollyws