[HOLD for payment 2024-08-14] [$250] When a room or report is renamed, the report action shows up using an old centered message style

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.3-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719556190081699

Action Performed:

1. Create a report in old dot and rename the report
2. Login to new dot and see report details
3. Create a room in NewDot and rename the room
4. Observe the centered report action.

Expected Result:

The RENAMED report action (ref) should use the newer system message style whereby the message comes from the user that took the action in grey font.

The format should be something like:

Tom Rhys Jones
renamed this room from #roomname to #newroomname

Given that, we also need to update the copy of the message slightly such that the actor is not included in the copy (i.e "You" in the screenshots) as the message is coming from the person that took the action.

Actual Result:

Renaming reports or rooms uses an old report action style. It looks like a normal chat message and it's centered on the report/chat.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191d8611609765fe7
• Upwork Job ID: 1806689197252632356
• Last Price Increase: 2024-07-05
• Automatic offers:
• abdulrahuman5196 | Reviewer | 103146464
• neonbhai | Contributor | 103146466

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191d8611609765fe7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[shawnborton]

Ah apologies, to clarify, we do not want to use this component, we want to use our standard system message component and get rid of the current component being used.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The RenameAction component uses the center aligned text styles:

App/src/components/ReportActionItem/RenameAction.tsx

Line 28 in 0c8bae5

<Text style={[styles.pv3, styles.ph5, styles.textAlignCenter, styles.textLabelSupporting]}>

What changes do you think we should make in order to solve the problem?

We will use ReportActionItemBasicMessage to render these messages.

i.e, here:

else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
    const originalMessage = ReportActionsUtils.isRenamedAction(action) ? ReportActionsUtils.getOriginalMessage(action) : null;
    const oldName = originalMessage?.oldName ?? '';
    const newName = originalMessage?.newName ?? '';
    const message = translate('newRoomPage.renamedRoomAction', {oldName, newName});
    children = <ReportActionItemBasicMessage message={message} />;
}

Result:

Screen.Recording.2024-06-28.at.8.01.47.PM.mov

[melvin-bot]

@JmillsExpensify, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abdulrahuman5196]

Hi, Will check on this today.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abdulrahuman5196]

@neonbhai 's proposal here #44620 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@JmillsExpensify @abdulrahuman5196 @roryabraham this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify, @abdulrahuman5196, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[BhuvaneshPatil]

@roryabraham @shawnborton Does this also need to be changed?

[shawnborton]

Yes, that should match whatever is shown in the chat. Out of curiosity, why wouldn't it match?

[BhuvaneshPatil]

Yes, that was missed in code changes

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Rename Report Action #45869

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not regression. New implementation

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Create a room and rename the room
2. Verify the rename action message can be seen correctly as per the new UX

[trjExpensify]

#44620 (comment) - was this considered a regression or follow-up?

[neonbhai]

#47342 was a follow-up. LHN message was different from chat before this PR and copy to clipboard functionality for renamed action was altogether missing from ContextMenuActions. The follow up added these to bring renamed action in line with other messages

[abdulrahuman5196]

#44620 (comment) - was this considered a regression or follow-up?

@trjExpensify This was not a regression IMO. Even before this PR the same was present. And the issue was tackled in a different PR unifying the message strings. While in this PR we had updated the UX to match with expected UX while the message strings was not much changed.

For reference - https://expensify.slack.com/archives/C01GTK53T8Q/p1722946998491139, #44620 (comment)

[trjExpensify]

Cool, sounds good. So, @JmillsExpensify payment summary as follows:

• $250 to @abdulrahuman5196 for the C+ review.
• $250 to @neonbhai for the fix.

[JmillsExpensify]

Catching up from OOO. I'll issue payments now.

[JmillsExpensify]

$250 approved for @abdulrahuman5196

[JmillsExpensify]

Contracts paid out. I'm not going to create a regression test since it's a one-time visual change.