Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invoice - Workspace avatar and name are incorrect after paying invoice as a business #44806

Closed
6 tasks done
m-natarajan opened this issue Jul 4, 2024 · 13 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when validating #43036
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • User A and User B have their own workspaces.
  1. Go to staging.new.expensify.com
  2. [User A] Send invoice to User B.
  3. [User B] Go to invoice chat.
  4. [User B] Click on the pay button > Pay as a business > Pay elsewhere.
  5. [User B] After invoice chat avatar is changed, click on the chat header.
  6. [User B] Click on User B's workspace avatar.

Expected Result:

User B's workspace avatar will be displayed with the correct workspace name.

Actual Result:

User B's workspace avatar is displayed as User A's workspace avatar together with User A's workspace name

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532627_1720057227037.20240704_093524.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@Beamanator FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@Beamanator
Copy link
Contributor

cc @cristipaval since you're the "Invoices in NewDot" guy!

@Beamanator
Copy link
Contributor

This looks very related to #43036

@Beamanator
Copy link
Contributor

Marking NAB b/c of @cristipaval 's comment in the PR here. Keeping this open till we determine if it's needed or if we're going to handle this case in the issue linked to that PR

@Beamanator
Copy link
Contributor

Also commented in #vip-billpay here

@cristipaval cristipaval assigned cristipaval and unassigned Beamanator Jul 7, 2024
@VickyStash
Copy link
Contributor

I was able to reproduce this issue, and I'm going to fix it in the upcoming PR related to Pay as business functionality.
cc @cristipaval

@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2024
@JmillsExpensify
Copy link

Ah perfect, we'll keep an eye on that one.

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@cristipaval
Copy link
Contributor

This is held.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2024
@cristipaval
Copy link
Contributor

Actually, I think we can close this one, given that it was reproducible due to a PR that was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants