Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [$250] Android - Report Fields - Cursor position jumps to the beginning of the name field #44868

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 4, 2024 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4.0
Reproducible in staging?: Y
Reproducible in prouring regression testing, add the test name, ID and link from TestRail: N/A
Issue reported bduction?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44275

Action Performed:

  1. Open new expensify app
  2. Create a workspace
  3. Enable report fields feature
  4. Open report fields setting
  5. Tap on add field
  6. Tap on Name and add something and save it
  7. Tap on Name again

Expected Result:

The cursor positions itself at the end of the text

Actual Result:

The cursor jumps to the beginning of the saved text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6533194_1720104132387.Screen_Recording_20240704_173222_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ecace54576044ee5
  • Upwork Job ID: 1808958862801435309
  • Last Price Increase: 2024-07-04
  • Automatic offers:
    • shubham1206agra | Reviewer | 102994077
    • dominictb | Contributor | 103082291
    • abzokhattab | Contributor | 103091472
Issue OwnerCurrent Issue Owner: @garrettmknight
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@tgolen tgolen removed the DeployBlocker Indicates it should block deploying the API label Jul 4, 2024
@marcochavezf
Copy link
Contributor

I don't consider it a deploy blocker, and can be fixed externally

@marcochavezf marcochavezf added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ecace54576044ee5

@melvin-bot melvin-bot bot changed the title Android - Report Fields - Cursor position jumps to the beginning of the name field [$250] Android - Report Fields - Cursor position jumps to the beginning of the name field Jul 4, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2024

I am managing this project so going to take over this issue to make sure it gets fixed. Thanks for helping!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 9, 2024
@rezkiy37
Copy link
Contributor

rezkiy37 commented Jul 9, 2024

I've opened a PR (#45074) for review 🙂

@dominictb
Copy link
Contributor

Hi @mountiny @rezkiy37 Do you think we need to re-use the useAutoFocusInput? This bug will happens if we use the input in modal so we can

  1. Prevent the duplicated code
  2. Prevent the future bug

@rezkiy37
Copy link
Contributor

rezkiy37 commented Jul 10, 2024

Just to clarify: the app does not use useAutoFocusInput for this scenario with the new report field name. It uses TextSelectorModal under the hood and this component handles focusing.

@abzokhattab
Copy link
Contributor

Hello team, I think my solution was employed in the PR. Am I eligible for an offer here?

cc @mountiny

@mountiny
Copy link
Contributor

$50 to @abzokhattab as the issue was labeled as Help Wanted and we have used their solution

Copy link

melvin-bot bot commented Jul 11, 2024

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@garrettmknight
Copy link
Contributor

@dominictb updated offer sent to you for $50

@abzokhattab
Copy link
Contributor

@garrettmknight I believe there may be a mistake in the offer assignment, can you please recheck this comment
Thank you for your consideration!

Copy link

melvin-bot bot commented Jul 12, 2024

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@garrettmknight
Copy link
Contributor

Oops, @abzokhattab you're right. I'll drop the contract to pay $50 when the solution works on prod.

@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 labels Jul 12, 2024
@rushatgabhane
Copy link
Member

PR reviewed and merged

@garrettmknight
Copy link
Contributor

@abzokhattab all paid out!

@garrettmknight garrettmknight added the Awaiting Payment Auto-added when associated PR is deployed to production label Jul 22, 2024
@garrettmknight
Copy link
Contributor

Looks like this made it to prod on Monday. Just tested and it's fixed.

@garrettmknight garrettmknight changed the title [$250] Android - Report Fields - Cursor position jumps to the beginning of the name field [HOLD for payment 2024-07-22] [$250] Android - Report Fields - Cursor position jumps to the beginning of the name field Jul 22, 2024
@garrettmknight
Copy link
Contributor

Payment Summary:

@rezkiy37 @mountiny is there a regression test for this already?

@garrettmknight garrettmknight added Weekly KSv2 and removed Reviewing Has a PR in review Daily KSv2 labels Jul 22, 2024
@garrettmknight
Copy link
Contributor

Dropping to weekly for payment

@shubham1206agra
Copy link
Contributor

Payment at end of project. Please close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Development

No branches or pull requests