[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

lanitochka17 · 2024-07-08T19:10:25Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4704499
Issue reported by: Applause - Internal Team

Action Performed:

Launch app
Open a report
Tap plus icon -- assign task
Enter a title and tap next
Tap confirm task
Open the task created
Tap header - delete option

Expected Result:

Deleted task must not be shown briefly in conversation page

Actual Result:

Deleted task is shown briefly and then disappears from conversation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6536169_1720462778895.screenrecorder-2024-07-08-20-58-12-710_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d0d653c8ad7776ae
Upwork Job ID: 1810491099806319286
Last Price Increase: 2024-07-09
Automatic offers:

alitoshmatov | Reviewer | 103061198
dominictb | Contributor | 103061200

Issue Owner

Current Issue Owner: @alitoshmatov

melvin-bot · 2024-07-08T19:10:35Z

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-07-08T19:10:58Z

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-07-08T19:11:14Z

We think that this bug might be related to #vip-vsp

cretadn22 · 2024-07-08T19:41:13Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

When a task is deleted, we mark the parentReportAction's pendingAction as "UPDATE"

App/src/libs/actions/Task.ts

Line 932 in 9dccffe

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

Here, if pendingAction is not "DELETE," we continue to show the deleted task until we receive the data from the backend

App/src/pages/home/report/ReportActionsList.tsx

Lines 200 to 208 in 4a3ecb3

    
           () => 
        
               sortedReportActions.filter( 
        
                   (reportAction) => 
        
                       (isOffline || 
        
                           ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                           reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                           reportAction.errors) && 
        
                       ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID), 
        
               ),

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/Task.ts

Line 932 in 9dccffe

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

Setting pendingAction to "DELETE" to indicate that a deletion action is pending

What alternative solutions did you explore? (Optional)

VictoriaExpensify · 2024-07-09T01:47:22Z

Issue recreated. Agree this is a bug that belongs in VSP.

melvin-bot · 2024-07-09T01:48:11Z

Job added to Upwork: https://www.upwork.com/jobs/~01d0d653c8ad7776ae

melvin-bot · 2024-07-09T01:48:22Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

dominictb · 2024-07-09T11:01:22Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleted task is shown briefly and then disappears from conversation page

What is the root cause of that problem?

In here:

App/src/libs/actions/Task.ts

Line 932 in e4e7baa

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

we always set the pendingAction to CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE regardless whether the task report should be deleted or not. That leads to when the API is not done, it still display the task action because these two conditions are true:

App/src/pages/home/report/ReportActionsList.tsx

Line 205 in bd19803

reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||

and

App/src/libs/ReportActionsUtils.ts

Line 591 in bd19803

return !isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction);

What changes do you think we should make in order to solve the problem?

We should update:

App/src/libs/actions/Task.ts

Line 932 in e4e7baa

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

to:

        pendingAction: shouldDeleteTaskReport ? CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE : CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

like we did when deleting track expense:

App/src/libs/actions/IOU.ts

Line 1593 in bd19803

    
           pendingAction: shouldShowDeletedRequestMessage ? CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE : CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

or deleting expense:

App/src/libs/actions/IOU.ts

Line 5327 in bd19803

    
           pendingAction: shouldShowDeletedRequestMessage ? CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE : CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What alternative solutions did you explore? (Optional)

kaushiktd · 2024-07-09T12:07:40Z

Please re-state the problem that we are trying to solve in this issue.

Deleted task is shown briefly and then disappears from conversation page

What is the root cause of that problem?

The root cause of this issue is that the pendingAction for a deleted task is always set to CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, regardless of whether the task should be deleted. This results in the task being displayed until the backend confirms the deletion. Specifically, in App/src/libs/actions/Task.ts, the pendingAction is set to UPDATE, which leads to the following filtering conditions in App/src/pages/home/report/ReportActionsList.tsx not excluding the deleted task immediately:

App/src/pages/home/report/ReportActionsList.tsx

Lines 200 to 208 in 4a3ecb3

    
           () => 
        
               sortedReportActions.filter( 
        
                   (reportAction) => 
        
                       (isOffline || 
        
                           ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                           reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                           reportAction.errors) && 
        
                       ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID), 
        
               ),

What changes do you think we should make in order to solve the problem?

const sortedVisibleReportActions = useMemo(
    () =>
        sortedReportActions.filter(
            (reportAction) =>
                (isOffline ||
                    ReportActionsUtils.isDeletedParentAction(reportAction) ||
                    (reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
                     reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE) ||
                    reportAction.errors) &&
                ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),
        ),
    [sortedReportActions, isOffline],
);

reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE: Ensures that tasks with pending DELETE or UPDATE actions are excluded from the visible actions.

video:-

screen-capture.1.online-video-cutter.com.mp4

alitoshmatov · 2024-07-09T19:23:06Z

@cretadn22 Thank you for your proposal, your RCA is correct. However you missed a case where task report is still shown where it has some report actions in it. Your solution makes it disappear in optimistic data and appear again when backend data is received.

alitoshmatov · 2024-07-09T19:25:08Z

@dominictb Thank you for your proposal, your RCA is correct and your are providing a correct solution

alitoshmatov · 2024-07-09T19:26:07Z

@kaushiktd Thank you for your proposal, your RCA seems to focus on wrong area and provided a wrong solution

alitoshmatov · 2024-07-09T19:26:31Z

We can go with @dominictb 's proposal

C+ reviewed 🎀 👀 🎀

melvin-bot · 2024-07-09T19:26:42Z

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

kaushiktd · 2024-07-10T03:36:13Z

@alitoshmatov can you please explain where it go wrong

melvin-bot · 2024-07-10T11:49:30Z

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-07-10T11:49:34Z

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dominictb · 2024-07-11T13:42:27Z

PR #45279 is ready.

melvin-bot · 2024-07-19T19:29:44Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-19T19:29:48Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix Deleted task is shown briefly and then disappears from conversati… #45279

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@dominictb requires payment automatic offer (Contributor)

melvin-bot · 2024-07-19T19:29:49Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

alitoshmatov · 2024-07-26T10:45:55Z

The PR that introduced the bug has been identified. Link to the PR: Update Canceled task flow #24137
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24137/files#r1692881438
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. I think there is no need for test

melvin-bot · 2024-07-29T18:15:23Z

@madmax330, @VictoriaExpensify, @alitoshmatov, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!

VictoriaExpensify · 2024-07-29T22:15:17Z

Link the GH issue for creating/updating the regression test once above steps have been agreed upon: - N/A

VictoriaExpensify · 2024-07-29T22:21:54Z

Contributor: @dominictb paid $250 via Upwork
Contributor+: @alitoshmatov paid $250 via Upwork

Upwork job here!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024

melvin-bot bot assigned VictoriaExpensify Jul 8, 2024

VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 9, 2024

melvin-bot bot changed the title ~~Android - Task - Deleted task is shown briefly and then disappears from conversation page~~ [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page Jul 9, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 9, 2024

VictoriaExpensify added this to [#whatsnext] #vip-vsb Jul 9, 2024

melvin-bot bot assigned alitoshmatov Jul 9, 2024

melvin-bot bot assigned madmax330 Jul 9, 2024

madmax330 assigned dominictb Jul 10, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2024

dominictb mentioned this issue Jul 11, 2024

fix Deleted task is shown briefly and then disappears from conversati… #45279

Merged

50 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jul 11, 2024

melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 19, 2024

melvin-bot bot changed the title ~~[$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page~~ [HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page Jul 19, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2024

alitoshmatov mentioned this issue Jul 26, 2024

Update Canceled task flow #24137

Merged

57 tasks

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 26, 2024

melvin-bot bot added the Overdue label Jul 29, 2024

VictoriaExpensify closed this as completed Jul 29, 2024

melvin-bot bot removed the Overdue label Jul 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

lanitochka17 commented Jul 8, 2024 •

edited by VictoriaExpensify

Loading

melvin-bot bot commented Jul 8, 2024

lanitochka17 commented Jul 8, 2024

lanitochka17 commented Jul 8, 2024

cretadn22 commented Jul 8, 2024

VictoriaExpensify commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

dominictb commented Jul 9, 2024

kaushiktd commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

kaushiktd commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

dominictb commented Jul 11, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

alitoshmatov commented Jul 26, 2024

melvin-bot bot commented Jul 29, 2024

VictoriaExpensify commented Jul 29, 2024

VictoriaExpensify commented Jul 29, 2024

[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

Comments

lanitochka17 commented Jul 8, 2024 • edited by VictoriaExpensify Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jul 8, 2024

lanitochka17 commented Jul 8, 2024

lanitochka17 commented Jul 8, 2024

cretadn22 commented Jul 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

VictoriaExpensify commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

dominictb commented Jul 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kaushiktd commented Jul 9, 2024

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

alitoshmatov commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

kaushiktd commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

dominictb commented Jul 11, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

alitoshmatov commented Jul 26, 2024

melvin-bot bot commented Jul 29, 2024

VictoriaExpensify commented Jul 29, 2024

VictoriaExpensify commented Jul 29, 2024

lanitochka17 commented Jul 8, 2024 •

edited by VictoriaExpensify

Loading