Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-19] Updating Invoice creation flow #45173

Closed
madmax330 opened this issue Jul 10, 2024 · 24 comments
Closed

[HOLD for payment 2024-08-19] Updating Invoice creation flow #45173

madmax330 opened this issue Jul 10, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@madmax330
Copy link
Contributor

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.fckbittkm504
Project: https://github.com/orgs/Expensify/projects/114

Feature Description

Relevant doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.jxlg73mn39np

Manual Test Steps

Create an invoice and make sure we're using the new flow mentioned in the design doc

Automated Tests

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

Updates:
See this comment

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Jul 25, 2024
@VickyStash
Copy link
Contributor

Updates: the PR has been opened for the review

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot changed the title Updating Invoice creation flow [HOLD for payment 2024-08-19] Updating Invoice creation flow Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 18, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Aug 21, 2024

@madmax330, @VickyStash Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Aug 23, 2024

@madmax330, @VickyStash Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Aug 27, 2024

@madmax330, @VickyStash Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Aug 29, 2024

@madmax330, @VickyStash 10 days overdue. Is anyone even seeing these? Hello?

@madmax330
Copy link
Contributor Author

Will look into this, I think we need to pay the c+ for the PR review

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 2, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

@madmax330, @VickyStash Whoops! This issue is 2 days overdue. Let's get this updated quick!

@madmax330
Copy link
Contributor Author

Just waiting on c+ payment I think

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 9, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

@madmax330, @VickyStash Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Sep 16, 2024

@madmax330, @VickyStash 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@madmax330 madmax330 added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@madmax330
Copy link
Contributor Author

@johncschuster for this one we just need to pay @getusha for the Pr review

@johncschuster
Copy link
Contributor

On it!

@johncschuster
Copy link
Contributor

Payment Summary:

Contributor+: @getusha owed $250 via NewDot

@johncschuster
Copy link
Contributor

@madmax330, will you be adding regression test steps in this issue, or will they be added elsewhere?

@garrettmknight
Copy link
Contributor

$250 approved for @getusha

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@johncschuster
Copy link
Contributor

@madmax330 bump on the question above!

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2024
@madmax330
Copy link
Contributor Author

We'll add them elsewhere, sorry.

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2024
@johncschuster
Copy link
Contributor

No worries! Thanks, @madmax330! I'll go ahead and close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants