[HOLD for payment 2024-08-19] Asking for company name and URL on the first invoice being sent

[madmax330]

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.2gdskq5ha42g
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Relevant doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#bookmark=id.f3av6bmd6vy6

Manual Test Steps

Create an invoice and make sure that if we don't already have company name and website collected then we ask the user to enter it

Automated Tests

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates:

• created the IOURequestStepCompanyInfo page and set up routes for it
• added validation
• updated invoice creation flow in case there is no company info

TODOs:

• confirm translations
• double-check validations and move the extractUrlDomain method to expensify-common (maybe in a follow-up PR)
• Add submit method to the IOURequestStepCompanyInfo page and update the sendInvoice method accordingly
• Fix lint errors

Screenshots

The updates can be found in a Draft PR

[VickyStash]

@madmax330 The Draft PR is ready to be opened for review. I just want to confirm a couple of things with you:

• Is it okay to open the PR with No QA label for now, since BE integration is not ready for now. Though the C+ reviewer should be able to test it - I've added test steps and recordings.
• I didn't put extractUrlDomain into expensify-common lib. I think it can be done as a follow-up if needed. (I'm not 100% sure about it at all since this function used in this case only for now)

Let me know what you think and if I can open the PR for the review.

[madmax330]

Nice yeah I think you can open it up for review

[getusha]

@madmax330 could you assign me here? thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Asking for company name and URL during invoice creation #46009

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• Reviewer: @getusha owed $250 via NewDot

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

Closing as the payment summary above is correct. @getusha please request on NewDot.

[JmillsExpensify]

$250 approved for @getusha