-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-24] [$250] Split - App does not throw an error when saving the empty merchant field #45180
Comments
Triggered auto assignment to @miljakljajic ( |
Triggered auto assignment to @puneetlath ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #vip-split |
Production bandicam.2024-07-10.18-38-04-752.mp4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Split - App does not throw an error when saving the empty merchant field What is the root cause of that problem?The
What changes do you think we should make in order to solve the problem?Use What alternative solutions did you explore? (Optional)Use |
I don't think this is related to backend, removing the |
Demoting. No functionality is blocked, as the user can just enter a merchant |
Job added to Upwork: https://www.upwork.com/jobs/~01bf2bed8e1956b05e |
@Krishna2323, the bug does not exist on production. Could you find the changes in the recent PRs that caused this issue? |
Proposal: Fix Empty Merchant Field Error on Split Expense Problem Statement: The Split app does not throw an error when saving an expense with an empty merchant field, leading to incomplete and inaccurate expense reports. Root Cause: The isMerchantRequired variable remains undefined for split expenses because the code does not check for ReportUtils.isPolicyExpenseChat(report) in the IOURequestStepMerchant.tsx file. Proposed Solution: To resolve this issue, we recommend updating the isMerchantRequired variable to include the ReportUtils.isPolicyExpenseChat(report) check. Specifically, we suggest modifying the code as follows: const isMerchantRequired = ReportUtils.isExpenseRequest(report) || transaction?.participants?.some((participant) =>!!participant.isPolicyExpenseChat); const isMerchantRequired = ReportUtils.isPolicyExpenseChat(report) || transaction?.participants?.some((participant) =>!!participant.isPolicyExpenseChat); Alternative Solutions Explored: We also considered using || isEditingSplitBill as an alternative solution, but it was deemed less effective in addressing the root cause of the issue. Priority: We consider this issue a medium priority, as it affects the accuracy and completeness of expense reports, but does not impact the overall functionality of the app. Please let us know if you would like to discuss this proposal further or proceed with implementation |
Apparently So, I think adding the 🎀 👀 🎀 C+ Reviewed |
Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Hey @c3024, can I just check what you mean by this?
To confirm, we are suggesting that the 'do participants exist' check only needs to happy during creation?
I agree with this. |
Yea, after creation there is no App/src/libs/TransactionUtils.ts Lines 106 to 125 in 0d60861
App/src/libs/TransactionUtils.ts Lines 138 to 157 in 0d60861
so after creation there is never a |
Whereas we add Lines 451 to 452 in 1048f9a
So, while creating the action, the |
I see. So we don't need to optimistically add participants in the case of split, but the condition doesn't currently match our expectation here? |
Confirmed in Slack here. |
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
both contributors paid, thank you! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
App will throw an error when saving the empty merchant field (production behavior).
Actual Result:
App does not throw an error when saving the empty merchant field.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6538012_1720623797916.20240710_225917.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @miljakljajicThe text was updated successfully, but these errors were encountered: