[HOLD for payment 2024-08-14] [$250] Pay someone - Missing paid system message for paying someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM
3. Click + > Pay
4. Enter amount and pay the user
5. Click on the expense preview

Expected Result:

There will be a paid system message for paying someone (according to PR 43742)

Actual Result:

There is no paid system message for paying someone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538116_1720629865877.20240711_004214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ff4cba2e4566fca
• Upwork Job ID: 1813273027515516872
• Last Price Increase: 2024-07-16
• Automatic offers:
• tsa321 | Contributor | 103348532

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing paid system message for paying someone

What is the root cause of that problem?

Here:

App/src/libs/ReportActionsUtils.ts

Lines 388 to 390 in d739580

	function getFilteredForOneTransactionView(reportActions: ReportAction[]): ReportAction[] {
	return reportActions.filter((action) => !isSentMoneyReportAction(action));
	}

the sent money/paid IOU report actions are being filtered out and therefore won't appear in reportActionsToDisplay as shown

App/src/pages/home/report/ReportActionsView.tsx

Lines 218 to 219 in d739580

	return moneyRequestActions.length === 1 ? ReportActionsUtils.getFilteredForOneTransactionView([...actions, createdAction]) : [...actions, createdAction];
	}, [allReportActions, report, transactionThreadReport]);

Consequently, they won't be displayed.

What changes do you think we should make in order to solve the problem?

If the expected result is to display the message, one solution is to remove this filter, allowing the messages to appear as intended.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ff4cba2e4566fca

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MitchExpensify]

Reassigning as I'm heading on leave 🙇

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @tsa321 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tsa321]

@parasharrajat PR is ready

[joekaufmanexpensify]

PR merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix missing paid system message on pay request #46629

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @tsa321 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: One-expense-report old chat messages stays in chat  #44529
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44529/files#r1708661077
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/420008

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: One-expense-report old chat messages stays in chat  #44529
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44529/files#r1708661077
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to DM
2. Click + button on the left side of composer -> click Pay
3. Complete the step
4. Click on the pay/expense message preview
5. Verify there is a paid system message for paying someone

Do you agree 👍 or 👎 ?

[joekaufmanexpensify]

Looks good to me! I will complete checklist.

[joekaufmanexpensify]

Checklist is complete! All set to issue payment soon. We need to pay:

• @tsa321 - $250 for PR via upwork.
• @parasharrajat - $250 for C+ via NewDot.

[joekaufmanexpensify]

All set to issue payment.

[joekaufmanexpensify]

@tsa321 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Closing as all that's left is for @parasharrajat to request payment via NewDot. Thanks everyone!

[parasharrajat]

Payment requested as per #45203 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat