-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-05] [$250] Expensify Card - Offline indicator is below the content in "Choose a card type" page #45272
Comments
Triggered auto assignment to @Gonals ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 2 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Offline indicator is below the content in "Choose a card type" What is the root cause of that problem?We are not adding App/src/pages/workspace/card/issueNew/CardTypeStep.tsx Lines 44 to 47 in 105dce5
What changes do you think we should make in order to solve the problem?Add What alternative solutions did you explore? (Optional) |
I can raise a quick PR. |
Not a release blocker, demoting. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Offline indicator is below the content in ""Choose a card type"" page What is the root cause of that problem?
We don't apply What changes do you think we should make in order to solve the problem?App/src/pages/workspace/card/issueNew/IssueNewCardPage.tsx Lines 22 to 30 in 58e2575
Because ScreenWrapper is applied to child components in the same way, we should wrap ScreenWrapper in
And remove ScreenWrapper in step components What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~0101efe70a56889c26 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann ( |
@etCoderDysto's proposal looks good to me 🎀 👀 🎀 C+ reviewed |
Current assignee @Gonals is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @etCoderDysto You have been assigned to this job! |
not overdue. Waiting for @etCoderDysto to raise the PR |
@DylanDylann PR is ready for review. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @sakluger you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
Summarizing payment on this issue: Contributor: @etCoderDysto $250, sent offer via Upwork (Offer) @etCoderDysto please let me know once you've accepted the offer. |
@sakluger I have accepted the offer. Thank you! |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA Regression Test Proposal
Do we agree 👍 or 👎 |
Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The offline indicator will be at the bottom of the screen
Actual Result:
The offline indicator is below the content
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6538927_1720701680852.RPReplay_Final1720701545.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @DylanDylannThe text was updated successfully, but these errors were encountered: