Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] Fix Android & iOS builds #45392

Closed
Julesssss opened this issue Jul 15, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Dupe of this internal issue

Problem

App workflow builds are failing to build with a new error. We have made no changes to our workflows. Discussion.

Why is this important?

We can't push any Android builds, can't make releases, and QA can't test any fixes.

Solution

???

@Julesssss Julesssss added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task labels Jul 15, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 15, 2024
@Julesssss
Copy link
Contributor Author

Fixed with both of these PRs:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@Julesssss
Copy link
Contributor Author

Both PRs cherry-picked. Should be fully resolved as soon as the next App release takes place

@Kicu
Copy link
Member

Kicu commented Jul 16, 2024

@Julesssss I think the same changes you added here need to be added to testBuild.yml as well. In this PR the changes go to platformDeploy only.

Here is an example of adhoc build that failed for android with the same error: https://github.com/Expensify/App/actions/runs/9943241672

@Julesssss
Copy link
Contributor Author

@Kicu ah thanks. I must have accidentally removed the fix from the Test build workflow at some point 🤦

Submitted a new PR here.

@Julesssss
Copy link
Contributor Author

Test builds have been verified fixed here

@Julesssss Julesssss self-assigned this Jul 16, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title Fix Android & iOS builds [HOLD for payment 2024-07-24] Fix Android & iOS builds Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-24] Fix Android & iOS builds [HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] Fix Android & iOS builds Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-25. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants