[NO QA] Attempt to fix Android builds with ruby workaround #45332

Julesssss · 2024-07-12T11:02:29Z

Details

PARTIALLY fixes Android and iOS build issues with a ruby workaround I found in this public Fastlane issue.

This PR and this SWM PR together fix the build issues. The Desktop and Web builds are failing due to my hardcoded PR number that was required for testing 🎉

Test run
Web failing due to hardcoded PR and missing param
iOS & Android builds

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/412320

Tests

I combined both fixes into this PR, then ran a local workflow using Github CLI to verify that this will work once both PRs hit prod.

@Julesssss will CP then verify once the next App release is deployed (should be today)

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-07-12T11:54:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45332/NewExpensify.dmg	https://45332.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2024-07-12T15:32:29Z

The first build issue is resolved with -rostruct, but a seperate issue with method_missing error occurs later in the workflow 😖

Attempting a separate fix.

Julesssss · 2024-07-12T15:49:03Z

New PR attempt here.

* main: (186 commits) Also upgrade download-artifact Update version to 9.0.6-3 caught a spanish typo disable lint next line Upgrade actions/upload-artifact to drop deprecated version Prettier fix Update Request-the-Card.md prettier clear onyx and reset necessary values Fix bad translation prettier Revert "Reset amount on reset button click" Rename Onyx Key minor fix. added isWaypointEmpty to check if a waypoint is empty or not. Skip call OpenWorkspaceView on workspace profile page fix merge Fix web maintainVisibleContentPosition with strict mode enabled fix typo fix: go back ...

github-actions · 2024-07-15T11:01:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45332/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45332/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-07-15T11:48:01Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2024-07-15T11:48:37Z

patches/@react-native-community+netinfo+11.2.1+002+turbomodule.patch

-*AppPackages*
-*BundleArtifacts*
-
-#OS junk files
-[Tt]humbs.db
-*.DS_Store
-


I can't figure out why this diff shows, I pasted the exact raw code from the prior commit and the code is identical...

Julesssss · 2024-07-15T11:49:45Z

No external review required here

Beamanator · 2024-07-15T11:58:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Julesssss · 2024-07-15T11:59:46Z

Merging with the failing performance test as it is due to the patch issue. The 2nd part of this fix is going to resolve that

[NO QA] Attempt to fix Android builds with ruby workaround (cherry picked from commit 20eb52e)

OSBotify · 2024-07-15T12:11:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…g-45332-1 🍒 Cherry pick PR #45332 to staging 🍒

OSBotify · 2024-07-15T13:59:30Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.6-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2024-07-15T16:29:27Z

.github/workflows/platformDeploy.yml

@@ -84,13 +84,15 @@ jobs:
        if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
        run: bundle exec fastlane android beta
        env:
+          RUBYOPT: '-rostruct' # TODO: Temporary fix until https://github.com/fastlane/fastlane/pull/21950 gets released


Reminder: TODOs in the code are generally not a best practice - it's better to create a follow-up GitHub issue and link it to the code via a comment in the PR

Fair point. I removed this code alongside another fix here and created an issue in place of the TODO

OSBotify · 2024-07-15T16:36:22Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T17:09:21Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:28:44Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T21:08:41Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:25:49Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

attempt to fix Android builds with ruby workaround

7629672

Julesssss added the Ready To Build label Jul 12, 2024

Julesssss self-assigned this Jul 12, 2024

This comment has been minimized.

Sign in to view

Julesssss added 2 commits July 12, 2024 12:20

try bumping ruby for Android builds

9988476

test against test build workflow

ae00836

attempt forcing bundler and ruby update

f9f1973

Julesssss force-pushed the jules-androidBuildFailure branch from 3936d49 to e690c8b Compare July 12, 2024 12:11

attempt -rostruct fix again

54a3399

Julesssss force-pushed the jules-androidBuildFailure branch from e690c8b to 54a3399 Compare July 12, 2024 12:22

Expensify deleted a comment from github-actions bot Jul 12, 2024

temporarily add GH action PULL_REQUEST_NUMBER

d22b0a5

Julesssss force-pushed the jules-androidBuildFailure branch from 55a4168 to d22b0a5 Compare July 12, 2024 13:50

attempt to hardcode test workflow PR number

76462ad

Julesssss mentioned this pull request Jul 12, 2024

Jules android build failure2 #45347

Closed

50 tasks

Julesssss added 2 commits July 15, 2024 10:39

attempt to apply SWM patch

10fa203

Julesssss force-pushed the jules-androidBuildFailure branch from f2bf5bc to 10fa203 Compare July 15, 2024 09:58

reattempt to add the SWM netInfo patch

d1ccbf8

Julesssss changed the title ~~Attempt to fix Android builds with ruby workaround~~ [NO QA] Attempt to fix Android builds with ruby workaround Jul 15, 2024

revert changes required for testing

c9646de

Expensify deleted a comment from github-actions bot Jul 15, 2024

Julesssss marked this pull request as ready for review July 15, 2024 11:47

Julesssss requested a review from a team as a code owner July 15, 2024 11:47

melvin-bot bot removed the request for review from a team July 15, 2024 11:48

melvin-bot bot requested a review from jayeshmangwani July 15, 2024 11:48

Julesssss commented Jul 15, 2024

View reviewed changes

Julesssss removed the request for review from jayeshmangwani July 15, 2024 11:49

Julesssss mentioned this pull request Jul 15, 2024

[HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] Fix Android & iOS builds #45392

Closed

Beamanator approved these changes Jul 15, 2024

View reviewed changes

Julesssss merged commit 20eb52e into main Jul 15, 2024
9 of 12 checks passed

Julesssss deleted the jules-androidBuildFailure branch July 15, 2024 11:59

OSBotify pushed a commit that referenced this pull request Jul 15, 2024

Merge pull request #45332 from Expensify/jules-androidBuildFailure

7a70607

[NO QA] Attempt to fix Android builds with ruby workaround (cherry picked from commit 20eb52e)

os-botify bot mentioned this pull request Jul 15, 2024

🍒 Cherry pick PR #45332 to staging 🍒 #45398

Merged

Julesssss added a commit that referenced this pull request Jul 15, 2024

Merge pull request #45398 from Expensify/Julesssss-cherry-pick-stagin…

bb0a66d

…g-45332-1 🍒 Cherry pick PR #45332 to staging 🍒

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

roryabraham reviewed Jul 15, 2024

View reviewed changes

kirillzyusko mentioned this pull request Jul 23, 2024

e2e: fix build issue #45997

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Attempt to fix Android builds with ruby workaround #45332

[NO QA] Attempt to fix Android builds with ruby workaround #45332

Julesssss commented Jul 12, 2024 •

edited

Loading

This comment has been minimized.

github-actions bot commented Jul 12, 2024

Julesssss commented Jul 12, 2024

Julesssss commented Jul 12, 2024

github-actions bot commented Jul 15, 2024

melvin-bot bot commented Jul 15, 2024

Julesssss Jul 15, 2024

Julesssss commented Jul 15, 2024

Beamanator commented Jul 15, 2024 •

edited

Loading

Julesssss commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

roryabraham Jul 15, 2024

Julesssss Jul 16, 2024 •

edited

Loading

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

[NO QA] Attempt to fix Android builds with ruby workaround #45332

[NO QA] Attempt to fix Android builds with ruby workaround #45332

Conversation

Julesssss commented Jul 12, 2024 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

github-actions bot commented Jul 12, 2024

Julesssss commented Jul 12, 2024

Julesssss commented Jul 12, 2024

github-actions bot commented Jul 15, 2024

melvin-bot bot commented Jul 15, 2024

Julesssss Jul 15, 2024

Choose a reason for hiding this comment

Julesssss commented Jul 15, 2024

Beamanator commented Jul 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Julesssss commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

roryabraham Jul 15, 2024

Choose a reason for hiding this comment

Julesssss Jul 16, 2024 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

Julesssss commented Jul 12, 2024 •

edited

Loading

Beamanator commented Jul 15, 2024 •

edited

Loading

Julesssss Jul 16, 2024 •

edited

Loading