Thread - App flickers & returns to main chat when leaving and reentering thread

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Send a message.
4. Open the message in thread > Send a message in thread.
5. Leave the thread via thread header.
6. Click on the thread subtitle to return to main chat.
7. Open the thread again from the main chat.
8. Note that app auto returns to main chat.

DM issue

1. Go to staging.new.expensify.com
2. Go to DM.
3. Send a message.
4. Open the message in thread > Send a message in thread.
5. Leave the thread via thread header.
6. Click on the thread subtitle to return to main chat.
7. Open the thread again from the main chat.
8. Note that thread flickers briefly.

Expected Result:

No flicker issue and app will remain on the same thread when leaving and reentering thread.

Actual Result:

• In workspace chat, thread flickers and auto returns to main chat after leaving and reentering thread.
• In DM, thread flickers briefly and remains on the same thread when leaving and reentering thread in DM.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6547839_1721477323941.20240720_200016.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @chiragsalian

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[tsa321]

This seems related to my PR regarding loading the skeleton of the report screen (I believe only related to report action list). However, the loading is also displayed for the composer and header of the report, which are different components from the the report action list. I will investigate further.

[tsa321]

It seems like this is a backend issue. When user leaves the thread and returns to the parent report, and then goes back to the thread again, GetMissingOnyxMessages sets the report and report_actions to null.

[mountiny]

Thanks, @tsa321. I don't think this is major enough to be a blocker, as it's a rare scenario for the user to do, and it's just a minor UX issue. @tsa321, do you, however, know if this is not happening in the production backend? Maybe its a mix of frontend and backend change

[mountiny]

@trjExpensify @srikarparsi please feel free to make this a blocker if you disagree with my reasoning above

[tsa321]

@mountiny, in production, the 'leave' button doesn't exist. So, I think this is a new feature?

[mountiny]

@tsa321 not completely, it used to be in the three dot menu, but it was omitted by mistake when we moved all the actions to RHP so its not new new, just new ™️

[trjExpensify]

Haha, so are we seeing this reproduced on prod?

[mountiny]

Well not in the current prod as you were not able to leave. Its hard to say if this was the case couple weeks back before the details revamp

[trjExpensify]

This shows the option to Leave in details, has that not made its way to prod?

[mountiny]

@trjExpensify we have just deployed so now it will be in production too

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[srikarparsi]

Ok I'm able to reproduce both of the issues from the issue body on production and agree with @tsa321's analysis. We do eventually get to the right report both times but there is a "glitch". My plate's really full right now so I don't think I'll be able to look into this until late next week, do you think we could see if there's anyone who could look into this sooner?

[trjExpensify]

Sounds good! @muttmuure is this janky enough in a core chat flow to go into #newdot-quality?

[muttmuure]

Probably as a LOW?

[trjExpensify]

Sounds good!

[melvin-bot]

@trjExpensify @srikarparsi this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[srikarparsi]

I'm still working on wave-collect and instant-smartscan and don't have the bandwidth to take this one on. I'm going to un-assign as per this slack post but please re-assign me if anything has changed since then.

[trjExpensify]

@muttmuure, do we add the #newdot-quality auto assigner here now? Is that the process?

[muttmuure]

Yes, exactly

[melvin-bot]

Triggered auto assignment to @chiragsalian (AutoAssignerNewDotQuality)

[muttmuure]

https://stackoverflowteams.com/c/expensify/questions/19512

[chiragsalian]

oh whoops i thought this was an external issue. I'll try to catch up on this when i get the chance.

[muttmuure]

Oh, I think I misunderstood what this issue was, I'm going to add it to UX reliability

[chiragsalian]

Okay i finally got some free time to check this out today. I tested on main and staging and I'm unable to reproduce the issue.
After i leave the thread, when i click into the thread again i only see an OpenReport network request. I do not see a GetMissingOnyxMessages request. Maybe this was resolved but a change in flow elsewhere.

Can someone else retest and confirm if this issue still persists? @m-natarajan @tsa321 @muttmuure. If not we can close out this issue.

[tsa321]

I think this issue has been fixed. I am unable to reproduce it in staging.

[muttmuure]

OK seems to be fixed on staging for me

[muttmuure]

Going to close

[muttmuure]

Thanks!