[$250] Chat - Thread page reloads when user entering it first time after leaving

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45921

Action Performed:

1. Open any chat
2. Send a message
3. Right click on the message > Reply in thread
4. Send a reply in thread
5. Click on the chat header
6. Click Leave
7. Enter the thread again

Expected Result:

Thread page opens without reloading

Actual Result:

Thread page reloads after entering thread for the first time after leaving. If user navigates to parent chat and entering thread again, no reload page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549928_1721680441749.bandicam_2024-07-22_23-31-43-789.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018152ed9583469041
• Upwork Job ID: 1815513755284322155
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @suneox

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[francoisl]

The same thing is happening to me on production - it's not a full page reload per se, just the thread data loading. Not sure it's even a bug tbh.
There's also something weird happening, when I send a message, my profile picture disappears (visible at the end of the video), but that's unrelated to this issue.

Screen.Recording.2024-07-22.at.2.20.54.PM.mov

[chiragsalian]

Cool yup doesn't look like a blocker. I'll demote and apply external label for contributors to investigate.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018152ed9583469041

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[tsa321]

same as #45834

[devmadhavvv]

Contributor details
Your Expensify account email: madhavmishra28@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0161f3ad9d848f9056?mp_source=share

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@suneox, @chiragsalian Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[suneox]

Still waiting for a proposal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread page reloads when user entering it first time after leaving

What is the root cause of that problem?

This issue looks like a backend issue, as described in this comment

So when GetMissingOnyxMessages is called,reportOnyx will return undefined, and Skeleton will be displayed, causing it to go to the previous page

App/src/pages/home/ReportScreen.tsx

Line 146 in 837dad5

const [reportOnyx, reportResult] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getReportID(route)}`, {allowStaleData: true});

The logic handles going to the previous page when reportOnyx is undefined.

App/src/pages/home/ReportScreen.tsx

Lines 585 to 614 in 837dad5

	if (
	// non-optimistic case
	(!prevUserLeavingStatus && !!userLeavingStatus) ||
	didReportClose ||
	isRemovalExpectedForReportType ||
	isClosedTopLevelPolicyRoom ||
	(prevIsDeletedParentAction && !isDeletedParentAction)
	) {
	// Early return if the report we're passing isn't in a focused state. We only want to navigate to Concierge if the user leaves the room from another device or gets removed from the room while the report is in a focused state.
	// Prevent auto navigation for report in RHP
	if (!isFocused || isInNarrowPaneModal) {
	return;
	}
	Navigation.dismissModal();
	if (Navigation.getTopmostReportId() === prevOnyxReportID) {
	Navigation.setShouldPopAllStateOnUP(true);
	Navigation.goBack(undefined, false, true);
	}
	if (prevReport.parentReportID) {
	// Prevent navigation to the IOU/Expense Report if it is pending deletion.
	if (ReportUtils.isMoneyRequestReportPendingDeletion(prevReport.parentReportID)) {
	return;
	}
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
	return;
	}
	Report.navigateToConciergeChat();
	return;
	}

The logic handles showing the Skeleton when reportOnyx is undefined.

App/src/pages/home/ReportScreen.tsx

Line 423 in 837dad5

const shouldShowSkeleton =

What changes do you think we should make in order to solve the problem?

Update the GetMissingOnyxMessages API to retrieve the existing value.

What alternative solutions did you explore? (Optional)

[suneox]

@huult Thanks for your proposal. I’ll double-check it in a few hours.

[suneox]

@chiragsalian This issue is a duplicate of #45834. After leaving the thread and reopening it, the report action is set to null when call API GetMissingOnyxMessages, so I think we can close this one.

[chiragsalian]

ah yup looks like it. Thanks for that, it does look like a dupe. Closing out this issue in favor of the other one.