[$250] Dupe detect - Confirmation page with empty data opens when opening invalid dupe confirm link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (same distance)
4. Go to transactiont thread of any expense
5. Click Review duplicates
6. Click Keep this one
7. Proceed to confirmation page
8. Copy the link
9. Modify the report ID in the link and navigate to it
10. Click Confirm

Expected Result:

In Step 9, app should open not here RHP when navigating to dupe review confirmation page of invalid report

Actual Result:

In Step 9, app opens confirmation page with empty data when navigating to invalid dupe confirmation link
In Step 10, when clicking Confirm, not here page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547833_1721456233030.20240720_141358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01437c46405734d3fc
• Upwork Job ID: 1815459015971079692
• Last Price Increase: 2024-07-22
• Automatic offers:
• gijoe0295 | Contributor | 103220593

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not show not found page when the report ID is incorrect.

What is the root cause of that problem?

We do not handle the case of incorrect report ID or transaction in Confirmation page.

What changes do you think we should make in order to solve the problem?

Wrap the page with FullPageNotFoundView whose shouldShow condition is the existence of the transaction ID just like we did with Review page:

App/src/pages/TransactionDuplicate/Review.tsx

Line 47 in 5a2602c

<FullPageNotFoundView shouldShow={transactionID === '-1'}>

Note that the transaction ID existence only can cover the report existence. That means we could never retrieve a transaction when it is not linked to any report.

[mountiny]

cc @pecanoro @JmillsExpensify @parasharrajat

[mountiny]

The proposal seems quite straightforward, @parasharrajat should we go with it?

[mountiny]

Dupe detection is behind beta so we can remove the blocker

[parasharrajat]

@mountiny FYI, I will get all of these issues by tomorrow.

[mountiny]

@parasharrajat Thanks! I was not aware this is behind beta, since it is, we do not have to treat these as blockers which helps

[parasharrajat]

@gijoe0295's proposal makes sense to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[gijoe0295]

@stitesExpensify We're missing External label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01437c46405734d3fc

[melvin-bot]

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gijoe0295]

I spotted several issues and working on them. Expect to finish in several hours.

[parasharrajat]

@gijoe0295 Could you please post summary of issues you faced?

[gijoe0295]

The REVIEW_DUPLICATES Onyx entry takes a noticeably long time to load. We don't know if it is still loading or actually undefined. We also couldn't count only on either report or transaction data. I think the final condition to show not found page is:

• REVIEW_DUPLICATES data is ready (maybe use useOnyx's status metadata)
• REPORT data is not found
• transactionID is undefined

Let me test this further.

[parasharrajat]

Yes, you can do something like this

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 48 in a79189f

const [policies, fetchStatus] = useOnyx(ONYXKEYS.COLLECTION.POLICY);

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @parasharrajat, @stitesExpensify, @gijoe0295 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[parasharrajat]

PR merged. Not deployed to prod yet.

[melvin-bot]

@parasharrajat, @stitesExpensify, @gijoe0295 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

This should be ready to be paid today. We need a BZ person here @stitesExpensify

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Feat/dupe detection confirmation #42571
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Feat/dupe detection confirmation #42571 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

For Web & mWeb:

1. Submit 2 duplicated expenses
2. Press Review duplicates >> Keep this one (any)
3. Proceed to confirmation page
4. Modify the report ID in the URL to anything and navigate to it
5. Verify not found page appears

Do you agree 👍 or 👎 ?

[puneetlath]

Payment summary:

• C - $250 - @gijoe0295 - paid via Upwork
• C+ - 250 - @parasharrajat - to be paid via NewDot

Thanks everyone!

[parasharrajat]

Payment requested as per #45835 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat