[HOLD for payment 2024-08-02] [$250] Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two expenses with same content for every field (amount, description, merchant and category)
4. Go to transaction thread of any expense
5. Click Review duplicates
6. Select Keep this one (any)
7. Proceed to confirmation page

Expected Result:

All the fields will reflect the correct information on the confirmation page

Actual Result:

Merchant field is empty on the confirmation page when there is info on merchant field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6548605_1721561004558.bandicam_2024-07-21_19-11-39-312.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0550d2189cf44a1
• Upwork Job ID: 1815322514359268142
• Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Merchant field is empty on the confirmation page when there is info on merchant field.

What is the root cause of that problem?

• With merchant field, we always use:
  

  App/src/libs/TransactionUtils.ts

  Line 905 in f3a8f73

  const allFieldsAreEqual = transactions.every((item) => keys.every((key) => item?.[key] === firstTransaction?.[key]));

  
  but keys is ["modifiedMerchant", "merchant"].
• So firstTransaction?["modifiedMerchant"] can be "".

What changes do you think we should make in order to solve the problem?

• We should update:
  

  App/src/libs/TransactionUtils.ts

  Line 905 in f3a8f73

  const allFieldsAreEqual = transactions.every((item) => keys.every((key) => item?.[key] === firstTransaction?.[key]));

  
  to:

                    if (fieldName === 'merchant') {
                        keep[fieldName] = isEmpty(firstTransaction?.[keys[0]]) ? firstTransaction?.[keys[1]] : firstTransaction?.[keys[0]];
                    } else {
                        keep[fieldName] = firstTransaction?.[keys[0]];
                    }

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant

What is the root cause of that problem?

We are using ?? instead of || so when updatedTransaction?.modifiedMerchant is a empty string the fallback value merchantTitle isn't use.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 524 in eec4d6a

title={updatedTransaction?.modifiedMerchant ?? merchantTitle}

What changes do you think we should make in order to solve the problem?

Use || instead of ?? or use ternary operator updatedTransaction?.modifiedMerchant && updatedTransaction?.modifiedMerchant !== '' ? updatedTransaction?.modifiedMerchant : merchantTitle.

We should also check for similar issue in other fields as well.

What alternative solutions did you explore? (Optional)

[twisterdotcom]

Dupe Detection is still under Beta, so I don't think this needs to be Hourly. We can make it Daily.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0550d2189cf44a1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[mountiny]

And since its in beta we can also remove the blocker labels

[mountiny]

cc @JmillsExpensify @pecanoro @kubabutkiewicz @parasharrajat

[parasharrajat]

We did fix this issue on the PR. May be there are more cases to be handled. @kubabutkiewicz please add this as well.

[pecanoro]

@francoisl I am reassigning the issue to myself so I can review and track the fixes since this is for the duplicate detection project that I am handling.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Polish: Dupe detection #45890

If no regressions arise, payment will be issued on 2024-08-02. 🎊

[twisterdotcom]

@mountiny or @pecanoro who is due payment here? Just @parasharrajat for reviewing #45890?

[twisterdotcom]

Payment Summary:

• @parasharrajat paid $250 via NewDot Manual Request (Reviewer)

[parasharrajat]

Payment requested as per #45865 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat