[HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4751785
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch app
2. Tap fab -- new workspace
3. Tap on workspace chat
4. Tap plus icon near compose and select submit expense
5. Tap distance
6. Select "Your Location" as start point
7. Select any other location as stop point
8. Tap next and submit expense
9. Tap plus icon near compose and select submit expense
10. Tap distance
11. Note recent destination

Expected Result:

"Your Location" address must not be shown in recent destination list while making distance request.

Actual Result:

"Your Location" address is shown in recent destination list while making distance request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6549039_1721626693817.9o.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190c5e3b9ced7a5ac
• Upwork Job ID: 1815347966020873156
• Last Price Increase: 2024-07-22
• Automatic offers:
• suneox | Reviewer | 103229659
• nyomanjyotisa | Contributor | 103229662

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[izarutskaya]

Production

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190c5e3b9ced7a5ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[mountiny]

I dont thinks this has to block the deploy as user can proceed just as normal

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Seems like a minor fix too so putting the price down

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Your Location" address is shown in recent destination list

What is the root cause of that problem?

Actually we already not saving the Your Location address here when selecting address

But, if we already have submitted Distance Expense with 'Your Location' address. The OpenDraftDistanceExpense API will give us the following response(The 'Your Location' still included)

What changes do you think we should make in order to solve the problem?

Add filter to filter out Your Location in Recent address here

.filter(waypoint => !waypoint.keyForList.includes(CONST.YOUR_LOCATION_TEXT))

What alternative solutions did you explore? (Optional)

[suneox]

@nyomanjyotisa proposal filters out your location. LGTM

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @Gonals is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• filter out your location from recent waypoints #46000

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @nyomanjyotisa requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox] Determine if we should create a regression test for this bug.
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[suneox]

BugZero Checklist

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A: The initial code implementation for the recent waypoint doesn’t exclude the current location, so I don’t think there’s a PR responsible for this issue.
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug. N/A

[melvin-bot]

@suneox, @Gonals, @kevinksullivan, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

[suneox]

@kevinksullivan We’re still waiting for payment.

[kevinksullivan]

all set