-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-14] [$125][Payment card / Subscription] - No spacing between "Add payment card" and "Request early cancellation" button #46180
Comments
Triggered auto assignment to @cristipaval ( |
Triggered auto assignment to @twisterdotcom ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalOffending PR #44763 Please re-state the problem that we are trying to solve in this issue.No spacing between "Add payment card" and "Request early cancellation" button What is the root cause of that problem?We are not adding niether margin top for Request early cancellation nor margin bottom for Add payment card button App/src/pages/settings/Subscription/CardSection/RequestEarlyCancellationMenuItem/index.tsx Lines 16 to 21 in 2a9134d
What changes do you think we should make in order to solve the problem?add margin top for Request early cancellation
What alternative solutions did you explore? (Optional)Add margin bottom to Add payment card button
App/src/pages/settings/Subscription/CardSection/CardSectionDataEmpty/index.tsx Lines 17 to 20 in b0f810d
|
Offending PR #44763 |
ProposalPlease re-state the problem that we are trying to solve in this issue.There is no spacing between "Add payment card" and "Request early cancellation" button. What is the root cause of that problem?We have a margin-bottom style here to add a space between these menuItems and the card button. But this item is not always displayed and then when it's not displayed, there is no space between
What changes do you think we should make in order to solve the problem?We should remove the margin-top style here and wrap
What alternative solutions did you explore? (Optional)Or we can add |
Demoting it |
Making it a $125 issue as it is a super simple visual thing |
Job added to Upwork: https://www.upwork.com/jobs/~0186c94058bc49c730 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
@nkdengineer 's proposal here looks good to me. 🎀 👀 🎀 C+ Reviewed |
Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@c3024 can you please comment on my propsoal? |
Sorry for not giving clear feedback. Here is why I felt @nkdengineer 's proposal was better. These three (including App/src/pages/settings/Subscription/CardSection/CardSection.tsx Lines 144 to 169 in 5a0b7aa
are menu items and menu items do not have gaps between themselves. A set of menu items is separated from other elements like a button etc. This is the same pattern used everywhere in the repo. That is why only the first item has a margin top but others do not. But these menu items render conditionally so the top most menu item may not render. In such cases, there will be no gap between the button and menu item (or set of menu items). This logic was missed in the code. If we add App/src/pages/settings/Subscription/CardSection/CardSection.tsx Lines 144 to 167 in 5a0b7aa
appear, then there will be a undesired 8px gap between these menu item(s) and the |
No problem! That makes sense. Thanks for the explanation @c3024 🙌. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
|
Payment Summary:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found validating #44763
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no, not able to check the feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Precondition:
Expected Result:
There will be spacing between "Add payment card" and "Request early cancellation" button.
Actual Result:
There is no spacing between "Add payment card" and "Request early cancellation" button.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6552300_1721888335021.20240725_141515.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: