[Hold of payment 8-27][$250] Cannot scroll down after comment linking

[janicduplessis]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @janicduplessis
Slack conversation:

Action Performed:

• In a chat with many messages copy the link to a message and send it
• Clear the app cache (Troubleshoot -> Clear cache and restart)
• Click on the message link from the first step
• Cannot scroll down

Expected Result:

Can scroll down after linking to message

Actual Result:

Cannot scroll down

Workaround:

Scroll up, then scroll back down

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-25.at.14.07.28.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016056b96e55e3a838
• Upwork Job ID: 1817986329686132368
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[janicduplessis]

The issue seems to be related to this code, which prevents newer messages from being rendered. I am looking with the original author of this code to see why it was needed and if it can be removed.

[janicduplessis]

I have a potential fix, but first need to figure out why this code was needed in the first place and if would cause a regression to remove it.

[Christinadobrzyn]

Looks like this is the same report as - #46222

@janicduplessis looks like you the author of the PR can @ishpaul777 be the C+?

[ishpaul777]

Yes i can review the PR, but I believe the root cause for both issues are different though we can try solving in a single PR.

Oh i see both issues have a draft PR and has different solutions, #46221 for this and #46225 for #46222

[janicduplessis]

@ishpaul777 Would it be easier for you if I create a single PR that fixes all the issues?

Right now I identified 4 bugs with comment linking that all cause some slightly different issues. They all have different root cause so code wise they can be isolated, but I think it might be easier for QA to just test with all the fixes applied to see that it is now smooth.

[ishpaul777]

It makes sense to fix in a single PR 👍 lets do it 🚀

[Christinadobrzyn]

hi! I'm gonna add @ishpaul777 to this since both this GH and #46222 (comment) will be resolved together.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016056b96e55e3a838

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[Christinadobrzyn]

@strepanier03 I'm happy to take this GH if that would be easier for tracking!

[strepanier03]

@Christinadobrzyn - Sounds good to me. I haven't looked at it until now anyway. I'll assign you, thanks!

[Christinadobrzyn]

Awesome! Sounds good Sheena!

[Christinadobrzyn]

Correct me if I'm wrong but the PR for this is here - #46222 (comment), right? @ishpaul777 @janicduplessis

[janicduplessis]

Yes, I consolidated the fixes around comment linking in this PR. Currently looking into janky scroll on android which I think I just found the problem, then PR should be ready.

[Christinadobrzyn]

I'm adding a HOLD on this because the PR is here #46222 so I think this issue can just be tested once the PR is deployed and we can make sure it's resolved too.

[Christinadobrzyn]

monitoring the PR - #46315

[Christinadobrzyn]

monitoring the PR - #46315

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bondydaa]

not sure why I got assigned, looks like @roryabraham is assigned on the PR so going to move it over to you.

[Christinadobrzyn]

PR is in staging - almost there - #46315

[roryabraham]

PR deployed to prod

[ishpaul777]

This is ready for payment 🎉

[Christinadobrzyn]

Awesome! Looks like the 7th day of prod is tomorrow so let's prep for payment.

• @janicduplessis you are with Margelo so paid separately, correct?
• Do we need a regression test for this?

Payouts due:

• Contributor+: $250 @ishpaul777 (upwork offer - https://www.upwork.com/nx/wm/workroom/38196816/overview?nav_dir=pop)

[ishpaul777]

Regression Test Proposal:

1. In a chat with many messages (200 atleast) copy the link to a message and send it
2. Clear the app cache (Troubleshoot -> Clear cache and restart)
3. Click on the message link from the first step

Expected: User linked to correct message

4. Try scrolling down to bottom of chat, verify new message loads as you scroll down.
5. Return to LHN/switch to other chat and then switch again to chat in step 1, and repeat step 3, 4

Do we agree 👍 or 👎

[ishpaul777]

Contributor+: $250 @ishpaul777 (upwork offer - https://www.upwork.com/nx/wm/offer/103686400)

@Christinadobrzyn seems the offer is same as #46222, this was a seprate issue with different root cause and solution, so i beleive payment should seperate

[janicduplessis]

@Christinadobrzyn correct!

[Christinadobrzyn]

Ah, sorry about that, @ishpaul777 - I paid you through the offer associated with this Upwork job #46217 (comment)

I'll create the regression test tomorrow

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/424177

payment is done - closing!