Workspace chat - Incorrect amount shown in preview card after payment.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): biruknew45+2d2gg@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Prerequisite: A workspace is created and 2 expenses are submitted in the workspace chat.

1. Go to [staging.new.expensify.com].
2. Navigate to the workspace chat created.
3. Go to the expense details page.
4. Click on the first expense.
5. Click on the header, then select "hold."
6. Write any reason and then click on "hold."
7. Turn off the connection.
8. Click on the "pay with expensify" dropdown and then select "pay elsewhere."
9. Pay the amount.
10. Navigate back to the main workspace chat by clicking on the subtitle link.

Expected Result:

After paying ETB 300, the preview card on the workspace chat page should show that ETB 300 is paid.

Actual Result:

After paying ETB 300, the preview card on the workspace chat page incorrectly shows that ETB 400 is paid.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6553590_1721992163178.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2653.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying ETB 300, the preview card on the workspace chat page incorrectly shows that ETB 400 is paid.

What is the root cause of that problem?

If we paid partial the expense report, we don't update the total of the expense report in optimistic data

App/src/libs/actions/IOU.ts

Line 6446 in afebc66

const optimisticData: OnyxUpdate[] = [

And then the ReportPreview show the amount is the old total amount

What changes do you think we should make in order to solve the problem?

We should update the total of the expense report here if the paid partial

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`,
    value: {
        ...iouReport,
        lastMessageText: ReportActionsUtils.getReportActionText(optimisticIOUReportAction),
        lastMessageHtml: ReportActionsUtils.getReportActionHtml(optimisticIOUReportAction),
        hasOutstandingChildRequest: false,
        statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,
        pendingFields: {
            preview: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
            reimbursed: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
            partial: full ? null : CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
        total: full ? iouReport.total : total
    },
},

App/src/libs/actions/IOU.ts

Line 6472 in afebc66

key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`,

We should do the same when we approve the report here

const optimisticIOUReportData: OnyxUpdate = {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport?.reportID}`,
    value: {
        ...expenseReport,
        lastMessageText: ReportActionsUtils.getReportActionText(optimisticApprovedReportAction),
        lastMessageHtml: ReportActionsUtils.getReportActionHtml(optimisticApprovedReportAction),
        stateNum: CONST.REPORT.STATE_NUM.APPROVED,
        statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
        pendingFields: {
            partial: full ? null : CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
        total: full ? iouReport.total : total
    },
};

App/src/libs/actions/IOU.ts

Line 6736 in afebc66

key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport?.reportID}`,

What alternative solutions did you explore? (Optional)

NA

[nkdengineer]

@madmax330 Since it's a blocker, I can raise a PR quickly.

[francoisl]

Hi @nkdengineer, with any deploy blocker, can you please also link to the PR from the current checklist that caused the regression? Thanks!

[nkdengineer]

@francoisl It comes from this PR #42573.

[kpadmanabhan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Preview card showing incorrect amount after payment while offline.

What is the root cause of that problem?

When one payment was on hold, payment amount correctly reflects in "Pay XXX Elsewhere". But the same does not reflect in card amount. It still shows total amount before going offline.
Onyx is not updated while making part payments. Hence while offline, when we do not receive API response, we fetch data from onyx and display, which still contains the total amount.

What changes do you think we should make in order to solve the problem?

Update onyx on every payment irrespective of online or offline.

What alternative solutions did you explore? (Optional)

N.A.

[nkdengineer]

Updated proposal

• Add the fix for approving money request

[war-in]

Hi all 👋 I'm the author of the #42573

We decided not to update the value of the old (original) report because we can have expenses in different currencies.

Example:

• report (A) has two expenses (A1, A2)
  • A1 - 10 USD
  • A2 - 30 some other currency which is 10x cheaper
• A has value = 13 USD
• we put A2 on hold
• we can't perform conversion on FE so we set A value to 13 - 30 = -17 which is of course wrong

That's why we can't do it and behaviour is like that

[luacmartins]

Ok, so this seems to be the expected behavior then. @war-in can you confirm so we can close this issue?

[war-in]

@luacmartins Yes, I confirm :)

[luacmartins]

Thanks! Gonna close this issue.