Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-08-22][$250] Multi tag - Selection mode remains on main tag list after returning from sub tag list #46658

Closed
4 of 6 tasks
izarutskaya opened this issue Aug 1, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Workspace is connected to QBO.
  1. Launch New Expensify app.
  2. Go to workspace settings > Tags.
  3. Tap on any main tag.
  4. Long press on any sub tag.
  5. Tap Select.
  6. Swipe right to return to previous page (not app back button).

Expected Result:

Selection mode will be dismissed on the main tag list because main tag cannot be selected for multi tags.

Actual Result:

Selection mode remains on main tag list after returning from sub tag list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6559036_1722505630936.ScreenRecording_08-01-2024_17-40-50_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013892471bd59b7984
  • Upwork Job ID: 1819070503401243549
  • Last Price Increase: 2024-08-01
Issue OwnerCurrent Issue Owner: @ishpaul777
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@carlosmiceli
Copy link
Contributor

I think the issue comes from here: #46096

@jasperhuangg is this a deploy blocker? Because what I'm seeing is that it's all new functionality, right? Wanna decide what we do here?

@jasperhuangg
Copy link
Contributor

@carlosmiceli Yeah this doesn't need to be a blocker. It's just a minor display bug that doesn't prevent you from using the app, and this feature doesn't yet exist on production.

@jasperhuangg jasperhuangg added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 1, 2024
@melvin-bot melvin-bot bot changed the title Multi tag - Selection mode remains on main tag list after returning from sub tag list [$250] Multi tag - Selection mode remains on main tag list after returning from sub tag list Aug 1, 2024
@roryabraham roryabraham added Hourly KSv2 and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013892471bd59b7984

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Aug 1, 2024
@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to take this as it comes from my PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2024
@ishpaul777
Copy link
Contributor

PR review being handled by @ikevin127 as regression from a previous PR #46698 (comment)

@ishpaul777 ishpaul777 removed their assignment Aug 9, 2024
@NikkiWines NikkiWines changed the title [$250] Multi tag - Selection mode remains on main tag list after returning from sub tag list [HOLD for Payment 2024-08-22][$250] Multi tag - Selection mode remains on main tag list after returning from sub tag list Aug 19, 2024
@NikkiWines NikkiWines added the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 19, 2024
@ikevin127
Copy link
Contributor

cc @RachCHopkins for payments

@RachCHopkins
Copy link
Contributor

@carlosmiceli it's not clear to me here who needs to be paid, would you mind giving me a wee summary of who did what?

@carlosmiceli
Copy link
Contributor

I think the PR is authored by @filip-solecki and was reviewed by @ikevin127, correct?

@ikevin127
Copy link
Contributor

✅ Correct, I'm the only one requiring payment here.

cc @RachCHopkins

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 25, 2024
@RachCHopkins
Copy link
Contributor

@ikevin127 I have sent you an offer for the job!

@ikevin127
Copy link
Contributor

@RachCHopkins Offer accepted, thanks!

@RachCHopkins
Copy link
Contributor

Payment Summary:

Contributor+: @ikevin127 paid $250 via Upwork
Upwork job here

@RachCHopkins
Copy link
Contributor

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants