-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Selection Mode fixes #46698
Mobile Selection Mode fixes #46698
Conversation
I guess @ikevin127 should be assigned since it is regression from PR he was reviewing |
@ikevin127 Friendly bump! I can help review the PR if needed. |
@mollfpr No worries, I got this - I was just waiting for assignment in order to be able to review and approve. cc @carlosmiceli if any of you can please assign me for review here as per author request from #46698 (comment) - I will complete the review it by EOD (Pacific). Edit: Thanks Carlos! |
Reviewer Checklist
Screenshots/VideosAndroid: Native *android.webmAndroid: mWeb Chrome *android-mweb.webmiOS: Native *ios.mp4iOS: mWeb Safari *ios-mweb.mp4MacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Tests well and both issues are fixed.
@filip-solecki Not a blocker: adding some tests in the PRs description will facilitate testing for the QA team, here's the block you can just copy & paste it under the Tests section:
**1. Test for issue https://github.com/Expensify/App/issues/46658**:
Precondition: Workspace is connected to QBO.
1. Launch New Expensify app.
2. Go to workspace settings > Tags.
3. Tap on any main tag.
4. Long press on any sub tag.
5. Tap Select.
6. Swipe right to return to previous page (not app back button).
7. Verify that the selection mode will be dismissed on the main tag list because main tag cannot be selected for multi tags.
**2. Test for issue https://github.com/Expensify/App/issues/46652**:
1. Launch New Expensify app.
2. Go to FAB > Send invoice.
3. Enter amount, select participant and send the invoice.
4. In invoice chat, tap on the header.
5. Tap Members.
6. Verify that long press on any member doesn't do anything (doesn't open the Select popup modal anymore).
Thanks @ikevin127 - I missed it 😄 |
🚨 HOLD on merge! @filip-solecki I just noticed #46096 (comment) mentioning that the initial PR #46096 breaks some functionality, and we might be able to fix that here before merging maybe, wdyt ?
|
@ikevin127 fixed! report.fields.list.fix.mov |
🟢 Approved. @NikkiWines We're good to merge now that the latest reported issue is fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.20-0 🚀
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47356 |
Details
This PR fixes two issues found after #46096 merge.
Fixed Issues
$ #46658
$ #46652
PROPOSAL:
Tests
1. Test for issue #46658:
Precondition: Workspace is connected to QBO.
2. Test for issue #46652:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-02.at.08.29.08.mp4