[Due payment][$250] Netsuite - "Reuse existing connection" is an option when there is no existing workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition
An already signed-in account with a workspace connected to NetSuite integration

1. Sign out of the account with the workspace connected to NetSuite integration (Important)
2. Sign in with a new account
3. Navigate to settings > Workspace > Create new Workspace
4. Navigate to more features > Enable accounting
5. Go to Accounting > Connect to NetSuite
6. Upgrade the workspace to Control > Navigate back to Accounting > Click on "Connect" next to NetSuite
7. Here notice that two options appear "Create new connection" and "Reuse existing connection"
8. Click on "Reuse existing connection" > The workspace from the signed-out account appears > Click on the workspace

Expected Result:

Step 7. There will be no option for "Reuse existing connection" since there is no existing workspace connected to NetSuite in the account

Actual Result:

Step 7. "Reuse existing connection" is an option even if there is no existing workspace
Step 8. When clicking on the workspace from the signed-out account, Infinite loading is displayed and there is no way to cancel it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6558884_1722491297311.2024-08-01_08_10_35.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b773ba1a34cd80ac
• Upwork Job ID: 1823791114589945944
• Last Price Increase: 2024-08-14

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[kadiealexander]

Not overdue, looking for someone internal to pick it up.

[kadiealexander]

@yuwenmemon @mananjadhav is this on your radar at all?

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

@yuwenmemon @mananjadhav bump!

[mananjadhav]

Sorry I was OOO past few days. I'll take a look at this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b773ba1a34cd80ac

[melvin-bot]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Netsuite - "Reuse existing connection" is an option when there is no existing workspace

What is the root cause of that problem?

• When clicking on "Connect" button, we show the reuse connection popover:
  

  App/src/components/ConnectToNetSuiteButton/index.tsx

  Line 82 in 65a3811

  setIsReuseConnectionsPopoverOpen(true);

  
  if hasPoliciesConnectedToNetSuite:
  

  App/src/components/ConnectToNetSuiteButton/index.tsx

  Line 29 in 65a3811

  const hasPoliciesConnectedToNetSuite = !!getAdminPoliciesConnectedToNetSuite()?.length;

  
  is true.

• The getAdminPoliciesConnectedToNetSuite gets data from allPolicies:
  

  App/src/libs/actions/Policy/Policy.ts

  Lines 3287 to 3289 in c880993

  	function getAdminPoliciesConnectedToNetSuite(): Policy[] {
  	return Object.values(allPolicies ?? {}).filter<Policy>((policy): policy is Policy => !!policy && policy.role === CONST.POLICY.ROLE.ADMIN && !!policy?.connections?.netsuite);
  	}

  
  which is not cleared when signing out, leads to it is using the allPolicies data of the previous session.

What changes do you think we should make in order to solve the problem?

• We should create a clean-up function:

const clearAllPolicies = () => {
    allPolicies = {};
};

and call it once we sign out to.

• There are a lot of ways to call it, for example, call it in:
  

  App/src/libs/actions/SignInRedirect.ts

  Line 16 in c880993

  function clearStorageAndRedirect(errorMessage?: string): Promise<void> {

What alternative solutions did you explore? (Optional)

• In ConnectToNetSuiteButton, we can get the allPolicies data directly from onyx through useOnyx. And then:
  

  App/src/components/ConnectToNetSuiteButton/index.tsx

  Line 29 in 65a3811

  const hasPoliciesConnectedToNetSuite = !!getAdminPoliciesConnectedToNetSuite()?.length;

  
  will be:

    const hasPoliciesConnectedToNetSuite = !!getAdminPoliciesConnectedToNetSuite(allPolicies)?.length;

• In above, we need to modify the getAdminPoliciesConnectedToNetSuite so that it can accept a allPolicies param as well.

[melvin-bot]

@mananjadhav @yuwenmemon @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mananjadhav]

Thanks for the proposal @daledah. But I think we clear all the keys on Signout.

I didn't get time to take a look at this. I will check this on the weekend.

[daledah]

But I think we clear all the keys on Signout

Yes, we cleared all the onyx keys, but the allPolicies variable is not cleared on Signout. It is just cleared when we refreshing the page.

[kadiealexander]

@mananjadhav any updates?

[mananjadhav]

I tried this and I couldn't reproduce this.

@daledah I am still not convinced as the policies need be explicitly cleared out on sign out. This is especially when you see a new workspace option. @lanitochka17 are you getting the same option for Sage Intacct? the code for reuse existing connection is the same.

I still need help with the reproduction here.

[daledah]

@mananjadhav

I am still not convinced as the policies need be explicitly cleared out on sign out.

• As you can see, we don't have a logic to clear this global variable:
  

  App/src/libs/actions/Policy/Policy.ts

  Line 118 in c880993

  const allPolicies: OnyxCollection<Policy> = {};

  
  on signing out.

This is especially when you see a new workspace option

• We display the new workspace option based on:
  

  App/src/pages/workspace/WorkspacesListPage.tsx

  Lines 450 to 452 in c7ec59b

  	policies: {
  	key: ONYXKEYS.COLLECTION.POLICY,
  	},

  
  Because of using withOyx, the ``policies``` data is always up-to-date.

I still need help with the reproduction here

• Based on my RCA, to reproduce the issue, you need to make sure from step 1 to step 8, you don't refresh the page.

[mananjadhav]

Was just coming back to this. Yeah I think it makes sense to clear allPolicies. @yuwenmemon I think @daledah's proposal would work. Can we make this external assign them and I can review?

🎀 👀 🎀

[melvin-bot]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@mananjadhav This PR is ready for review.

[mananjadhav]

@yuwenmemon I think this is deployed on production right? I can see the linked deploy checklist is completed.

[yuwenmemon]

Yep @kadiealexander can we process payment and then close this out?

[garrettmknight]

@mananjadhav can you complete the checklist when you get a chance?
@kadiealexander please post the payment summary if this is ready to go!

[mananjadhav]

The allPolicies has been existing since long and I think this was an edge case which we couldn't trace during any of the NetSuite work. These could be reproducible for other connections as well. Hence, I don't think we have any offending PR.

Considering this is an edge case I don't think we need a regression test for this one.

@kadiealexander All yours for payment summary.

[kadiealexander]

Payouts due:

• Contributor: $250 @daledah via Upwork (please apply!)
• Contributor+: $250 @mananjadhav via Manual Requests

Upwork job is here.

[garrettmknight]

$250 approved for @mananjadhav

[daledah]

@daledah via Upwork (please apply!)

@kadiealexander Sorry I don't have Upwork Connects so could not apply. Could you send the offer at https://www.upwork.com/freelancers/~0138d999529f34d33f? Thx

[kadiealexander]

@daledah I've sent you a contract.

[daledah]

@kadiealexander I accepted the contract