fix: clear policies after sign out #47776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
mananjadhav
and removed request for
a team
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
6 tasks
mananjadhav
reviewed
Aug 22, 2024
| @@ -29,6 +30,7 @@ function clearStorageAndRedirect(errorMessage?: string): Promise<void> { | |||
| } | |||
|
|
|||
| return Onyx.clear(keysToPreserve).then(() => { | |||
| Policy.clearAllPolicies(); | |||
There was a problem hiding this comment.
I think the placement for the method is fine here, but I have never touched this part of the code, so I am not sure if we have any preference here.
Will defer to @yuwenmemon for this.
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-reset-policies.movAndroid: mWeb Chromemweb-chrome-reset-policies.moviOS: NativeiOS: mWeb Safarimweb-safari-reset-policies.movMacOS: Chrome / Safariweb-reset-policies.movweb-reset-policies-2.movMacOS: Desktopdesktop-reset-policies.mov |
mananjadhav
approved these changes
Aug 25, 2024
yuwenmemon
approved these changes
Aug 26, 2024
| @@ -29,6 +30,7 @@ function clearStorageAndRedirect(errorMessage?: string): Promise<void> { | |||
| } | |||
|
|
|||
| return Onyx.clear(keysToPreserve).then(() => { | |||
| Policy.clearAllPolicies(); | |||
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.25-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.25-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #46680
PROPOSAL: #46680 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-21.at.19.55.49.mp4
Android: mWeb Chrome
Screen.Recording.2024-08-21.at.19.52.19.mp4
iOS: Native
Screen.Recording.2024-08-21.at.20.06.38.mp4
iOS: mWeb Safari
Screen.Recording.2024-08-21.at.19.59.06.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-08-21.at.16.08.10.mp4
MacOS: Desktop
Screen.Recording.2024-08-21.at.20.07.57.mp4