[Hold for payment 2024-09-16] [$125] [P2P Distance] Split - Error shows up when splitting distance to workspace chat via QAB

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-0
Reproducible in staging?: Yes
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace chat.
4. Click + > Split expense > Distance.
5. Split distance expense in the workspace chat.
6. Click FAB.
7. Click Split distance under Quick action.
8. Enter waypoints > Next.

Expected Result:

User will be able to split distance to workspace chat via QAB.

Actual Result:

Error shows up when splitting distance to workspace chat via QAB.
On iOS, app crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565080_1723073400020.20240808_072722.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebb99c7c764b036a
• Upwork Job ID: 1824435072292925117
• Last Price Increase: 2024-08-16
• Automatic offers:
• akinwale | Reviewer | 103602852

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[youssef-lr]

Checking

[youssef-lr]

Not a web blocker. Looks like the request from the workspace chat uses CreateDistanceRequest for the command, and the one from QAB uses the 'SplitBill' command which fails. I think it should use CreateDistanceRequest as well. cc @neil-marcellini

[youssef-lr]

Removing blocker from NewDot as well because this Distance Split are not live in production yet

[sonialiap]

@youssef-lr am I correct in that this was introduced by Neil's PR? Should this be assigned to him?

[youssef-lr]

am I correct in that this was introduced by Neil's PR?

Yes. I think it's fine to have this external unless @neil-marcellini wants to work on it?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebb99c7c764b036a

[Shahidullah-Muffakir]

Screen Recording: Showing Distance splitting from Quick actions
https://github.com/user-attachments/assets/b96dcf51-bc83-4d8a-9707-91eea1f01b0e

@

[melvin-bot]

@akinwale, @youssef-lr, @sonialiap, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[akinwale]

@Shahidullah-Muffakir How would your proposed solution work in offline mode? Can you test this as well?

[Shahidullah-Muffakir]

@akinwale Do we have support for Distance split in offline mode?
I think Distance split is not currently supported in offline mode, including in production. The main challenge is calculating distances and amounts without internet access.
Currently In production In offline mode, users can only use Manual split, not Distance split.

This video shows:
Manual split available offline in Prod
Distance split unavailable offline in Prod
Video:
https://github.com/user-attachments/assets/2311b120-1891-4405-97c0-6839fb3da9ea

[akinwale]

We can move forward with @Shahidullah-Muffakir's proposal here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Current assignee @youssef-lr is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[Shahidullah-Muffakir]

Thank you for hiring me, I will make the PR within one hour.

[dylanexpensify]

Nice turnaround @Shahidullah-Muffakir!

[Shahidullah-Muffakir]

Thank you @dylanexpensify .

[Shahidullah-Muffakir]

@akinwale , PR #47737 has been ready for 2 days. Could you review when possible? Thank you!

[akinwale]

Thanks for the bump. I will review today.

[sonialiap]

@dylanexpensify thanks for helping out while I was OOO! Taking this back. Feel free to keep on or unassign yourself

[sonialiap]

Still waiting for the production deploy #47737

[akinwale]

@sonialiap Automation hasn't been picking up some issues in the past few days. The PR was deployed to production on 2024-09-09 (part of this checklist), so payment is due on 2024-09-16.

[sonialiap]

Thanks @akinwale!

[sonialiap]

Payment summary:

• @akinwale $125 - paid ✔️
• @Shahidullah-Muffakir $125 - paid ✔️