[PAID] [$125] Report fields - List values field does not show the content in alphabetical order

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
This issue was found when executing this PR #46382
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields.
3. Click Add field.
4. Select List from Type.
5. Click List values.
6. Click Add value.
7. Add a few list values randomly.
8. Click back button.

Expected Result:

List values field will show the content in alphabetical order.

Actual Result:

List values field does not show the content in alphabetical order, which is not consistent with the list in List values page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565112_1723077570232.20240808_083209.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0164fa6c8455234523
• Upwork Job ID: 1821472046215029241
• Last Price Increase: 2024-08-08
• Automatic offers:
• shubham1206agra | Contributor | 103445958

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[paultsimura]

IMO this shouldn't be a deploy blocker, and it's not a regression – it's a missed nuance from the implementation of a new feature.

The PR that introduced alphabetical ordering was merged 2 days ago: #46757
The PR that added list values to the menu item was merged yesterday: #46382

cc: @Krishna2323 @shubham1206agra

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields - List values field does not show the content in alphabetical order

What is the root cause of that problem?

We are directly showing list values in order we get from ONYX.

App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx

Line 50 in 53eee53

const listValues = Object.values(policy?.fieldList?.[reportFieldKey]?.values ?? {});

What changes do you think we should make in order to solve the problem?

We shall add sort method on list values. We shall convert it to lowercase while comparing.

const listValues = Object.values(policy?.fieldList?.[reportFieldKey]?.values ?? {}).sort(localeCompare);

Screen.Recording.2024-08-08.at.2.09.11.PM.mov

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0164fa6c8455234523

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[shubham1206agra]

@Krishna2323 Can you please raise a PR on urgent basis?

[Krishna2323]

@shubham1206agra, yes.

[melvin-bot]

Upwork job price has been updated to $125

[grgia]

Assigning @mountiny

[mountiny]

@Krishna2323 What is your ETA for the PR you reckon

[Krishna2323]

@mountiny, I was waiting for the assignment, will raise PR today.

[Krishna2323]

@shubham1206agra, PR ready for review ^

[shubham1206agra]

@mountiny Bump for payment here

[mountiny]

@strepanier03 this is ready for payment $125 to @shubham1206agra and to @Krishna2323

[strepanier03]

Today is the 27th so payment isn't late, handling this as normal.

[strepanier03]

Payment summary

• $125 - @Krishna2323 PAID via Upwork (contract)
• $125 - @shubham1206agra via Upwork (offer)

[strepanier03]

Offer sent to @shubham1206agra is pending still so I'll check again in the morning.

[shubham1206agra]

@strepanier03 Offer accepted

[strepanier03]

Thanks @shubham1206agra - I have paid the contract and closed it.