-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] [$250] [Wave Control] Update the Report field list type creation flow #45990
Comments
Triggered auto assignment to @muttmuure ( |
@Expensify/design @JmillsExpensify Can you please double check that is right? |
Looks good to me! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Initial value incorrectly appears above List values for report field configuration What is the root cause of that problem?The App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx Lines 83 to 98 in d739580
What changes do you think we should make in order to solve the problem?
const listValues = Object.values(policy?.fieldList?.[reportFieldKey]?.values ?? {});
const reportFieldDisabledValues = Object.values(policy?.fieldList?.[reportFieldKey]?.disabledOptions ?? {});
// Pass title
{isListFieldType && (
<MenuItemWithTopDescription
style={[styles.moneyRequestMenuItem]}
titleStyle={styles.flex1}
title={listValues.join(', ')}
{inputValues[INPUT_IDS.TYPE] === CONST.REPORT_FIELD_TYPES.LIST && (
<MenuItemWithTopDescription
description={translate('workspace.reportFields.listValues')}
shouldShowRightIcon
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS_LIST_VALUES.getRoute(policyID))}
title={formDraft?.[INPUT_IDS.LIST_VALUES]?.join(', ')}
/>
)}
What alternative solutions did you explore? (Optional)
// In 'ReportFieldsSettingsPage'
title={listValues.filter((v, i) => !disabledListValues[i]).join(', ')}
// In 'CreateReportFieldsPage'
title={formDraft?.[INPUT_IDS.LIST_VALUES]?.filter((v, i) => !formDraft?.[INPUT_IDS.DISABLED_LIST_VALUES][i]).join(', ')} Additionally we also might want to increase the number of lines for value field in Resultfield_list.mp4 |
Proposal Updated
|
Job added to Upwork: https://www.upwork.com/jobs/~0124fe6a5dd4337910 |
Current assignees @rushatgabhane and @shubham1206agra are eligible for the External assigner, not assigning anyone new. |
@rushatgabhane @shubham1206agra can you please review the proposal? I think the main problem here is to make sure the list values nicely wrap even if the list is very long |
@Krishna2323 Your proposal looks good. Can you just show the screenshot with 20 values and one super-long list value? Thanks |
ProposalPlease re-state the problem that we are trying to solve in this issue.The list values are displayed incorrectly What is the root cause of that problem?This is a new feature request What changes do you think we should make in order to solve the problem?
OPTIONAL: If we only want to display some lines of list values, we can pass
App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx Lines 97 to 98 in bf4bc6f
We should do the same for the creation flow in We can see the test branch here for more details https://github.com/nkdengineer/App/tree/fix/45990. What alternative solutions did you explore? (Optional)NA ResultScreen.Recording.2024-07-23.at.17.02.09.mov |
@shubham1206agra, I think we should allow only 4-5 lines. @shawnborton what's you opinion? Note:
|
Cc @Expensify/design @JmillsExpensify @trjExpensify - do we have strong feelings here? Part of me thinks that trimming to 4-5 lines makes sense here in case the list is insanely long. |
I definitely think we should cap it, these imported lists of customers/projects can be very long. |
📣 @rafaykr! 📣
|
contributor details Dear Hiring Manager, I am excited to submit my proposal for the React Native developer position to assist with the migration project at Expensify. As a seasoned full-stack developer with a strong focus on mobile application development and user experience, I am confident in my ability to address the challenges outlined in GitHub issue #45990. Expensify’s commitment to maintaining a reliable and secure system for processing financial transactions is commendable, and the goal of unifying the front-end across platforms using React Native is a strategic move towards enhancing user experience and operational efficiency. I am eager to contribute to this mission and help ensure that your platform remains at the forefront of innovation in the financial sector. Addressing Your Needs: I will modify the React component responsible for rendering the list-type report field to ensure the Initial value option appears after the List values. This will involve a careful restructuring of the JSX to guarantee the desired order is achieved. To ensure that the List values are displayed correctly as a comma-separated list without truncation, I will update the CSS/styling. This will involve implementing a wrapping mechanism that maintains readability and presentation integrity, even when the values exceed the container width. Adjust the JSX structure in the React component. Apply CSS to ensure proper wrapping. ..list-values { Testing: Conduct comprehensive unit and visual tests across all platforms to verify the correctness and usability of the changes. Why I am the Right Fit: Experience: With a strong background in React Native and UI/UX design, I have successfully delivered numerous projects that required meticulous attention to detail and robust cross-platform compatibility. Thank you for considering my application. I look forward to the possibility of contributing to Expensify's continued success and helping to advance your migration project. Best regards, |
Yeah I agree. After seeing the super mega long one, I don't really see a whole lot of value gained by NEVER truncating. At a certain point the huge push input list is just not helpful. I think capping at 4-5 lines is good. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-19. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@muttmuure, this is ready for payments :) |
@mountiny For this issue, my payment will be separate from the project or in the project? |
@rushatgabhane, @mountiny, @muttmuure, @shubham1206agra, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
This can be separate $250 to @Krishna2323 and to @shubham1206agra please @muttmuure |
I have been paid. 🙏🏻 |
@Krishna2323 has indeed been paid |
@shubham1206agra I need you to accept the offer https://www.upwork.com/nx/wm/offer/103272331 |
@rushatgabhane - $250 C+ |
@muttmuure Offer accepted |
Paid |
@rushatgabhane can request in ND using the summary above #45990 (comment) |
$250 approved for @rushatgabhane based on this summary. |
When creating a list-type report field, we need to make sure the Initial value option comes after the list of values AND the List values option shows the created values as a comma-separated list, as shown below.
Note that the list values should not truncate but wrap to next line
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @muttmuureThe text was updated successfully, but these errors were encountered: