[HOLD for payment 2024-08-19] [$250] Track expense - App throws error when submitting track distance expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Click + > Track expense > Distance.
4. Submit a track distance expense.

Expected Result:

The track distance expense will be created successfully.

Actual Result:

App throws error when submitting track distance expense - There is a previously existing chat between these users.

Workaround:

Uncnown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565175_1723084027231.20240808_102342.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018888d22189418e67
• Upwork Job ID: 1821495281651751011
• Last Price Increase: 2024-08-08
• Automatic offers:
• jjcoffee | Reviewer | 103448882
• dominictb | Contributor | 103448883

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[pecanoro]

I can reproduce but if it's not coming from the back-end, I am wondering if we changed the API request in some PR, looking!

[pecanoro]

Oh, on production we call TrackExpense and we call CreateDistanceRequest on staging

[pecanoro]

It's coming from this PR: #42302

[pecanoro]

I am going to open it for proposals since everyone involved in the original PR is not online and if we don't get any, I will revert the original PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018888d22189418e67

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-08-08 11:42:06 UTC.

@pecanoro I can raise the PR asap to fix this

Proposal

Please re-state the problem that we are trying to solve in this issue.

App throws error when submitting track distance expense - There is a previously existing chat between these users.

What is the root cause of that problem?

In the PR #42302, we mistakenly moved the createDistanceRequest(iouType == condition to the top (this change https://github.com/Expensify/App/pull/42302/files#diff-5e5fc302dd5db871d26e30f810bc0606beccb7f50ae6ed6535cd93aaee98c280), causing it to be evaluated first and not trackExpense, so it calls CreateDistanceRequest in track distance expense case instead of TrackExpense

What changes do you think we should make in order to solve the problem?

Move this block back to its correct location before the PR which is here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 505 in 0926267

What alternative solutions did you explore? (Optional)

Update this block to

if (iouType !== CONST.IOU.TYPE.TRACK && isDistanceRequest && !isMovingTransactionFromTrackExpense) {
                createDistanceRequest(iouType === CONST.IOU.TYPE.SPLIT ? splitParticipants : selectedParticipants, trimmedComment);
                return;
            }

So it will only createDistanceRequest if it's not a track expense, we can extend the iouType check for other iou types if needed (if there're other IOU types that should not call createDistanceRequest but uses its own method, like track expense)

[dominictb]

Proposal updated to add alternative approach

[jjcoffee]

Hmm, I don't think we can just move createDistanceRequest back down as that would most likely cause a regression from #42302 since we'd call IOU.splitBill first and return early instead of creating the distance request for splitting.

I wonder if we also need to handle !isMovingTransactionFromTrackExpense covers the other conditions that result in calling trackExpense:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 446 in 717d344

if (iouType === CONST.IOU.TYPE.TRACK || isCategorizingTrackExpense || isSharingTrackExpense) {

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dominictb]

Thanks 🙏 On it now

[dominictb]

@jjcoffee The PR is ready.

[mvtglobally]

Looks resolved

Recording.663.mp4

[pecanoro]

Awesome, thank you! Removing deploy blocker

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] fix: track expense distance error #47077

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @dominictb $250 via Upwork - PAID
• Contributor+: @jjcoffee $250 via Upwork - PAID

Upwork job is here: https://www.upwork.com/jobs/~018888d22189418e67

[stephanieelliott]

Hey @jjcoffee can you please complete the BZ checklist for this when you get a sec?

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Enable distance splits #42302
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42302/files#r1723447110
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - should've been caught in checklist
• Determine if we should create a regression test for this bug. Yes - although one most likely already exists
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to self DM.
2. Click + > Track expense > Distance.
3. Submit a track distance expense.
4. Verify that the expense shows up with no errors.

Do we agree 👍 or 👎

[stephanieelliott]

Test case created! https://github.com/Expensify/Expensify/issues/422130

All done here, thanks!