[Hold for payment 2024-08-28] [$250] [P2P Distance] Split - Tax rate and Tax reclaimable are empty in the transaction thread

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Track tax is enabled.
• Tax rate and Tax reclaimable are filled in for the distance rate.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Split expense > Distance.
4. Split a distance expense using the distance rate from the precondition.
5. Click on the split preview.
6. Note that Tax rate and Tax reclaimable are filled in.
7. Go to the transaction thread of the split expense.

Expected Result:

Tax rate and Tax reclaimable have the correct info in the transaction thread.

Actual Result:

Tax rate and Tax reclaimable are empty in the transaction thread.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565401_1723106046705.20240808_162903.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d1cb3838667f8739
• Upwork Job ID: 1821526714732909137
• Last Price Increase: 2024-08-08
• Automatic offers:
• situchan | Reviewer | 103456830

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-split

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax code and amount is empty when creating split distance request.

What is the root cause of that problem?

When we are creating a split distance, it will call createSplitsAndOnyxData.

App/src/libs/actions/IOU.ts

Lines 5020 to 5040 in 0926267

	if (iouType === CONST.IOU.TYPE.SPLIT) {
	const {
	splitData,
	splits,
	onyxData: splitOnyxData,
	} = createSplitsAndOnyxData(
	participants,
	currentUserLogin ?? '',
	currentUserAccountID,
	amount,
	comment,
	currency,
	merchant,
	created,
	category ?? '',
	tag ?? '',
	splitShares,
	report?.reportID ?? '',
	billable,
	CONST.IOU.REQUEST_TYPE.DISTANCE,
	);

However, we don't pass the tax code and amount to createSplitsAndOnyxData.

What changes do you think we should make in order to solve the problem?

Pass both tax code and amount to createSplitsAndOnyxData.

const {
    splitData,
    splits,
    onyxData: splitOnyxData,
} = createSplitsAndOnyxData(
    ...,
    CONST.IOU.REQUEST_TYPE.DISTANCE,
    taxCode,
    taxAmount,
);

[twisterdotcom]

@mountiny is this right? I think we could just assign @bernhardoj now if so. I don't think we need to block a deploy with this as it's not an error, it's just unexpected behavior from a less frequently used flow.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d1cb3838667f8739

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[situchan]

@bernhardoj's proposal looks good.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[mountiny]

Sounds good

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @situchan

[bernhardoj]

PR is deployed to prod a week ago. This should be ready for payment.

Requested in ND.

[JmillsExpensify]

Awaiting payment summary

[twisterdotcom]

Payment Summary:

• @bernhardoj paid $250 via newDot requests (Contributor)
• @situchan paid $250 via Upwork here (C+)

[JmillsExpensify]

$250 approved for @bernhardoj