Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Expense-Skeleton shown below header after creating expense with violations offline #47152

Closed
2 of 6 tasks
izarutskaya opened this issue Aug 9, 2024 · 23 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18.4
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #44995
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user created a workspace, enabled the "Members must tag all expenses" and "Use multiple level of tags" toggles, and added Independent ot Dependent tags in OD

  1. Go to https://staging.new.expensify.com/
    and log in
  2. Go offline
  3. Click on FAB and submit a manual expense without selecting tags to a workspace with dependent tags enabled
  4. Navigate to the workspace chat
  5. Open the expense report
  6. Make a selection for required tags (Department, Region, Project)
  7. Return online

Expected Result:

There is no skeleton after returning online

Actual Result:

Skeleton is displayed below header after returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6566186_1723161495177.Recording__664.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0161e7cb21c8a1e8cd
  • Upwork Job ID: 1823406186287377629
  • Last Price Increase: 2024-09-03
Issue OwnerCurrent Issue Owner: @getusha
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

We think this issue might be related to the #wave-control

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@cead22
Copy link
Contributor

cead22 commented Aug 12, 2024

This looks like a legit issue related to offline handling of requests, but not related to #45760 or #44995. Offline handling of violations seems to be working well.

This could be related or similar to #47113

Copy link

melvin-bot bot commented Aug 12, 2024

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abekkala abekkala added the External Added to denote the issue can be worked on by a contributor label Aug 13, 2024
@melvin-bot melvin-bot bot changed the title Expense-Skeleton shown below header after creating expense with violations offline [$250] Expense-Skeleton shown below header after creating expense with violations offline Aug 13, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0161e7cb21c8a1e8cd

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

@abekkala, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
@getusha
Copy link
Contributor

getusha commented Aug 18, 2024

Waiting for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Aug 18, 2024
@abekkala
Copy link
Contributor

bumped slack for proposals

@melvin-bot melvin-bot bot added the Overdue label Aug 20, 2024
@codewaseem
Copy link
Contributor

I could not reproduce this issue.

Copy link

melvin-bot bot commented Aug 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 21, 2024

@abekkala, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@VincentCorleone
Copy link

I could not find "Use multiple level of tags" toggles and could not reproduce this issue.

@abekkala abekkala added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Aug 22, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

@abekkala @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Aug 23, 2024

@abekkala, @getusha Huh... This is 4 days overdue. Who can take care of this?

@getusha
Copy link
Contributor

getusha commented Aug 25, 2024

I will try reproducing this later today.

@melvin-bot melvin-bot bot removed the Overdue label Aug 25, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala
Copy link
Contributor

@getusha do you have an update on reproducing?

@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

@abekkala, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abekkala
Copy link
Contributor

@getusha bumping this

Copy link

melvin-bot bot commented Sep 2, 2024

@abekkala, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Sep 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala
Copy link
Contributor

abekkala commented Sep 3, 2024

unable to repro

@abekkala abekkala closed this as completed Sep 3, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Done
Development

No branches or pull requests

6 participants