Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take violations out of beta #45760

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Take violations out of beta #45760

merged 15 commits into from
Aug 7, 2024

Conversation

ShridharGoel
Copy link
Contributor

@ShridharGoel ShridharGoel commented Jul 19, 2024 •
edited
Loading

Details

Take violations out of beta.

Fixed Issues

$ #44995
PROPOSAL: #44995 (comment)

Test steps

#44995 (comment)

QA steps

#44995 (comment)

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-07-24.at.8.13.23.PM.mov
Screen.Recording.2024-07-24.at.8.06.33.PM.mov
Screen.Recording.2024-07-24.at.8.04.12.PM.mov
Screen.Recording.2024-07-24.at.8.01.29.PM.mov
Screen.Recording.2024-07-24.at.7.57.42.PM.mov
Screen.Recording.2024-07-24.at.7.36.09.PM.mov
Screen.Recording.2024-07-24.at.7.07.21.PM.mov
Android: mWeb Chrome
Screenrecording_20240722_012411.mp4
Screenrecording_20240725_173949.mp4
Screenrecording_20240725_174354.mp4
Screenrecording_20240725_174436.mp4
Screenrecording_20240725_175236.mp4
iOS: Native
Screen.Recording.2024-07-24.at.12.15.45.AM.mov
Screen.Recording.2024-07-23.at.8.59.12.PM.mov
Screen.Recording.2024-07-24.at.12.45.04.AM.mov
Screen.Recording.2024-07-24.at.12.40.53.AM.mov
Screen.Recording.2024-07-24.at.1.25.37.AM.mov
Screen.Recording.2024-07-24.at.1.30.44.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-07-24.at.11.09.00.PM.mov
Screen.Recording.2024-07-24.at.10.56.15.PM.mov
Screen.Recording.2024-07-24.at.10.50.06.PM.mov
Screen.Recording.2024-07-24.at.10.38.28.PM.mov
Screen.Recording.2024-07-24.at.10.36.04.PM.mov
Screen.Recording.2024-07-24.at.11.01.43.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-07-18.at.1.50.08.AM.mov
Screen.Recording.2024-07-18.at.1.39.40.AM.mov
Screen.Recording.2024-07-18.at.1.34.39.AM.mov
Screen.Recording.2024-07-18.at.1.30.12.AM.mov
Screen.Recording.2024-07-18.at.1.03.46.AM.mov
Screen.Recording.2024-07-17.at.11.12.13.PM.mov
Screen.Recording.2024-07-17.at.11.11.31.PM.mov
Screen.Recording.2024-07-17.at.11.10.42.PM.mov
Screen.Recording.2024-07-13.at.12.57.49.AM.mov
Screen.Recording.2024-07-13.at.1.05.18.AM.mov
Screen.Recording.2024-07-17.at.11.06.09.PM.mov
Screen.Recording.2024-07-13.at.12.59.16.AM.mov
Screen.Recording.2024-07-13.at.12.59.02.AM.mov
Screen.Recording.2024-07-20.at.1.20.01.AM.mov
Screen.Recording.2024-07-20.at.7.51.09.PM.mov
Screen.Recording.2024-07-21.at.11.03.29.PM.mov
Screen.Recording.2024-07-21.at.11.05.15.PM.mov
Screen.Recording.2024-07-23.at.11.22.49.PM.mov
Screenshot 2024-07-24 at 7 53 59 PM
MacOS: Desktop
Screen.Recording.2024-07-24.at.6.44.31.PM.mov
Screen.Recording.2024-07-24.at.5.22.42.PM.mov
Screen.Recording.2024-07-24.at.5.20.33.PM.mov
Screen.Recording.2024-07-24.at.5.18.41.PM.mov
Screen.Recording.2024-07-24.at.5.16.47.PM.mov
Screen.Recording.2024-07-24.at.5.11.11.PM.mov
Screen.Recording.2024-07-24.at.5.09.45.PM.mov
Screen.Recording.2024-07-24.at.5.12.00.PM.mov
Screen.Recording.2024-07-24.at.5.27.01.PM.mov

@ShridharGoel ShridharGoel requested a review from a team as a code owner July 19, 2024 11:39
@melvin-bot melvin-bot bot removed the request for review from a team July 19, 2024 11:39
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 19, 2024

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from getusha July 19, 2024 11:39
@ShridharGoel ShridharGoel marked this pull request as draft July 19, 2024 11:39
@ShridharGoel ShridharGoel marked this pull request as ready for review July 23, 2024 18:48
getusha
getusha reviewed Jul 24, 2024
View reviewed changes
tests/unit/SidebarOrderTest.ts
@@ -12,7 +12,6 @@ import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatch

// Be sure to include the mocked Permissions and Expensicons libraries as well as the usePermissions hook or else the beta tests won't work
jest.mock('@libs/Permissions');
jest.mock('@hooks/usePermissions.ts');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this? is this only needed for violations beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since this was setting the beta value.

@ShridharGoel
Copy link
Contributor Author

@getusha Can you have a look when possible?

getusha
getusha reviewed Jul 30, 2024
View reviewed changes
tests/unit/SidebarOrderTest.ts Outdated Show resolved Hide resolved
tests/unit/SidebarTest.ts Outdated Show resolved Hide resolved
@getusha
Copy link
Contributor

getusha commented Jul 30, 2024

@ShridharGoel could you structure the videos with their respective title?

@getusha
Copy link
Contributor

getusha commented Jul 30, 2024 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Missing tag and missing category violations

Manual Request

Android: Native
Screen.Recording.2024-08-02.at.6.08.11.in.the.evening.mov
Android: mWeb Chrome
Screen.Recording.2024-08-02.at.6.47.54.in.the.evening.mov
iOS: Native
Screen.Recording.2024-08-02.at.7.00.36.in.the.evening.mov
iOS: mWeb Safari
Screen.Recording.2024-08-02.at.8.37.46.in.the.evening.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-02.at.7.23.10.in.the.evening.mov
MacOS: Desktop
Screen.Recording.2024-08-02.at.7.30.25.in.the.evening.mov

Scan Request

Android: Native
Screen.Recording.2024-08-01.at.3.26.12.in.the.afternoon.mov
Android: mWeb Chrome
Screen.Recording.2024-08-02.at.7.46.32.in.the.evening.mov
iOS: Native
Screen.Recording.2024-08-05.at.11.19.35.in.the.morning.mov
iOS: mWeb Safari
Screen.Recording.2024-08-05.at.11.16.39.in.the.morning.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-02.at.7.39.55.in.the.evening.mov
MacOS: Desktop
Screen.Recording.2024-08-05.at.11.26.21.in.the.morning.1.mov

Distance Request

Android: Native
Screen.Recording.2024-08-01.at.3.32.15.in.the.afternoon.mov
Android: mWeb Chrome
Screen.Recording.2024-08-05.at.3.30.51.in.the.afternoon.mov
iOS: Native
Screen.Recording.2024-08-05.at.3.13.08.in.the.afternoon.mov
iOS: mWeb Safari
Screen.Recording.2024-08-05.at.3.33.39.in.the.afternoon.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-05.at.11.48.09.in.the.morning.mov
MacOS: Desktop
Screen.Recording.2024-08-05.at.11.48.09.in.the.morning.mov

Category out of policy, tag out of policy violation, expense over limit, max age, over category limit, receipt required

Manual Request

Android: Native
Screen.Recording.2024-08-02.at.1.05.31.in.the.afternoon.mov
Screen.Recording.2024-08-02.at.1.26.38.in.the.afternoon.mov
Android: mWeb Chrome
screen-recording-2024-08-05-at-33827-in-the-afternoon_jnmZPxfP.mp4
iOS: Native
Screen.Recording.2024-08-05.at.3.45.29.in.the.afternoon.mov
iOS: mWeb Safari
Screen.Recording.2024-08-05.at.3.50.17.in.the.afternoon.1.mov
MacOS: Chrome / Safari
screen-recording-2024-08-05-at-61527-in-the-evening_y6DNTWVG.mp4
MacOS: Desktop

Screenshot 2024-08-05 at 6 20 57 in the evening

Screenshot 2024-08-05 at 6 21 22 in the evening

Scan Request

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Distance Request

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Tag violations on workspace with Independent Tags (multi-level tags)

Manual Request

Android: Native
Screen.Recording.2024-08-02.at.3.24.22.in.the.afternoon.mov
Android: mWeb Chrome

Screenshot 2024-08-02 at 5 41 16 in the afternoon

iOS: Native
Screen.Recording.2024-08-05.at.8.43.23.in.the.evening.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-08-02.at.3.41.45.in.the.afternoon.mov
MacOS: Desktop

Screenshot 2024-08-02 at 5 53 48 in the afternoon

Screenshot 2024-08-02 at 5 53 57 in the afternoon

Tag violations on workspace with Dependent Tags (multi-level tags)

Manual Request

Android: Native
Screen.Recording.2024-08-06.at.12.34.35.in.the.afternoon.mov
Android: mWeb Chrome
Screen.Recording.2024-08-06.at.12.48.04.in.the.afternoon.mov
iOS: Native
Screen.Recording.2024-08-06.at.12.24.33.in.the.afternoon.mov
iOS: mWeb Safari
Screen.Recording.2024-08-06.at.12.54.21.in.the.afternoon.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-06.at.1.00.53.in.the.afternoon.mov
MacOS: Desktop
screen-recording-2024-08-06-at-10251-in-the-afternoon_SK3owjr4.mp4

Receipt Audit Scan

Android: Native
Screen.Recording.2024-08-06.at.1.23.02.in.the.afternoon.mov
Android: mWeb Chrome
screen-recording-2024-08-06-at-11718-in-the-afternoon_LLcYYrUu.mp4
iOS: Native
Screen.Recording.2024-08-06.at.1.35.36.in.the.afternoon.mov
iOS: mWeb Safari
Screen.Recording.2024-08-06.at.1.31.05.in.the.afternoon.mov
MacOS: Chrome / Safari
screen-recording-2024-08-06-at-14409-in-the-afternoon_M4ndusLK.mp4
MacOS: Desktop
screen-recording-2024-08-06-at-13736-in-the-afternoon_m49tGfRx.mp4

Receipt Audit - Receipt Not Verified

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Screenshot 2024-08-06 at 10 09 17 at night

MacOS: Desktop

Screenshot 2024-08-06 at 10 36 08 at night

@cead22
Copy link
Contributor

cead22 commented Jul 31, 2024

  • @getusha I know there's a lot to test here, but I'm curious if you have an ETA for when you'll have the reviewer checklist ready
  • @ShridharGoel there's a small lint error that you need to fix before we can merge

@getusha
Copy link
Contributor

getusha commented Jul 31, 2024

@getusha I know there's a lot to test here, but I'm curious if you have an ETA for when you'll have the reviewer checklist ready

I should be able to complete it by EOD tomorrow, at the latest.

@cead22
Copy link
Contributor

cead22 commented Aug 1, 2024

Awesome, thanks!

@getusha
Copy link
Contributor

getusha commented Aug 1, 2024

I think you missed this @ShridharGoel #45760 (comment)

@ShridharGoel
Copy link
Contributor Author

ShridharGoel commented Aug 1, 2024 •
edited
Loading

could you structure the videos with their respective title?

Checking, though the videos are mix-up of different parts.

@getusha
Copy link
Contributor

getusha commented Aug 1, 2024

Verify you see the Missing Category red text under the category row

Category is selected by default, if you leave it blank. which fails ^

  1. Have one category under the recently section
  2. Submit expense without filling Category and Tags
Screen.Recording.2024-08-01.at.3.21.35.in.the.afternoon.mov

Could you reproduce this? @ShridharGoel

@ShridharGoel
Copy link
Contributor Author

@getusha I don't think so. Is it happening each time?

@getusha
Copy link
Contributor

getusha commented Aug 1, 2024

@getusha I don't think so. Is it happening each time?

Yes, could you try following the steps here #45760 (comment)?

@ShridharGoel
Copy link
Contributor Author

Screen.Recording.2024-08-01.at.6.37.54.PM.mov

@getusha
Copy link
Contributor

getusha commented Aug 1, 2024

@ShridharGoel i can still reproduce it, could you try with Tags enabled?

@getusha
Copy link
Contributor

getusha commented Aug 1, 2024

Switch back to new dot, and refresh the page
Verify you see Category no longer valid violation
Verify you see Tag no longer valid violation

This is failing for Tag on android native after disabling the selected tag from old dot

Screen.Recording.2024-08-01.at.5.44.34.in.the.afternoon.mov

@ShridharGoel
Copy link
Contributor Author

Screen.Recording.2024-08-01.at.6.46.33.PM.mov

@cead22
Copy link
Contributor

cead22 commented Aug 1, 2024

If you're getting a category applied automatically it's probably due to a feature we call "implicit autocategorization", and you can work around it by using a new random merchant name every time.

What this feature does is, when you add a category to a transaction with a specific merchant, next time you create another transaction with the same merchant, we'll assume the category is the same on you used the previous time for the same merchant.

That said, if a category is applied, you can de-select it and then confirm the "missing category" violation is present.

@cead22
Copy link
Contributor

cead22 commented Aug 1, 2024

What's the ETA on getting all the videos uploaded and the review complete? Also, please follow the checklist for the console warnings & errors

  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

@getusha
Copy link
Contributor

getusha commented Aug 2, 2024

What's the ETA on getting all the videos uploaded and the review complete?

I am on it, tests are failing for me, started a thread https://expensify.slack.com/archives/C01GTK53T8Q/p1722592136673719

@getusha
Copy link
Contributor

getusha commented Aug 2, 2024

BUG: Tag no longer valid appears on optional multilevel tag after changing a required tag

  1. Enable multiple levels of tag (oldDot)
  2. Import the tags from [HOLD for payment 2024-03-19] [Violations] Implement violations for mutiple tag lists #37117 (comment) (oldDot)
  3. Mark the first two tags not required (oldDot)
  4. Submit expense > Enter amount > Enter merchant > Submit
  5. Open the expense preview
  6. Select a project from the project multi-tag
Screen.Recording.2024-08-02.at.6.36.34.in.the.evening.mov

@melvin-bot melvin-bot bot requested a review from cead22 August 6, 2024 20:14
@cead22
Copy link
Contributor

cead22 commented Aug 7, 2024

  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

@getusha can you report these and link the slack convo here please? Thanks

@cead22 cead22 merged commit 8c11aa4 into Expensify:main Aug 7, 2024
15 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Closed
88 tasks
@kavimuru
Copy link

kavimuru commented Aug 7, 2024

@cead22 Should we run all the steps in the linked PR? We do most of them in regular regression run

@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2024

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.18-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@getusha
Copy link
Contributor

getusha commented Aug 11, 2024

@getusha can you report these and link the slack convo here please? Thanks

@cead22 I noticed an error that's only visible in Dev. Should I raise a PR to fix it? Also, do we need to report the warnings on native platforms?

@melvin-bot melvin-bot bot mentioned this pull request Aug 12, 2024
Closed
49 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Aug 12, 2024
Closed
Closed
Closed
@cead22
Copy link
Contributor

cead22 commented Aug 14, 2024

@cead22 I noticed an error that's only visible in Dev. Should I raise a PR to fix it? Also, do we need to report the warnings on native platforms?

@getusha Yes and yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getusha getusha getusha approved these changes

@cead22 cead22 cead22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShridharGoel @getusha @cead22 @OSBotify @kavimuru