[HOLD for payment 2024-08-19] Onboarding - Onboarding modal disappears when navigate to home page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4837595&group_by=cases:section_id&group_order=asc&group_id=229043
Email or phone of affected tester (no customers): gocemate+a894@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Sign in as a new gmail user
2. Verify the onboarding modal shows
3. During the onboarding modal navigate to staging.new.expensify.com/home

Expected Result:

Onboarding modal should display even if the users navigate away or close/reopen the app if the user has not finished it.

Actual Result:

Onboarding modal disappears when navigate to home page via link

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6566524_1723196843516.Recording__3672.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[srikarparsi]

This might be related to this PR. Going to revert and test. Also, this is should be frontend so removing the Deploy Blocker label.

[srikarparsi]

That revert didn't fix it but I was looking around and this issue looks very related to this one here and might be fixed by this PR. Asked in the PR

[srikarparsi]

This is also the issue I believe it might've come from so tagging @DylanDylann and @nkdengineer for visibility.

[srikarparsi]

This PR will fix this issue. Added a comment explaining.

[srikarparsi]

PR merged, being CPed

[srikarparsi]

Closing this issue since the PR has been fixed and CPed. Payment is being taken care of in this issue since there is more context. (Both issues have the same root cause). Please reopen if I missed something.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix onboarding promise #47097

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: