[HOLD for payment 2024-08-19] [$250] Sign in – Onboarding modal is missing in new tab

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v.9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): ponikarchuks+98824@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. In Sign in page enter new Gmail account
3. When Onboarding modal appears open new tab and paste https://staging.new.expensify.com/

Expected Result:

Onboarding modal is present in new tab

Actual Result:

Onboarding modal is missing in new tab

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565266_1723093480769.Onboarding_modal.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f33db55519f8fc02
• Upwork Job ID: 1821535504288913507
• Last Price Increase: 2024-08-08
• Automatic offers:
• ishpaul777 | Contributor | 103468942

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[trjExpensify]

So strange. Can't reproduce with private domain, can reproduce with public domain:

2024-08-08_14-11-43.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f33db55519f8fc02

[trjExpensify]

Let's get some eyes on it.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[NikkiWines]

Might be related to #46750 since it changes when/why we show the onboarding modal, will try to reproduce locally now

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding modal is missing in new tab

What is the root cause of that problem?

When we open a new tab, the isOnboardingFlowStatusKnownPromise promise reset after we call isOnboardingFlowCompleted here

App/src/libs/actions/Welcome.ts

Lines 178 to 180 in d7b0aba

	isOnboardingFlowStatusKnownPromise = new Promise<OnboardingData>((resolve) => {
	resolveOnboardingFlowStatus = resolve;
	});

Then it will never be triggered to open the the onboarding modal.

What changes do you think we should make in order to solve the problem?

We should only use resolveOnboardingFlowStatus to resolve isOnboardingFlowStatusKnownPromise promise when the onboarding is ready to use.

let resolveOnboardingFlowStatus: () => void;
let isOnboardingFlowStatusKnownPromise = new Promise<void>((resolve) => {
    resolveOnboardingFlowStatus = resolve;
});

We will create a global variable onboarding to store the onboarding data

let onboarding: Onboarding | undefined | [];
Onyx.connect({
    key: ONYXKEYS.NVP_ONBOARDING,
    callback: (value) => {
        if (value === undefined) {
            return;
        }
        if (onboarding === undefined) {
            onboarding = value;
            resolveOnboardingFlowStatus();
        } else {
            onboarding = value;
        }
    },
});

and then use it here

isOnboardingFlowStatusKnownPromise.then(() => {

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-08-08.at.21.25.43.mov

[dominictb]

@NikkiWines I can raise a PR to fix the issue ASAP.

[jayeshmangwani]

When we open a new tab, the isOnboardingFlowStatusKnownPromise promise reset after we call isOnboardingFlowCompleted here

@dominictb I don't think this is the root cause. The issue is happening on staging and not in production, so any recent PR may have caused this problem.

[dominictb]

@jayeshmangwani We resolved the promise and then reset it here. Then if isOnboardingFlowCompleted is called after the promise resets, it never triggers because the onboarding in Onyx doesn't change again.

App/src/libs/actions/Welcome.ts

Lines 177 to 179 in d7b0aba

	resolveOnboardingFlowStatus(value);
	isOnboardingFlowStatusKnownPromise = new Promise<OnboardingData>((resolve) => {
	resolveOnboardingFlowStatus = resolve;

[fedirjh]

I don't think this is the root cause. The issue is happening on staging and not in production, so any recent PR may have caused this problem.

@jayeshmangwani The changes that @dominictb pointed out in his proposal are recently added in this PR, which is deployed to staging recently :

• fix: Concierge chat opens when change priority mode to Most recent #46559

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[NikkiWines]

@ishpaul777 reviewed, adding assingment

[marcaaron]

Fixed with a CP

[dominictb]

@NikkiWines Should I eligible for compenstation since this PR uses my proposal here?. The only difference is it creates a new function to resolve the onboarding promise.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix onboarding promise #47097

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NikkiWines]

@NikkiWines Should I eligible for compenstation since this #47097 uses my proposal #47054 (comment)?. The only difference is it creates a new function to resolve the onboarding promise.

@dominictb Yes, since the core logic used in the fix is the same, I think some compensation should be provided as the issue had been marked as external and help wanted at the time of your proposal being made. @trjExpensify what do you think?

[trjExpensify]

I think we can do a partial payment agreed, so when this comes around, I'll be sure to send an offer for $125.

[ishpaul777]

Ready for payment 🎉

[ishpaul777]

gentle bump @trjExpensify : )

[melvin-bot]

@trjExpensify, @NikkiWines, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Yup, I've been OoO. Payment summary as follows:

• $125 to @dominictb for contributing to the proposed fix
• $250 to @ishpaul777 for the C+ review

@ishpaul777 paid, @dominictb I've reached out to you for your Upwork profile.

[trjExpensify]

@dominictb offer now sent.

[dominictb]

@trjExpensify Offer accepted 🙏

[trjExpensify]

Paid, closing!